From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 576D2C63697 for ; Thu, 26 Nov 2020 15:05:41 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id B39FF20B80 for ; Thu, 26 Nov 2020 15:05:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B39FF20B80 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id DA8656B0074; Thu, 26 Nov 2020 10:05:39 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D597C6B0075; Thu, 26 Nov 2020 10:05:39 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C47BC6B0078; Thu, 26 Nov 2020 10:05:39 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0078.hostedemail.com [216.40.44.78]) by kanga.kvack.org (Postfix) with ESMTP id AE93F6B0074 for ; Thu, 26 Nov 2020 10:05:39 -0500 (EST) Received: from smtpin02.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 73CA08249980 for ; Thu, 26 Nov 2020 15:05:39 +0000 (UTC) X-FDA: 77526893598.02.quill56_1610d0227380 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin02.hostedemail.com (Postfix) with ESMTP id 4807210097AA2 for ; Thu, 26 Nov 2020 15:05:39 +0000 (UTC) X-HE-Tag: quill56_1610d0227380 X-Filterd-Recvd-Size: 2995 Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf49.hostedemail.com (Postfix) with ESMTP for ; Thu, 26 Nov 2020 15:05:38 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 3A9DEACE0; Thu, 26 Nov 2020 15:05:37 +0000 (UTC) Received: by quack2.suse.cz (Postfix, from userid 1000) id C51F51E10D0; Thu, 26 Nov 2020 16:05:36 +0100 (CET) Date: Thu, 26 Nov 2020 16:05:36 +0100 From: Jan Kara To: Christoph Hellwig Cc: Jens Axboe , Tejun Heo , Josef Bacik , Coly Li , Mike Snitzer , Greg Kroah-Hartman , Jan Kara , Johannes Thumshirn , dm-devel@redhat.com, Jan Kara , linux-block@vger.kernel.org, linux-bcache@vger.kernel.org, linux-mtd@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 21/44] block: move bdput() to the callers of __blkdev_get Message-ID: <20201126150536.GH422@quack2.suse.cz> References: <20201126130422.92945-1-hch@lst.de> <20201126130422.92945-22-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201126130422.92945-22-hch@lst.de> User-Agent: Mutt/1.10.1 (2018-07-13) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu 26-11-20 14:03:59, Christoph Hellwig wrote: > This will allow for a more symmetric calling convention going forward. > > Signed-off-by: Christoph Hellwig Looks good to me. You can add: Reviewed-by: Jan Kara Honza > --- > fs/block_dev.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/fs/block_dev.c b/fs/block_dev.c > index 86a61a2141f642..d0783c55a0ce65 100644 > --- a/fs/block_dev.c > +++ b/fs/block_dev.c > @@ -1458,6 +1458,7 @@ static int __blkdev_get(struct block_device *bdev, struct gendisk *disk, > if (!(disk->flags & GENHD_FL_UP) || > !bdev->bd_part || !bdev->bd_part->nr_sects) { > __blkdev_put(whole, mode, 1); > + bdput(whole); > ret = -ENXIO; > goto out_clear; > } > @@ -1740,9 +1741,10 @@ static void __blkdev_put(struct block_device *bdev, fmode_t mode, int for_part) > disk->fops->release(disk, mode); > } > mutex_unlock(&bdev->bd_mutex); > - bdput(bdev); > - if (victim) > + if (victim) { > __blkdev_put(victim, mode, 1); > + bdput(victim); > + } > } > > void blkdev_put(struct block_device *bdev, fmode_t mode) > @@ -1792,6 +1794,7 @@ void blkdev_put(struct block_device *bdev, fmode_t mode) > mutex_unlock(&bdev->bd_mutex); > > __blkdev_put(bdev, mode, 0); > + bdput(bdev); > put_disk_and_module(disk); > } > EXPORT_SYMBOL(blkdev_put); > -- > 2.29.2 > -- Jan Kara SUSE Labs, CR