From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.5 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7108C64E7A for ; Wed, 25 Nov 2020 19:37:25 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 431912063A for ; Wed, 25 Nov 2020 19:37:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="VfNp8/1Q" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 431912063A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id DA6286B0072; Wed, 25 Nov 2020 14:37:23 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D34876B0073; Wed, 25 Nov 2020 14:37:23 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A23DD6B0074; Wed, 25 Nov 2020 14:37:23 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0123.hostedemail.com [216.40.44.123]) by kanga.kvack.org (Postfix) with ESMTP id 8994E6B0072 for ; Wed, 25 Nov 2020 14:37:23 -0500 (EST) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 51D4F3637 for ; Wed, 25 Nov 2020 19:37:23 +0000 (UTC) X-FDA: 77523949566.06.yard57_5a068ef27379 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin06.hostedemail.com (Postfix) with ESMTP id 2C8BD1003DAEC for ; Wed, 25 Nov 2020 19:37:23 +0000 (UTC) X-HE-Tag: yard57_5a068ef27379 X-Filterd-Recvd-Size: 8473 Received: from mail-io1-f43.google.com (mail-io1-f43.google.com [209.85.166.43]) by imf25.hostedemail.com (Postfix) with ESMTP for ; Wed, 25 Nov 2020 19:37:22 +0000 (UTC) Received: by mail-io1-f43.google.com with SMTP id s10so3311480ioe.1 for ; Wed, 25 Nov 2020 11:37:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=0KO/M/u0SKyAHiDpRJL18ynfwCIfU26Y/ceTy3bOazY=; b=VfNp8/1QKA/Nsh0aFCVcwN1562EED1Jd2vd71rfujQQeoL5LCoATCM/VgE8sCyaGfg ZtiRD+8DK8eBG2O/8GKjCH7qz63Lw0OGUHNihV+c9AsGOIxTFK7t60TLY5qD61vky1R6 wwjsw2pUiecEeaJmg6tjo3FtR5hP3NtwZO78RQYrlpotqkGtBIMbVz8Pa6kDxxUSM/MF 696JIsVhJHqONalD5rWOqJzskVfW6efhU9soy4C4WpB3ZDlgkTq58nJnSJW6yJR/HGIl 2gw3BZcHGZxgPF9HkhXPbHzYXsA55JU/b/6gZExoATdGPSU/Z9wued0PmZMsQqpXBtWS ZbnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=0KO/M/u0SKyAHiDpRJL18ynfwCIfU26Y/ceTy3bOazY=; b=gyFVpW3rc9hgZ8WYwpmsy4k4Y+KVZqgC1vNVCG/xf1caQYJjslNrls42bbkyszNwAK Dz1XlJLaIgDs2/tcfpQJzTJe+ArIeZLfpuV8uH4tnuxAu4Ujp/IJKweOOupWUJ9yErCH tnJu0eaN1ReI/5FwW/upF6j3gVwSh06usx8glgFaILsliyh0YaTuZPUCYzWiT1EmBgs+ ArGmgtcYCEaXMrSzBP5siAByLonHOpxyzkrqd/HTQKcO6troKeZOGQJkL4ztpz/BurcY Spk0Amfq437vUrMCBitJmDgX2MJcWQdbx4Fwb8zar9f6AWLecTssg0lpXayUPlzN6+RU X9jA== X-Gm-Message-State: AOAM533rTSXS5AHqt5flja1xxBDo1ILZk0L+/28ue9zDhOiwShQfxhxF OgS/CkJ1KAakQfqPTSuBbflrLU7nucM= X-Google-Smtp-Source: ABdhPJxerGLSlABi7avZmWHb6tL0Sa17Gu8SHBI7l4xXs/pdWZOr7Zg3dgBc1LVoiYuV/2Z9rUYrIw== X-Received: by 2002:a6b:6418:: with SMTP id t24mr3908358iog.145.1606333041808; Wed, 25 Nov 2020 11:37:21 -0800 (PST) Received: from frodo.mearth (c-24-9-77-57.hsd1.co.comcast.net. [24.9.77.57]) by smtp.googlemail.com with ESMTPSA id f8sm1435548ioc.24.2020.11.25.11.37.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Nov 2020 11:37:21 -0800 (PST) From: Jim Cromie To: linux-mm@kvack.org Cc: gregkh@linuxfoundation.org, linux@rasmusvillemoes.dk, Jim Cromie , Jason Baron , linux-kernel@vger.kernel.org Subject: [PATCH 3/7] dyndbg: add some code to see alignments of linkage data Date: Wed, 25 Nov 2020 12:36:22 -0700 Message-Id: <20201125193626.2266995-4-jim.cromie@gmail.com> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20201125193626.2266995-1-jim.cromie@gmail.com> References: <20201125193626.2266995-1-jim.cromie@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: To be able to use LSB-stealing (lsb as flag, mask b4 addressing), we need to know that the alignments of existing data is never odd. So add code to check the alignment of pointers in _dyndbg_callsites section. It turns out that all these fields point to a variety of odd alignments in the deeper linkage data. We will need ALIGN(2) to allow use of LSB to signal the EOT of differing-tail records. [ 0.587654] dyndbg: 2014 entries. \ repeated entries: 1789 module 1667 file 809 func [ 0.588653] dyndbg: mod aligns: [ 0.589130] dyndbg: align 0 0: 107 [ 0.589653] dyndbg: align 0 1: 210 [ 0.590271] dyndbg: align 0 2: 234 [ 0.590652] dyndbg: align 0 3: 179 [ 0.591224] dyndbg: align 0 4: 358 [ 0.591652] dyndbg: align 0 5: 374 [ 0.592283] dyndbg: align 0 6: 231 [ 0.592653] dyndbg: align 0 7: 321 [ 0.593203] dyndbg: mod align totals: 2014 [ 0.593652] dyndbg: file aligns: [ 0.594168] dyndbg: align 1 0: 569 [ 0.594652] dyndbg: align 1 1: 172 [ 0.595179] dyndbg: align 1 2: 263 [ 0.595652] dyndbg: align 1 3: 252 [ 0.596368] dyndbg: align 1 4: 200 [ 0.596652] dyndbg: align 1 5: 126 [ 0.597327] dyndbg: align 1 6: 177 [ 0.597669] dyndbg: align 1 7: 255 [ 0.598316] dyndbg: file align totals: 2014 [ 0.598652] dyndbg: func aligns: [ 0.599214] dyndbg: align 2 0: 2006 [ 0.599652] dyndbg: align 2 1: 7 [ 0.600168] dyndbg: align 2 2: 0 [ 0.600648] dyndbg: align 2 3: 0 [ 0.600652] dyndbg: align 2 4: 0 [ 0.601105] dyndbg: align 2 5: 0 [ 0.601652] dyndbg: align 2 6: 0 [ 0.602203] dyndbg: align 2 7: 1 [ 0.602654] dyndbg: func align totals: 2014 [ 0.603431] dyndbg: format aligns: [ 0.603658] dyndbg: align 3 0: 1053 [ 0.604429] dyndbg: align 3 1: 134 [ 0.604653] dyndbg: align 3 2: 161 [ 0.605181] dyndbg: align 3 3: 142 [ 0.605652] dyndbg: align 3 4: 137 [ 0.606250] dyndbg: align 3 5: 117 [ 0.606652] dyndbg: align 3 6: 124 [ 0.607183] dyndbg: align 3 7: 146 [ 0.608669] dyndbg: earlyprintk=3D"serial,ttyS0,115200" This means low order bits are unavailable for encoding extra info, as is done in struct static_key. Consider the last lines of /proc/dynamic_debug/control, here with matching fields replaced by '^'. The pattern here is common head(s) & differing tail(s). init/main.c main run_init_process " %s\012" 1339 ^ ^ ^ " with environment:\012" 1337 ^ ^ ^ " %s\012" 1336 ^ ^ ^ " with arguments:\012" 1334 ^ ^ initcall_blacklisted "initcall %s blacklisted\012" 1123 ^ ^ initcall_blacklist "blacklisting initcall %s\012" 1084 struct ddebug_callsite fields [mod, file, func, format] are 4-tuples; each element points at different kinds/sources of linkage data (&module->name, __FILE__, __FUNC__, format-strings). callsite-tails are 4,3,2,1-tuples, with matching heads removed. If we can force ALIGN(2) on all those linkage data sources, then we can use +1 to mark the Beginning-Of-Tuple (or EOT), and so distinguish amongst the N-tuples, and reconstruct each record by copying and changing the previous record. Each new module block starts with a 4-tuple; the init/main example block above is a 4,1,1,1,2,2-tuple sequence, using 11/24 of the space. Signed-off-by: Jim Cromie --- lib/dynamic_debug.c | 27 ++++++++++++++++++++++++++- 1 file changed, 26 insertions(+), 1 deletion(-) diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c index 5980d44ff2f8..c84efb4e036b 100644 --- a/lib/dynamic_debug.c +++ b/lib/dynamic_debug.c @@ -1079,6 +1079,13 @@ static int __init dynamic_debug_init_control(void) return 0; } =20 + +static __initdata int alignments[4][8]; +static void bump_ct(int i, const char *p) +{ + alignments[i][ (long)p & 7 ]++; +} + static int __init dynamic_debug_init(void) { struct _ddebug *iter, *iter_start, *prev =3D NULL; @@ -1087,7 +1094,9 @@ static int __init dynamic_debug_init(void) int ret =3D 0; int n =3D 0, entries =3D 0, modct =3D 0; int modreps =3D 0, funcreps =3D 0, filereps =3D 0; - + int i,k; + char *kind[] =3D { "mod","file","func","format" }; +=09 if (&__start___dyndbg =3D=3D &__stop___dyndbg) { if (IS_ENABLED(CONFIG_DYNAMIC_DEBUG)) { pr_warn("_ddebug table is empty in a CONFIG_DYNAMIC_DEBUG build\n"); @@ -1111,6 +1120,12 @@ static int __init dynamic_debug_init(void) prev++; /* one behind iter */ } entries++; + + bump_ct(0, iter->site->modname); + bump_ct(1, iter->site->filename); + bump_ct(2, iter->site->function); + bump_ct(3, iter->site->format); + if (strcmp(modname, iter->site->modname)) { modct++; ret =3D ddebug_add_module(iter_start, n, modname); @@ -1135,6 +1150,16 @@ static int __init dynamic_debug_init(void) vpr_info("%d entries. repeated entries: %d module %d file %d func\n", entries, modreps, filereps, funcreps); =20 + /* display alignment info on fields */ + for (i=3D0; i<4; i++) { + k =3D 0; + vpr_info("%s aligns:\n", kind[i]); + for (n=3D0; n<8; n++) { + vpr_info(" align %d %d: %d\n", i, n, alignments[i][n]); + k +=3D alignments[i][n]; + } + vpr_info(" %s align totals: %d\n", kind[i], k); + } /* apply ddebug_query boot param, dont unload tables on err */ if (ddebug_setup_string[0] !=3D '\0') { pr_warn("ddebug_query param name is deprecated, change it to dyndbg\n"= ); --=20 2.28.0