From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CBFA0C5519F for ; Wed, 25 Nov 2020 13:39:24 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 4782120637 for ; Wed, 25 Nov 2020 13:39:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4782120637 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B753E6B0074; Wed, 25 Nov 2020 08:39:23 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B25316B0075; Wed, 25 Nov 2020 08:39:23 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A629D6B007B; Wed, 25 Nov 2020 08:39:23 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0116.hostedemail.com [216.40.44.116]) by kanga.kvack.org (Postfix) with ESMTP id 8CFD76B0074 for ; Wed, 25 Nov 2020 08:39:23 -0500 (EST) Received: from smtpin22.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 264D61EE6 for ; Wed, 25 Nov 2020 13:39:23 +0000 (UTC) X-FDA: 77523047406.22.cat13_5a151af27377 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin22.hostedemail.com (Postfix) with ESMTP id 0A02618038E60 for ; Wed, 25 Nov 2020 13:39:23 +0000 (UTC) X-HE-Tag: cat13_5a151af27377 X-Filterd-Recvd-Size: 2690 Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf05.hostedemail.com (Postfix) with ESMTP for ; Wed, 25 Nov 2020 13:39:22 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id BCF50AC23; Wed, 25 Nov 2020 13:39:20 +0000 (UTC) Received: by quack2.suse.cz (Postfix, from userid 1000) id 8ACF21E130F; Wed, 25 Nov 2020 14:39:20 +0100 (CET) Date: Wed, 25 Nov 2020 14:39:20 +0100 From: Jan Kara To: Christoph Hellwig Cc: Jens Axboe , Tejun Heo , Josef Bacik , Konrad Rzeszutek Wilk , Coly Li , Mike Snitzer , Greg Kroah-Hartman , Jan Kara , Johannes Thumshirn , dm-devel@redhat.com, Richard Weinberger , Jan Kara , linux-block@vger.kernel.org, xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org, linux-mtd@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 12/45] block: remove a superflous check in blkpg_do_ioctl Message-ID: <20201125133920.GL16944@quack2.suse.cz> References: <20201124132751.3747337-1-hch@lst.de> <20201124132751.3747337-13-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201124132751.3747337-13-hch@lst.de> User-Agent: Mutt/1.10.1 (2018-07-13) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue 24-11-20 14:27:18, Christoph Hellwig wrote: > sector_t is now always a u64, so this check is not needed. > > Signed-off-by: Christoph Hellwig Looks good. You can add: Reviewed-by: Jan Kara Honza > --- > block/ioctl.c | 9 --------- > 1 file changed, 9 deletions(-) > > diff --git a/block/ioctl.c b/block/ioctl.c > index 6b785181344fe1..0c09bb7a6ff35f 100644 > --- a/block/ioctl.c > +++ b/block/ioctl.c > @@ -35,15 +35,6 @@ static int blkpg_do_ioctl(struct block_device *bdev, > start = p.start >> SECTOR_SHIFT; > length = p.length >> SECTOR_SHIFT; > > - /* check for fit in a hd_struct */ > - if (sizeof(sector_t) < sizeof(long long)) { > - long pstart = start, plength = length; > - > - if (pstart != start || plength != length || pstart < 0 || > - plength < 0 || p.pno > 65535) > - return -EINVAL; > - } > - > switch (op) { > case BLKPG_ADD_PARTITION: > /* check if partition is aligned to blocksize */ > -- > 2.29.2 > -- Jan Kara SUSE Labs, CR