From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 951F4C5519F for ; Wed, 25 Nov 2020 13:37:44 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 04F2920637 for ; Wed, 25 Nov 2020 13:37:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 04F2920637 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 621886B0073; Wed, 25 Nov 2020 08:37:43 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5AA6B6B0074; Wed, 25 Nov 2020 08:37:43 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 44A916B007B; Wed, 25 Nov 2020 08:37:43 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0210.hostedemail.com [216.40.44.210]) by kanga.kvack.org (Postfix) with ESMTP id 29FC86B0074 for ; Wed, 25 Nov 2020 08:37:43 -0500 (EST) Received: from smtpin14.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id B865F363E for ; Wed, 25 Nov 2020 13:37:42 +0000 (UTC) X-FDA: 77523043164.14.sun86_0b07a5627377 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin14.hostedemail.com (Postfix) with ESMTP id 9740D18229818 for ; Wed, 25 Nov 2020 13:37:42 +0000 (UTC) X-HE-Tag: sun86_0b07a5627377 X-Filterd-Recvd-Size: 2587 Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf08.hostedemail.com (Postfix) with ESMTP for ; Wed, 25 Nov 2020 13:37:40 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 0A70EAC22; Wed, 25 Nov 2020 13:37:40 +0000 (UTC) Received: by quack2.suse.cz (Postfix, from userid 1000) id 658EF1E130F; Wed, 25 Nov 2020 14:37:39 +0100 (CET) Date: Wed, 25 Nov 2020 14:37:39 +0100 From: Jan Kara To: Christoph Hellwig Cc: Jens Axboe , Tejun Heo , Josef Bacik , Konrad Rzeszutek Wilk , Coly Li , Mike Snitzer , Greg Kroah-Hartman , Jan Kara , Johannes Thumshirn , dm-devel@redhat.com, Richard Weinberger , Jan Kara , linux-block@vger.kernel.org, xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org, linux-mtd@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 08/45] loop: do not call set_blocksize Message-ID: <20201125133739.GK16944@quack2.suse.cz> References: <20201124132751.3747337-1-hch@lst.de> <20201124132751.3747337-9-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201124132751.3747337-9-hch@lst.de> User-Agent: Mutt/1.10.1 (2018-07-13) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue 24-11-20 14:27:14, Christoph Hellwig wrote: > set_blocksize is used by file systems to use their preferred buffer cache > block size. Block drivers should not set it. > > Signed-off-by: Christoph Hellwig Looks good to me. You can add: Reviewed-by: Jan Kara Honza > --- > drivers/block/loop.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/block/loop.c b/drivers/block/loop.c > index 9a27d4f1c08aac..b42c728620c9e4 100644 > --- a/drivers/block/loop.c > +++ b/drivers/block/loop.c > @@ -1164,9 +1164,6 @@ static int loop_configure(struct loop_device *lo, fmode_t mode, > size = get_loop_size(lo, file); > loop_set_size(lo, size); > > - set_blocksize(bdev, S_ISBLK(inode->i_mode) ? > - block_size(inode->i_bdev) : PAGE_SIZE); > - > lo->lo_state = Lo_bound; > if (part_shift) > lo->lo_flags |= LO_FLAGS_PARTSCAN; > -- > 2.29.2 > -- Jan Kara SUSE Labs, CR