From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50F78C56202 for ; Wed, 25 Nov 2020 12:46:14 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id B8944206E5 for ; Wed, 25 Nov 2020 12:46:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="KEa6PL7B" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B8944206E5 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id E0DFB6B006E; Wed, 25 Nov 2020 07:46:12 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D97ED6B0078; Wed, 25 Nov 2020 07:46:12 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C5F736B007E; Wed, 25 Nov 2020 07:46:12 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0003.hostedemail.com [216.40.44.3]) by kanga.kvack.org (Postfix) with ESMTP id ABDD96B006E for ; Wed, 25 Nov 2020 07:46:12 -0500 (EST) Received: from smtpin30.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 6CD88180AD811 for ; Wed, 25 Nov 2020 12:46:12 +0000 (UTC) X-FDA: 77522913384.30.event54_5b15e6d27376 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin30.hostedemail.com (Postfix) with ESMTP id 459F0180B3C83 for ; Wed, 25 Nov 2020 12:46:12 +0000 (UTC) X-HE-Tag: event54_5b15e6d27376 X-Filterd-Recvd-Size: 2541 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf18.hostedemail.com (Postfix) with ESMTP for ; Wed, 25 Nov 2020 12:46:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=AOuNFlot/VyZabqwTIsLmcD2t/G7f3vZneAFiQv6T6c=; b=KEa6PL7BAbuR5GDeG0E/m6yG1y DSuILW9uHkBwm9sUaooAAuTk+2TsRtyOo8emEqt8DjHqpThcZYTRwfARucMLlL34aK7h0Hp3ao/+l NrEvthAJDpIc42zLtHmYA0j0h0myOm8yqTVov2qewm4Y71tIIucuqh0nC7UqddOjqUso0YnMo6n4B y4WtGTqHRYpElIHNqv+okvxU2yqD4uVPnGIzefQiFAZgynlBwMnRqGFbuQwpKpu6mmpOWT9u9uPmt 0pFaF4q3tu2NZqTnPRFsnRKaGIrg/OaWlLw3ig+LpGiSjUOVeJXiGiKUJxSzNtKZ7eSwOBpvs9JYQ ZYAYPk1g==; Received: from willy by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1khuBP-0004eu-Ba; Wed, 25 Nov 2020 12:46:03 +0000 Date: Wed, 25 Nov 2020 12:46:03 +0000 From: Matthew Wilcox To: Vlastimil Babka Cc: akpm@linux-foundation.org, davem@davemloft.net, rppt@kernel.org, sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 2/2] mm: Move free_unref_page to mm/internal.h Message-ID: <20201125124603.GL4327@casper.infradead.org> References: <20201125034655.27687-1-willy@infradead.org> <20201125034655.27687-2-willy@infradead.org> <6418f355-ae69-a0bc-3006-b89a4e1cc09c@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6418f355-ae69-a0bc-3006-b89a4e1cc09c@suse.cz> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Nov 25, 2020 at 01:34:04PM +0100, Vlastimil Babka wrote: > On 11/25/20 4:46 AM, Matthew Wilcox (Oracle) wrote: > > Code outside mm/ should not be calling free_unref_page(). Also > > move free_unref_page_list(). > > Good idea. > > > Signed-off-by: Matthew Wilcox (Oracle) > > Acked-by: Vlastimil Babka > > There seems to be some effort to remove "extern" from function declarations > from headers. Do we want to do that, at once, or piecemeal? If the latter, > this is a chance for these functions at least :) I'm generally in favour of those efforts, but since I was just moving the function declarations, and all the code near the destination was using 'extern', I decided not to remove it so as to avoid getting caught up in bikeshedding ...