From: Matthew Wilcox <willy@infradead.org>
To: Vlastimil Babka <vbabka@suse.cz>
Cc: akpm@linux-foundation.org, davem@davemloft.net, rppt@kernel.org,
sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: [PATCH 2/2] mm: Move free_unref_page to mm/internal.h
Date: Wed, 25 Nov 2020 12:46:03 +0000 [thread overview]
Message-ID: <20201125124603.GL4327@casper.infradead.org> (raw)
In-Reply-To: <6418f355-ae69-a0bc-3006-b89a4e1cc09c@suse.cz>
On Wed, Nov 25, 2020 at 01:34:04PM +0100, Vlastimil Babka wrote:
> On 11/25/20 4:46 AM, Matthew Wilcox (Oracle) wrote:
> > Code outside mm/ should not be calling free_unref_page(). Also
> > move free_unref_page_list().
>
> Good idea.
>
> > Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
>
> Acked-by: Vlastimil Babka <vbabka@suse.cz>
>
> There seems to be some effort to remove "extern" from function declarations
> from headers. Do we want to do that, at once, or piecemeal? If the latter,
> this is a chance for these functions at least :)
I'm generally in favour of those efforts, but since I was just moving
the function declarations, and all the code near the destination was
using 'extern', I decided not to remove it so as to avoid getting caught
up in bikeshedding ...
next prev parent reply other threads:[~2020-11-25 12:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-25 3:46 [PATCH 1/2] sparc: Fix handling of page table constructor failure Matthew Wilcox (Oracle)
2020-11-25 3:46 ` [PATCH 2/2] mm: Move free_unref_page to mm/internal.h Matthew Wilcox (Oracle)
2020-11-25 8:43 ` David Hildenbrand
2020-11-25 8:58 ` Mike Rapoport
2020-11-25 12:34 ` Vlastimil Babka
2020-11-25 12:46 ` Matthew Wilcox [this message]
2020-11-25 8:43 ` [PATCH 1/2] sparc: Fix handling of page table constructor failure David Hildenbrand
2020-11-25 12:10 ` Matthew Wilcox
2020-11-25 13:24 ` David Hildenbrand
2020-11-25 8:57 ` Mike Rapoport
2020-11-25 12:30 ` Vlastimil Babka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201125124603.GL4327@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rppt@kernel.org \
--cc=sparclinux@vger.kernel.org \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox