From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1FE3C5519F for ; Wed, 25 Nov 2020 12:31:36 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 2A663206F7 for ; Wed, 25 Nov 2020 12:31:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2A663206F7 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 990766B0071; Wed, 25 Nov 2020 07:31:35 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 919B46B0075; Wed, 25 Nov 2020 07:31:35 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7E1D36B0078; Wed, 25 Nov 2020 07:31:35 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0116.hostedemail.com [216.40.44.116]) by kanga.kvack.org (Postfix) with ESMTP id 65BB56B0071 for ; Wed, 25 Nov 2020 07:31:35 -0500 (EST) Received: from smtpin09.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 350751EE6 for ; Wed, 25 Nov 2020 12:31:35 +0000 (UTC) X-FDA: 77522876550.09.coat63_3e1756527376 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin09.hostedemail.com (Postfix) with ESMTP id 1850A180AD815 for ; Wed, 25 Nov 2020 12:31:35 +0000 (UTC) X-HE-Tag: coat63_3e1756527376 X-Filterd-Recvd-Size: 4265 Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf24.hostedemail.com (Postfix) with ESMTP for ; Wed, 25 Nov 2020 12:31:34 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 6A34EAF0E; Wed, 25 Nov 2020 12:31:33 +0000 (UTC) Received: by quack2.suse.cz (Postfix, from userid 1000) id 3DD711E130F; Wed, 25 Nov 2020 13:31:33 +0100 (CET) Date: Wed, 25 Nov 2020 13:31:33 +0100 From: Jan Kara To: Christoph Hellwig Cc: Jens Axboe , Tejun Heo , Josef Bacik , Konrad Rzeszutek Wilk , Coly Li , Mike Snitzer , Greg Kroah-Hartman , Jan Kara , Johannes Thumshirn , dm-devel@redhat.com, Richard Weinberger , Jan Kara , linux-block@vger.kernel.org, xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org, linux-mtd@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 05/45] mtip32xx: remove the call to fsync_bdev on removal Message-ID: <20201125123133.GI16944@quack2.suse.cz> References: <20201124132751.3747337-1-hch@lst.de> <20201124132751.3747337-6-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201124132751.3747337-6-hch@lst.de> User-Agent: Mutt/1.10.1 (2018-07-13) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue 24-11-20 14:27:11, Christoph Hellwig wrote: > del_gendisk already calls fsync_bdev for every partition, no need > to do this twice. > > Signed-off-by: Christoph Hellwig Makes sense to me. You can add: Reviewed-by: Jan Kara Honza > --- > drivers/block/mtip32xx/mtip32xx.c | 15 --------------- > drivers/block/mtip32xx/mtip32xx.h | 2 -- > 2 files changed, 17 deletions(-) > > diff --git a/drivers/block/mtip32xx/mtip32xx.c b/drivers/block/mtip32xx/mtip32xx.c > index 153e2cdecb4d40..53ac59d19ae530 100644 > --- a/drivers/block/mtip32xx/mtip32xx.c > +++ b/drivers/block/mtip32xx/mtip32xx.c > @@ -3687,7 +3687,6 @@ static int mtip_block_initialize(struct driver_data *dd) > /* Enable the block device and add it to /dev */ > device_add_disk(&dd->pdev->dev, dd->disk, NULL); > > - dd->bdev = bdget_disk(dd->disk, 0); > /* > * Now that the disk is active, initialize any sysfs attributes > * managed by the protocol layer. > @@ -3721,9 +3720,6 @@ static int mtip_block_initialize(struct driver_data *dd) > return rv; > > kthread_run_error: > - bdput(dd->bdev); > - dd->bdev = NULL; > - > /* Delete our gendisk. This also removes the device from /dev */ > del_gendisk(dd->disk); > > @@ -3804,14 +3800,6 @@ static int mtip_block_remove(struct driver_data *dd) > blk_mq_tagset_busy_iter(&dd->tags, mtip_no_dev_cleanup, dd); > blk_mq_unquiesce_queue(dd->queue); > > - /* > - * Delete our gendisk structure. This also removes the device > - * from /dev > - */ > - if (dd->bdev) { > - bdput(dd->bdev); > - dd->bdev = NULL; > - } > if (dd->disk) { > if (test_bit(MTIP_DDF_INIT_DONE_BIT, &dd->dd_flag)) > del_gendisk(dd->disk); > @@ -4206,9 +4194,6 @@ static void mtip_pci_remove(struct pci_dev *pdev) > } while (atomic_read(&dd->irq_workers_active) != 0 && > time_before(jiffies, to)); > > - if (!dd->sr) > - fsync_bdev(dd->bdev); > - > if (atomic_read(&dd->irq_workers_active) != 0) { > dev_warn(&dd->pdev->dev, > "Completion workers still active!\n"); > diff --git a/drivers/block/mtip32xx/mtip32xx.h b/drivers/block/mtip32xx/mtip32xx.h > index e22a7f0523bf30..88f4206310e4c8 100644 > --- a/drivers/block/mtip32xx/mtip32xx.h > +++ b/drivers/block/mtip32xx/mtip32xx.h > @@ -463,8 +463,6 @@ struct driver_data { > > int isr_binding; > > - struct block_device *bdev; > - > struct list_head online_list; /* linkage for online list */ > > struct list_head remove_list; /* linkage for removing list */ > -- > 2.29.2 > -- Jan Kara SUSE Labs, CR