From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2F4BC5519F for ; Wed, 25 Nov 2020 08:58:27 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 2D72B206F7 for ; Wed, 25 Nov 2020 08:58:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="K/jNOA/1" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2D72B206F7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id AD30A6B0072; Wed, 25 Nov 2020 03:58:26 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A83AD6B0073; Wed, 25 Nov 2020 03:58:26 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9BFAB6B0074; Wed, 25 Nov 2020 03:58:26 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0182.hostedemail.com [216.40.44.182]) by kanga.kvack.org (Postfix) with ESMTP id 874626B0072 for ; Wed, 25 Nov 2020 03:58:26 -0500 (EST) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 4AE2345BC for ; Wed, 25 Nov 2020 08:58:26 +0000 (UTC) X-FDA: 77522339412.19.skirt94_2607ea827375 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin19.hostedemail.com (Postfix) with ESMTP id 2F0BE1AD1B7 for ; Wed, 25 Nov 2020 08:58:26 +0000 (UTC) X-HE-Tag: skirt94_2607ea827375 X-Filterd-Recvd-Size: 3139 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf01.hostedemail.com (Postfix) with ESMTP for ; Wed, 25 Nov 2020 08:58:25 +0000 (UTC) Received: from kernel.org (unknown [77.125.7.142]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6735F206F7; Wed, 25 Nov 2020 08:58:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1606294704; bh=8Q4bTxIUuJKKptiq+uTMfjcIsOJnS/D6f/eeKCwPg8E=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=K/jNOA/1Kqu8E37w9KQd65Aq1/1d32e7vY1YyX/WKrzDHTaU7uINHclRnz7FZw+XE 37d1eZORSIDtx1GQmaUzDCweunoQum5x66x9ciwmg3yQ3tyiYW1h8gTYOlWvjgVIDu l+t3Ns5bkM402Ax/r66GOBu3pB8TDMmZCwgg5+hI= Date: Wed, 25 Nov 2020 10:58:18 +0200 From: Mike Rapoport To: "Matthew Wilcox (Oracle)" Cc: akpm@linux-foundation.org, davem@davemloft.net, sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 2/2] mm: Move free_unref_page to mm/internal.h Message-ID: <20201125085818.GM8537@kernel.org> References: <20201125034655.27687-1-willy@infradead.org> <20201125034655.27687-2-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201125034655.27687-2-willy@infradead.org> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Nov 25, 2020 at 03:46:55AM +0000, Matthew Wilcox (Oracle) wrote: > Code outside mm/ should not be calling free_unref_page(). Also > move free_unref_page_list(). > > Signed-off-by: Matthew Wilcox (Oracle) Reviewed-by: Mike Rapoport > --- > include/linux/gfp.h | 2 -- > mm/internal.h | 3 +++ > 2 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/include/linux/gfp.h b/include/linux/gfp.h > index c603237e006c..6e479e9c48ce 100644 > --- a/include/linux/gfp.h > +++ b/include/linux/gfp.h > @@ -580,8 +580,6 @@ void * __meminit alloc_pages_exact_nid(int nid, size_t size, gfp_t gfp_mask); > > extern void __free_pages(struct page *page, unsigned int order); > extern void free_pages(unsigned long addr, unsigned int order); > -extern void free_unref_page(struct page *page); > -extern void free_unref_page_list(struct list_head *list); > > struct page_frag_cache; > extern void __page_frag_cache_drain(struct page *page, unsigned int count); > diff --git a/mm/internal.h b/mm/internal.h > index 75ae680d0a2c..5864815947fe 100644 > --- a/mm/internal.h > +++ b/mm/internal.h > @@ -201,6 +201,9 @@ extern void post_alloc_hook(struct page *page, unsigned int order, > gfp_t gfp_flags); > extern int user_min_free_kbytes; > > +extern void free_unref_page(struct page *page); > +extern void free_unref_page_list(struct list_head *list); > + > extern void zone_pcp_update(struct zone *zone); > extern void zone_pcp_reset(struct zone *zone); > extern void zone_pcp_disable(struct zone *zone); > -- > 2.29.2 > -- Sincerely yours, Mike.