From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 130CCC5519F for ; Wed, 25 Nov 2020 04:12:59 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 4221F20789 for ; Wed, 25 Nov 2020 04:12:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="H7u6ygp4" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4221F20789 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 7778A6B006E; Tue, 24 Nov 2020 23:12:57 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 727FD6B0070; Tue, 24 Nov 2020 23:12:57 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5EE7E6B0071; Tue, 24 Nov 2020 23:12:57 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0059.hostedemail.com [216.40.44.59]) by kanga.kvack.org (Postfix) with ESMTP id 44D526B006E for ; Tue, 24 Nov 2020 23:12:57 -0500 (EST) Received: from smtpin17.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 0DFAC181AC537 for ; Wed, 25 Nov 2020 04:12:57 +0000 (UTC) X-FDA: 77521619994.17.bulb57_2c1755527373 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin17.hostedemail.com (Postfix) with ESMTP id E464C180D0181 for ; Wed, 25 Nov 2020 04:12:56 +0000 (UTC) X-HE-Tag: bulb57_2c1755527373 X-Filterd-Recvd-Size: 3781 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf36.hostedemail.com (Postfix) with ESMTP for ; Wed, 25 Nov 2020 04:12:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Type:MIME-Version:Message-ID: Subject:To:From:Date:Sender:Reply-To:Cc:Content-Transfer-Encoding:Content-ID: Content-Description:In-Reply-To:References; bh=JFm7o2EHJngOTe0KLHdQyj5zDm6BfrZQJBZ1oac3JHg=; b=H7u6ygp4kxWlZpBd7RRlo3EsjM 4po1YUSk1fmXx7dyc/0S2Mz44XtSuBGPXuIYRRPkb2uGFIZm2jXJ3UXdXMjj7rfOIborK9hhQ69em Zm7J7ZPNQKnI48fyUeaQaoXXaq0podRnVe7U8FQPhkLWRF+iorESDi3mQ2z+SeymN99WTO8bXmDn2 TRkKnd3LTxq2i0GttZjsGVRDaDOsZzinn7piGlke3tLIy1o95jQ4m00ENwcKrTZtwdvxSuOjxuOIp iL5S/uxfsu3CvGPyQ6cnnhTa5MQUCSGm8wUzpna/cuYf7eRvVkJApPDf9GUYKaCcFOXumADxvfpx5 t99DfvVg==; Received: from willy by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1khmAo-0008W3-BO for linux-mm@kvack.org; Wed, 25 Nov 2020 04:12:54 +0000 Date: Wed, 25 Nov 2020 04:12:54 +0000 From: Matthew Wilcox To: linux-mm@kvack.org Subject: warning in mem_cgroup_lruvec() Message-ID: <20201125041254.GI4327@casper.infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Running xfstests against next-20201124 + the THP patchset https://git.infradead.org/users/willy/pagecache.git/shortlog/refs/heads/next 4005 ------------[ cut here ]------------ 4006 WARNING: CPU: 2 PID: 45 at include/linux/memcontrol.h:621 do_try_to_free_pages+0x40b/0x460 4006 Modules linked in: crc_t10dif crct10dif_generic crct10dif_common [last unloaded: scsi_debug] 4006 CPU: 2 PID: 45 Comm: khugepaged Kdump: loaded Tainted: G W 5.10.0-rc5-next-20201124-00062-gfedc7682a240 #990 4006 Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.14.0-1 04/01/2014 4006 RIP: 0010:do_try_to_free_pages+0x40b/0x460 4006 Code: 00 00 48 89 c3 e9 31 ff ff ff 48 3b 89 e8 20 00 00 48 8d 91 60 20 00 00 0f 84 f0 fe ff ff 48 89 8a 88 00 00 00 e9 e4 fe ff ff <0f> 0b 48 8b 15 ec 90 05 01 e9 5b fe ff ff 0f 0b 0f b6 5d cb 83 e0 4006 RSP: 0018:ffff888003053b50 EFLAGS: 00010246 4006 RAX: ffffffff821878c0 RBX: ffffffff82189800 RCX: 0000000000000004 4006 RDX: 0000000000000000 RSI: ffffffff82187f00 RDI: ffffffff82189820 4006 RBP: ffff888003053b90 R08: 00000000000003e3 R09: 0000000000004d64 4006 R10: 0000000000000009 R11: 0000000000000000 R12: 0000000000000000 4006 R13: ffffffff821878c0 R14: 0000000000000000 R15: ffff888003053ba0 4006 FS: 0000000000000000(0000) GS:ffff88807d880000(0000) knlGS:0000000000000000 4006 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 4006 CR2: 000055e23c731368 CR3: 0000000053cfe002 CR4: 0000000000370ea0 4006 Call Trace: 4006 try_to_free_pages+0xdc/0x1b0 4006 __alloc_pages_slowpath.constprop.0+0x2d2/0xd00 4006 __alloc_pages_nodemask+0x249/0x290 4006 khugepaged+0x2cd/0x28e0 4006 ? add_wait_queue_exclusive+0x80/0x80 4006 kthread+0x135/0x150 4006 ? collapse_pte_mapped_thp+0x4a0/0x4a0 4006 ? kthread_create_worker_on_cpu+0x40/0x40 4006 ret_from_fork+0x1f/0x30 4006 ---[ end trace 4da165ba10d2d88a ]--- I see a few of these with different callchains. eg: 3749 RIP: 0010:prepare_kswapd_sleep+0x66/0xc0 3749 kswapd+0xe2/0x350 3749 ? add_wait_queue_exclusive+0x80/0x80 3749 kthread+0x135/0x150 3749 ? balance_pgdat+0x600/0x600 3749 ? kthread_create_worker_on_cpu+0x40/0x40 3749 ret_from_fork+0x1f/0x30 3749 RIP: 0010:balance_pgdat+0x46f/0x600 3749 RIP: 0010:workingset_eviction+0x184/0x250 but they're all: VM_WARN_ON_ONCE(!memcg); which is clearly not actually warning once at all. not even once per inlined site.