From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C1C8C5519F for ; Wed, 25 Nov 2020 03:47:10 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id EAD3A20663 for ; Wed, 25 Nov 2020 03:47:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="ALPcWGlR" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EAD3A20663 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 0E49F6B006E; Tue, 24 Nov 2020 22:47:08 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 06F126B0070; Tue, 24 Nov 2020 22:47:07 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E7A166B0071; Tue, 24 Nov 2020 22:47:07 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0066.hostedemail.com [216.40.44.66]) by kanga.kvack.org (Postfix) with ESMTP id CD5876B006E for ; Tue, 24 Nov 2020 22:47:07 -0500 (EST) Received: from smtpin16.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 944F03635 for ; Wed, 25 Nov 2020 03:47:07 +0000 (UTC) X-FDA: 77521554894.16.drink62_2d01a2c27373 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin16.hostedemail.com (Postfix) with ESMTP id 72B21100E690B for ; Wed, 25 Nov 2020 03:47:07 +0000 (UTC) X-HE-Tag: drink62_2d01a2c27373 X-Filterd-Recvd-Size: 2388 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf16.hostedemail.com (Postfix) with ESMTP for ; Wed, 25 Nov 2020 03:47:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:MIME-Version: Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:In-Reply-To:References; bh=J1UiKPrr/8+P5aZ4gZtZajuWCSG9DfbwTn4Phofujgs=; b=ALPcWGlR8P/1FykZVFRmz3vcFz nBGB0hnWOZWyV07ZYluhFOsA5/vXhi+JDpiY3ZX3gi15gQU0bRWK8tfZUBSElsdRJE0iHLa28cV6D yERLNmcBTFIplJT/NUd8+NrZb/IyRMpkey4AiBUmES0zpDwkLfj1YyxmNRx+dw55S8WWo7rDMnwmy YkHt2wToGxA2Bep7FEEqsNgxgbs3I1pl/Ei2xVBdUVYwakkTsCbrudfvYRCWDGR8dl6fiE4uTFafX b2wt1U1tjpYFAjfW5MbMXhz9PVsFs6StauQ3r14jkgZiz9HlXVznT030xmxafxJM5D7fpNMN0SH5S 1R4PTkgQ==; Received: from willy by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1khllg-0007E4-Mm; Wed, 25 Nov 2020 03:46:57 +0000 From: "Matthew Wilcox (Oracle)" To: akpm@linux-foundation.org Cc: "Matthew Wilcox (Oracle)" , davem@davemloft.net, rppt@kernel.org, sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: [PATCH 1/2] sparc: Fix handling of page table constructor failure Date: Wed, 25 Nov 2020 03:46:54 +0000 Message-Id: <20201125034655.27687-1-willy@infradead.org> X-Mailer: git-send-email 2.21.3 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: The page has just been allocated, so its refcount is 1. free_unref_page(= ) is for use on pages which have a zero refcount. Use __free_page() like the other implementations of pte_alloc_one(). Fixes: 1ae9ae5f7df7 ("sparc: handle pgtable_page_ctor() fail") Signed-off-by: Matthew Wilcox (Oracle) --- arch/sparc/mm/init_64.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/sparc/mm/init_64.c b/arch/sparc/mm/init_64.c index 96edf64d4fb3..182bb7bdaa0a 100644 --- a/arch/sparc/mm/init_64.c +++ b/arch/sparc/mm/init_64.c @@ -2894,7 +2894,7 @@ pgtable_t pte_alloc_one(struct mm_struct *mm) if (!page) return NULL; if (!pgtable_pte_page_ctor(page)) { - free_unref_page(page); + __free_page(page); return NULL; } return (pte_t *) page_address(page); --=20 2.29.2