From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BBD34C63697 for ; Mon, 23 Nov 2020 16:48:20 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 2ED86208DB for ; Mon, 23 Nov 2020 16:48:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="wJKB6HEh" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2ED86208DB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 25D026B00BA; Mon, 23 Nov 2020 11:48:19 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1E7AF6B00BB; Mon, 23 Nov 2020 11:48:19 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0ACA36B00BD; Mon, 23 Nov 2020 11:48:19 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0130.hostedemail.com [216.40.44.130]) by kanga.kvack.org (Postfix) with ESMTP id C761C6B00BA for ; Mon, 23 Nov 2020 11:48:18 -0500 (EST) Received: from smtpin04.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 707B31EE6 for ; Mon, 23 Nov 2020 16:48:18 +0000 (UTC) X-FDA: 77516265876.04.plot67_2e1583627367 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin04.hostedemail.com (Postfix) with ESMTP id 4DF38800590B for ; Mon, 23 Nov 2020 16:48:18 +0000 (UTC) X-HE-Tag: plot67_2e1583627367 X-Filterd-Recvd-Size: 2359 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf34.hostedemail.com (Postfix) with ESMTP for ; Mon, 23 Nov 2020 16:48:17 +0000 (UTC) Received: from willie-the-truck (236.31.169.217.in-addr.arpa [217.169.31.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id F3A3520717; Mon, 23 Nov 2020 16:48:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1606150096; bh=kA8c3OfIwdiQgZa+jhGYvbIcKRQ4uxazZENPSYYhqxs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=wJKB6HEhoJU2IsKoFXLnIZYVF5vYv4ScRMhB6CR9MZ9Ny/zp9CPtl+iUna0DZETg8 Vn9lHtG71fup6t0eEEnO/ZkDT6DWvKF6yOFCIpwomLAe+u7AaqhU1tMHK2/5NYJ3pJ YorfxbjuAvXdBFC5FJ1vcJUgQCRxFcItrPvqa71E= Date: Mon, 23 Nov 2020 16:48:11 +0000 From: Will Deacon To: Linus Torvalds Cc: Linux Kernel Mailing List , Android Kernel Team , Catalin Marinas , Yu Zhao , Minchan Kim , Peter Zijlstra , Anshuman Khandual , Linux-MM , Linux ARM Subject: Re: [PATCH 5/6] tlb: mmu_gather: Introduce tlb_gather_mmu_fullmm() Message-ID: <20201123164811.GA11494@willie-the-truck> References: <20201120143557.6715-1-will@kernel.org> <20201120143557.6715-6-will@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000003, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Nov 20, 2020 at 09:31:09AM -0800, Linus Torvalds wrote: > Oh - wait. > > Not ack. > > Not because this is wrong, but because I think you should remove the > start/end arguments here too. > > The _only_ thing they were used for was that "fullmm" flag, afaik. So > now they no longer make sense. > > Hmm? Oh nice, well spotted. I'll drop them for v2. Cheers, Will