From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.8 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1, USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77337C63777 for ; Fri, 20 Nov 2020 14:19:39 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E5FF32222A for ; Fri, 20 Nov 2020 14:19:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="f6nWmbpF" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E5FF32222A Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 3ADD76B005D; Fri, 20 Nov 2020 09:19:38 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 35D576B006C; Fri, 20 Nov 2020 09:19:38 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1D8736B006E; Fri, 20 Nov 2020 09:19:38 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0253.hostedemail.com [216.40.44.253]) by kanga.kvack.org (Postfix) with ESMTP id D32116B005D for ; Fri, 20 Nov 2020 09:19:37 -0500 (EST) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 33866180AD80F for ; Fri, 20 Nov 2020 14:19:37 +0000 (UTC) X-FDA: 77505004794.06.note12_12036b22734c Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin06.hostedemail.com (Postfix) with ESMTP id 04BA210044A20 for ; Fri, 20 Nov 2020 14:19:36 +0000 (UTC) X-HE-Tag: note12_12036b22734c X-Filterd-Recvd-Size: 7106 Received: from mail-wr1-f65.google.com (mail-wr1-f65.google.com [209.85.221.65]) by imf26.hostedemail.com (Postfix) with ESMTP for ; Fri, 20 Nov 2020 14:19:36 +0000 (UTC) Received: by mail-wr1-f65.google.com with SMTP id 23so10176651wrc.8 for ; Fri, 20 Nov 2020 06:19:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=xxByCDasYrQl9/cr/4ND1bYYvzVsnbPeWW4lsY9uHSo=; b=f6nWmbpFrO6nNmXfCRHQt8BwD43B8eTaHj2dsxELld+2WXCRI2+VDo3F0lzCLEQWHk tDs866iLMScCTCkeWLDb70rRPpn/JRtpHl3PVBFefHJNIyvAmBL05Wce/vAhpxgOigt5 cxzD5YGnhuWhWJ/VNhj6C47fk4uFbHe+MpKotnjdf1PScSkZOKjGBYA8LKsqZ+FVvpYw lu6GO2a/O0RvIgninfUlzoVKijGErLVmTWcd50Rakq+JefcURGDLFcmTw9+c6EuxYVIL Z6PklLpGgVj501tENaGi31Mj0Ci+wim7UHRnRgIFnUkx+gmL6olAStZJV9+GUzPuK9Ez Iz1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=xxByCDasYrQl9/cr/4ND1bYYvzVsnbPeWW4lsY9uHSo=; b=V7WuYb6FdsYQmaJjYIzwe/SwfCHAIzbukji1A5X1tnNlGCA1+YNHJ6gRYJFldbLlEW 1lYMLearvMzszhf56NQa3Kuea7y8fxrZwZp6/d9q0VI+6ZsD7N9jgr+nVs86qUt2+pS7 1xqoA+kQhyTHl5BamM4QDszuenf5w+/DeXNTZDCXPZyxs50b3kpFMtV8Q8W7kqSrjzND yj45joMvbOhYj/NCT4Z+uqPERT6doSaBEWloFRfdDQsU1rAaiQ2R1/EjRDbRjmhj9lio 9cc6e5BE8uMgRwaPDgchEZxeXzD3AoW0lEkGleUH8T2sv5HYNR2UT1+6ULS2BE23yuWr e/Nw== X-Gm-Message-State: AOAM531xwUNjPMftnXKj9nUjrSzCYBPvoUYnNaeSt2hsNLSeYbi/y0zQ ABOyJMyVAp9PTmVCh9L8Xd//Yw== X-Google-Smtp-Source: ABdhPJz4v/XxzYmKZBv+ZBNMQC9A3BdP10+FcI7X+d6vI9r6IciwcBqs4061FjYyjj1dIoLy7knpXw== X-Received: by 2002:adf:e74d:: with SMTP id c13mr17088093wrn.277.1605881974917; Fri, 20 Nov 2020 06:19:34 -0800 (PST) Received: from elver.google.com ([2a00:79e0:15:13:f693:9fff:fef4:2449]) by smtp.gmail.com with ESMTPSA id l13sm5307917wrm.24.2020.11.20.06.19.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Nov 2020 06:19:33 -0800 (PST) Date: Fri, 20 Nov 2020 15:19:28 +0100 From: Marco Elver To: "Paul E. McKenney" Cc: Steven Rostedt , Anders Roxell , Andrew Morton , Alexander Potapenko , Dmitry Vyukov , Jann Horn , Mark Rutland , Linux Kernel Mailing List , Linux-MM , kasan-dev , rcu@vger.kernel.org, Peter Zijlstra , Tejun Heo , Lai Jiangshan , linux-arm-kernel@lists.infradead.org Subject: Re: linux-next: stall warnings and deadlock on Arm64 (was: [PATCH] kfence: Avoid stalling...) Message-ID: <20201120141928.GB3120165@elver.google.com> References: <20201117105236.GA1964407@elver.google.com> <20201117182915.GM1437@paulmck-ThinkPad-P72> <20201118225621.GA1770130@elver.google.com> <20201118233841.GS1437@paulmck-ThinkPad-P72> <20201119125357.GA2084963@elver.google.com> <20201119151409.GU1437@paulmck-ThinkPad-P72> <20201119170259.GA2134472@elver.google.com> <20201119184854.GY1437@paulmck-ThinkPad-P72> <20201119193819.GA2601289@elver.google.com> <20201119213512.GB1437@paulmck-ThinkPad-P72> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201119213512.GB1437@paulmck-ThinkPad-P72> User-Agent: Mutt/1.14.6 (2020-07-11) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Nov 19, 2020 at 01:35PM -0800, Paul E. McKenney wrote: > On Thu, Nov 19, 2020 at 08:38:19PM +0100, Marco Elver wrote: > > On Thu, Nov 19, 2020 at 10:48AM -0800, Paul E. McKenney wrote: > > > On Thu, Nov 19, 2020 at 06:02:59PM +0100, Marco Elver wrote: > > [ . . . ] > > > > > I can try bisection again, or reverting some commits that might be > > > > suspicious? But we'd need some selection of suspicious commits. > > > > > > The report claims that one of the rcu_node ->lock fields is held > > > with interrupts enabled, which would indeed be bad. Except that all > > > of the stack traces that it shows have these locks held within the > > > scheduling-clock interrupt handler. Now with the "rcu: Don't invoke > > > try_invoke_on_locked_down_task() with irqs disabled" but without the > > > "sched/core: Allow try_invoke_on_locked_down_task() with irqs disabled" > > > commit, I understand why. With both, I don't see how this happens. > > > > I'm at a loss, but happy to keep bisecting and trying patches. I'm also > > considering: > > > > Is it the compiler? Probably not, I tried 2 versions of GCC. > > > > Can we trust lockdep to precisely know IRQ state? I know there's > > been some recent work around this, but hopefully we're not > > affected here? > > > > Is QEMU buggy? > > > > > At this point, I am reduced to adding lockdep_assert_irqs_disabled() > > > calls at various points in that code, as shown in the patch below. > > > > > > At this point, I would guess that your first priority would be the > > > initial bug rather than this following issue, but you never know, this > > > might well help diagnose the initial bug. > > > > I don't mind either way. I'm worried deadlocking the whole system might > > be worse. > > Here is another set of lockdep_assert_irqs_disabled() calls on the > off-chance that they actually find something. > > Thanx, Paul > > ------------------------------------------------------------------------ > > commit bcca5277df3f24db15e15ccc8b05ecf346d05169 > Author: Paul E. McKenney > Date: Thu Nov 19 13:30:33 2020 -0800 > > rcu: Add lockdep_assert_irqs_disabled() to raw_spin_unlock_rcu_node() macros None of those triggered either. I found that disabling ftrace for some of kernel/rcu (see below) solved the stalls (and any mention of deadlocks as a side-effect I assume), resulting in successful boot. Does that provide any additional clues? I tried to narrow it down to 1-2 files, but that doesn't seem to work. Thanks, -- Marco ------ >8 ------ diff --git a/kernel/rcu/Makefile b/kernel/rcu/Makefile index 0cfb009a99b9..678b4b094f94 100644 --- a/kernel/rcu/Makefile +++ b/kernel/rcu/Makefile @@ -3,6 +3,13 @@ # and is generally not a function of system call inputs. KCOV_INSTRUMENT := n +ifdef CONFIG_FUNCTION_TRACER +CFLAGS_REMOVE_update.o = $(CC_FLAGS_FTRACE) +CFLAGS_REMOVE_sync.o = $(CC_FLAGS_FTRACE) +CFLAGS_REMOVE_srcutree.o = $(CC_FLAGS_FTRACE) +CFLAGS_REMOVE_tree.o = $(CC_FLAGS_FTRACE) +endif + ifeq ($(CONFIG_KCSAN),y) KBUILD_CFLAGS += -g -fno-omit-frame-pointer endif