Re: [linux-next:master 4170/7280] pwm-brcmstb.c:undefined reference to `devm_platform_ioremap_resource'

["Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>]

[-- Attachment #1: Type: text/plain, Size: 2486 bytes --]

On Fri, Nov 20, 2020 at 08:33:46PM +0800, kernel test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> head:   95065cb54210eba86bed10cb2118041524d54573
> commit: 0e74dcd8333d794fdbc4bef69d17431404a01a6f [4170/7280] pwm: brcmstb: Convert to devm_platform_ioremap_resource()
> config: s390-randconfig-r034-20201120 (attached as .config)
> compiler: s390-linux-gcc (GCC) 9.3.0
> reproduce (this is a W=1 build):
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=0e74dcd8333d794fdbc4bef69d17431404a01a6f
>         git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
>         git fetch --no-tags linux-next master
>         git checkout 0e74dcd8333d794fdbc4bef69d17431404a01a6f
>         # save the attached .config to linux build tree
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=s390 
> 
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
> 
> Note: the linux-next/master HEAD 95065cb54210eba86bed10cb2118041524d54573 builds fine.
>       It may have been fixed somewhere.

This is indeed the case,

	ffc32cb0e1f6 pwm: Fix dependencies on HAS_IOMEM

is supposed to fix this.

>    s390-linux-ld: drivers/pwm/pwm-brcmstb.o: in function `brcmstb_pwm_probe':
> >> pwm-brcmstb.c:(.text+0x466): undefined reference to `devm_platform_ioremap_resource'

I expect that before the blamed commit (0e74dcd8333d ("pwm: brcmstb:
Convert to devm_platform_ioremap_resource()")) the driver failed with:

	pwm-brcmstb.c:(.text+0xfoo): undefined reference to `devm_ioremap_resource'

so it probably makes little sense to ensure the commit "pwm: Fix
dependencies on HAS_IOMEM" comes before "pwm: brcmstb: Convert to
devm_platform_ioremap_resource()" (and the other similar conversions).
The only upside of rewriting the pwm-next tree would be that
autobuilders wouldn't stumble because the error changed. Hardly good
enough a reason, still more as the dependency is missing for quite some
time already I guess.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]