From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E45AAC5519F for ; Wed, 18 Nov 2020 16:24:54 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id CB7DE24738 for ; Wed, 18 Nov 2020 16:24:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CB7DE24738 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id EF19A6B007E; Wed, 18 Nov 2020 11:24:52 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EA1666B0082; Wed, 18 Nov 2020 11:24:52 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DB8956B0083; Wed, 18 Nov 2020 11:24:52 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0131.hostedemail.com [216.40.44.131]) by kanga.kvack.org (Postfix) with ESMTP id AE5DE6B007E for ; Wed, 18 Nov 2020 11:24:52 -0500 (EST) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 49FF9824999B for ; Wed, 18 Nov 2020 16:24:52 +0000 (UTC) X-FDA: 77498062824.19.leaf39_1513db82733b Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin19.hostedemail.com (Postfix) with ESMTP id 2181D1AD1B9 for ; Wed, 18 Nov 2020 16:24:52 +0000 (UTC) X-HE-Tag: leaf39_1513db82733b X-Filterd-Recvd-Size: 2013 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf23.hostedemail.com (Postfix) with ESMTP for ; Wed, 18 Nov 2020 16:24:51 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id E61A068B05; Wed, 18 Nov 2020 17:24:48 +0100 (CET) Date: Wed, 18 Nov 2020 17:24:47 +0100 From: Christoph Hellwig To: Coly Li Cc: Christoph Hellwig , Jens Axboe , Tejun Heo , Josef Bacik , Konrad Rzeszutek Wilk , Mike Snitzer , dm-devel@redhat.com, Richard Weinberger , Jan Kara , linux-block@vger.kernel.org, xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org, linux-mtd@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 19/20] bcache: remove a superflous lookup_bdev all Message-ID: <20201118162447.GB16753@lst.de> References: <20201118084800.2339180-1-hch@lst.de> <20201118084800.2339180-20-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Nov 18, 2020 at 04:54:51PM +0800, Coly Li wrote: > On 11/18/20 4:47 PM, Christoph Hellwig wrote: > > Don't bother to call lookup_bdev for just a slightly different error > > message without any functional change. > > > > Signed-off-by: Christoph Hellwig ist > > Hi Christoph, > > NACK. This removing error message is frequently triggered and observed, > and distinct a busy device and an already registered device is important > (the first one is critical error and second one is not). > > Remove such error message will be a functional regression. I can probably keep it, the amount of code to prettiefy an error message seems excessive, though.