From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9BC39C2D0E4 for ; Tue, 17 Nov 2020 21:10:08 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C37B424199 for ; Tue, 17 Nov 2020 21:10:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="fYMULdu+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C37B424199 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 054506B0036; Tue, 17 Nov 2020 16:10:07 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 005596B005C; Tue, 17 Nov 2020 16:10:06 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D9B5C6B0068; Tue, 17 Nov 2020 16:10:06 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0039.hostedemail.com [216.40.44.39]) by kanga.kvack.org (Postfix) with ESMTP id A9FA36B0036 for ; Tue, 17 Nov 2020 16:10:06 -0500 (EST) Received: from smtpin05.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 5A6AB1EF1 for ; Tue, 17 Nov 2020 21:10:06 +0000 (UTC) X-FDA: 77495152812.05.shock71_5412b5927334 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin05.hostedemail.com (Postfix) with ESMTP id 42567180318EB for ; Tue, 17 Nov 2020 21:10:06 +0000 (UTC) X-HE-Tag: shock71_5412b5927334 X-Filterd-Recvd-Size: 2526 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf20.hostedemail.com (Postfix) with ESMTP for ; Tue, 17 Nov 2020 21:10:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Ri91W8ocs5j1kEkJ2qPP/wzX2scE1yNyfb4YmTpxrH4=; b=fYMULdu+st/sND/Y5nBpk1vwEM ZQqyFcbp0+JR5ZHTbEAnEyhsAspAv47XXzbUVytwqPrGuBFzZ8bwuWkg1WO89PU4uFmLgdz4XwFga AOJbkcINoGPsc9xC6lZpMV2dUVuivhAnGHstzSLmu8zPC0tp4fiNgagOr+eKyGKxM1FUZx3PaG5Sv p9TkaJpnsVGA2nyBr10k911eb9a9OoieU95yaxy7ZO6tgiTsP9g8uOMJnXDnkQrWEHqs3wZsiihkf E2RvJ200E479oTK+PrsvX407onFO8I0qmu4VInGHtJyt1cmi2Se0JPJ469qJTwHyTbCc6TC2pJBhG SSixLeNw==; Received: from willy by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1kf8Ej-0003Zr-8e; Tue, 17 Nov 2020 21:10:01 +0000 Date: Tue, 17 Nov 2020 21:10:01 +0000 From: Matthew Wilcox To: Zi Yan Cc: linux-mm@kvack.org, "Kirill A . Shutemov" , Roman Gushchin , Andrew Morton , linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, Yang Shi , Michal Hocko , John Hubbard , Ralph Campbell , David Nellans Subject: Re: [RFC PATCH 3/6] mm: page_owner: add support for splitting to any order in split page_owner. Message-ID: <20201117211001.GY29991@casper.infradead.org> References: <20201111204008.21332-1-zi.yan@sent.com> <20201111204008.21332-4-zi.yan@sent.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201111204008.21332-4-zi.yan@sent.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Nov 11, 2020 at 03:40:05PM -0500, Zi Yan wrote: > - for (i = 0; i < nr; i++) { > + for (i = 0; i < nr; i += (1 << new_order)) { > page_owner = get_page_owner(page_ext); > - page_owner->order = 0; > + page_owner->order = new_order; > page_ext = page_ext_next(page_ext); > } This doesn't do what you're hoping it will. It's going to set ->order to new_order for the first N pages instead of every 1/N pages. You'll need to do something like page_ext = lookup_page_ext(page + i); or add a new page_ext_add(page_ext, 1 << new_order);