From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1D3BC2D0E4 for ; Tue, 17 Nov 2020 17:58:06 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 2941A2222A for ; Tue, 17 Nov 2020 17:58:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b="XplTe1UR" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2941A2222A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=163.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 5E87B6B005D; Tue, 17 Nov 2020 12:58:05 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 594A66B006E; Tue, 17 Nov 2020 12:58:05 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4837F6B0073; Tue, 17 Nov 2020 12:58:05 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0231.hostedemail.com [216.40.44.231]) by kanga.kvack.org (Postfix) with ESMTP id 182D06B005D for ; Tue, 17 Nov 2020 12:58:05 -0500 (EST) Received: from smtpin27.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id A85C0824999B for ; Tue, 17 Nov 2020 17:58:04 +0000 (UTC) X-FDA: 77494668888.27.boy35_300f99327333 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin27.hostedemail.com (Postfix) with ESMTP id 814113D66B for ; Tue, 17 Nov 2020 17:58:04 +0000 (UTC) X-HE-Tag: boy35_300f99327333 X-Filterd-Recvd-Size: 2926 Received: from m12-17.163.com (m12-17.163.com [220.181.12.17]) by imf41.hostedemail.com (Postfix) with SMTP for ; Tue, 17 Nov 2020 17:58:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=Date:From:Subject:Message-ID:MIME-Version; bh=zYfSK VqhkOwN92ARjGk5n2dO2Y2pWB7jMUjWrrx7zIM=; b=XplTe1URYIydFZOHgokrZ SwmT2Z0xzc8PEIcpg7A22AE7LrKdKM8lPi4nuIYdqsVCL5fK1Wn+RQ6wRqGju/hF kOcLBAn2a91Bhf9zA1mDZBO09iqdYWNJ9tASlgesYMz4ab4QISdkmxgvUDgkitZ8 FAlsgMYSz+A9B3fb4fg+eQ= Received: from localhost (unknown [101.86.213.141]) by smtp13 (Coremail) with SMTP id EcCowACHA7bqDrRf3jfcUQ--.61818S2; Wed, 18 Nov 2020 01:56:58 +0800 (CST) Date: Wed, 18 Nov 2020 01:56:58 +0800 From: Hui Su To: Matthew Wilcox Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/lru: simplify is_file_lru() and is_active_lru() Message-ID: <20201117175658.GA158143@rlk> References: <20201117171242.GA120587@rlk> <20201117174117.GQ29991@casper.infradead.org> <20201117174633.GA158014@rlk> <20201117174727.GR29991@casper.infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201117174727.GR29991@casper.infradead.org> X-CM-TRANSID:EcCowACHA7bqDrRf3jfcUQ--.61818S2 X-Coremail-Antispam: 1Uf129KBjvdXoWrZF48Ar45GryUGFy8CF18Grg_yoWkXFcEqr yj9a9Fyw45JrZF9wnxCw4rXrsYka1DtFnIq34fJrykAr9xtFZ3KFWkXryFvrnYya1ftrs3 uw1Yv3sI93W7tjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IU1wZ2PUUUUU== X-Originating-IP: [101.86.213.141] X-CM-SenderInfo: xvkbvvri6rljoofrz/1tbiORTfX1XlverpvgABsc X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Nov 17, 2020 at 05:47:27PM +0000, Matthew Wilcox wrote: > On Wed, Nov 18, 2020 at 01:46:33AM +0800, Hui Su wrote: > > On Tue, Nov 17, 2020 at 05:41:17PM +0000, Matthew Wilcox wrote: > > > On Wed, Nov 18, 2020 at 01:12:42AM +0800, Hui Su wrote: > > > > lru_list lru bit 0 can tell whether the list is > > > > avtive lru-list or not. > > > > lru_list lru bit 1 can tell whether the list is > > > > file lru-list or not. > > > > > > > > And fix some define type in shrink_active_list() > > > > and get_scan_count(). > > > > > > > > v1->v2: > > > > correct the commit message, and fix the define type. > > > > > > No, still incorrect. > > > > I am a little confused, can you tell in detail? > > Have you booted a kernel with this change? Have you run any kind of > tests on it? Yes, I boot it with qemu-system-x86_64-4.1.50 on ubuntu20.04: qemu-system-x86_64 -kernel /home/rlk/workspace/compile/out/arch/x86_64/boot/bzImage -hda \ /home/rlk/myspace/qemu_build/rootfs.img -append "root=/dev/sda console=ttyS0" -nographic using the kernel compiled with ubuntu20.04's default .config. It seems nothing abnormal. And i did not do other test.