From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9F95C6369E for ; Tue, 17 Nov 2020 02:56:43 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 48D9A2078D for ; Tue, 17 Nov 2020 02:56:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="USQyK3bB" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 48D9A2078D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id A90986B009D; Mon, 16 Nov 2020 21:55:55 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9C8236B009E; Mon, 16 Nov 2020 21:55:55 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8B8CD6B009F; Mon, 16 Nov 2020 21:55:55 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0239.hostedemail.com [216.40.44.239]) by kanga.kvack.org (Postfix) with ESMTP id 5BB706B009D for ; Mon, 16 Nov 2020 21:55:55 -0500 (EST) Received: from smtpin05.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 04B55181AEF1F for ; Tue, 17 Nov 2020 02:55:55 +0000 (UTC) X-FDA: 77492395470.05.glove63_62031592732e Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin05.hostedemail.com (Postfix) with ESMTP id E1B891801954A for ; Tue, 17 Nov 2020 02:55:54 +0000 (UTC) X-HE-Tag: glove63_62031592732e X-Filterd-Recvd-Size: 3880 Received: from mail-qk1-f196.google.com (mail-qk1-f196.google.com [209.85.222.196]) by imf08.hostedemail.com (Postfix) with ESMTP for ; Tue, 17 Nov 2020 02:55:54 +0000 (UTC) Received: by mail-qk1-f196.google.com with SMTP id a13so141577qkl.4 for ; Mon, 16 Nov 2020 18:55:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=rph6elS4sVb6X0aZV8oBI4KEro3xkFbil1su2bbIStE=; b=USQyK3bB+z/rsRt1AELXV8ctRWtIiY5icuzdfAECiIyyhTqCjd/cubqHwqXKSUrpNW jS0x+7FDLMQEfX5d7LQRDJHMhIRUHZF7ZyjiIzz9U1hm4GfyOWrcoaA437AVuzPTV8jD gPnd6rltXsXDr1sppsRO9SurjxkcvrJY9DaPtvKkm38dDeNTSA+354EJG7j5ZVdclpAn oz/RVsDsjTwbuaICvAL+c02bw1WRI2G1FJ+tljpDFR8an2UnbZAvBcHpkmo4aS1mSE9w nBDJ91GZEg6FqhfGkMA0vfYxJtfEqU73B3egT2cKvmkDKOWEzPGV2v85V43YHu74tHYP 09tw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=rph6elS4sVb6X0aZV8oBI4KEro3xkFbil1su2bbIStE=; b=RdUC/+c8nvkR5R/Ao/x+NT4FuDCdgFvgGFZuw6dZ5gi67yEpNXF1Gmda1HIQ0FDJTU Pu7SxgMUWPI73QTx3Zt8z+QgeXmoQwT3UagGFJnqs4u4rxUn+3rsRazODRSk58DJ5A3l r0Pw5jtjlrnw5kWY29/xL8vbKQlajPtGv3qIi2V5IA4aqrTFHlaSlQDOVEBoe6279XIa zL6RO3/6r1fIgePZAN0BuSytywk8w6r853dA7jWIrD9yfoiyGS5MWdenCnfKl3G0lj0D Exi1WSV1LEr8XO7hRnRulIKujoexIOFYzNLUrU5NaBY17Asaa7rpQNQR2ZASZvcZsMtQ rRvg== X-Gm-Message-State: AOAM531IPh/cAOIjWhzYpDcgsWr/Ald2PdpnS7eXCMcC4SVIbwt9YMzd 8s9QoqwpXIGmTMOpxOMmzaM= X-Google-Smtp-Source: ABdhPJwMRPqQ+amOILxvnHFquv3aE3v+OBpkNV+6SrgJ/aizT1KI3eZnAQXhApmCEhRAYQUTMxaztQ== X-Received: by 2002:a37:8305:: with SMTP id f5mr17316880qkd.209.1605581753676; Mon, 16 Nov 2020 18:55:53 -0800 (PST) Received: from ubuntu-m3-large-x86 ([2604:1380:45f1:1d00::1]) by smtp.gmail.com with ESMTPSA id r14sm13431270qtu.25.2020.11.16.18.55.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Nov 2020 18:55:53 -0800 (PST) Date: Mon, 16 Nov 2020 19:55:51 -0700 From: Nathan Chancellor To: Lukas Bulwahn Cc: Roman Gushchin , Johannes Weiner , Andrew Morton , cgroups@vger.kernel.org, linux-mm@kvack.org, Michal Hocko , Vladimir Davydov , Arnd Bergmann , Tom Rix , Nick Desaulniers , clang-built-linux@googlegroups.com, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: memcg: remove obsolete memcg_has_children() Message-ID: <20201117025551.GA1103291@ubuntu-m3-large-x86> References: <20201116055043.20886-1-lukas.bulwahn@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201116055043.20886-1-lukas.bulwahn@gmail.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Nov 16, 2020 at 06:50:43AM +0100, Lukas Bulwahn wrote: > Commit 2ef1bf118c40 ("mm: memcg: deprecate the non-hierarchical mode") > removed the only use of memcg_has_children() in > mem_cgroup_hierarchy_write() as part of the feature deprecation. > > Hence, since then, make CC=clang W=1 warns: > > mm/memcontrol.c:3421:20: > warning: unused function 'memcg_has_children' [-Wunused-function] > > Simply remove this obsolete unused function. > > Signed-off-by: Lukas Bulwahn Reviewed-by: Nathan Chancellor