From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B51FC5519F for ; Sat, 14 Nov 2020 10:23:15 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id B806022252 for ; Sat, 14 Nov 2020 10:23:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B806022252 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 330FC6B0068; Sat, 14 Nov 2020 05:23:14 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2E0826B006C; Sat, 14 Nov 2020 05:23:14 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 21E7B6B006E; Sat, 14 Nov 2020 05:23:14 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0071.hostedemail.com [216.40.44.71]) by kanga.kvack.org (Postfix) with ESMTP id E8CF56B0068 for ; Sat, 14 Nov 2020 05:23:13 -0500 (EST) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 8C9E18249980 for ; Sat, 14 Nov 2020 10:23:13 +0000 (UTC) X-FDA: 77482636266.26.hour43_0e140a727316 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin26.hostedemail.com (Postfix) with ESMTP id 6B77E1804B656 for ; Sat, 14 Nov 2020 10:23:13 +0000 (UTC) X-HE-Tag: hour43_0e140a727316 X-Filterd-Recvd-Size: 1699 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf46.hostedemail.com (Postfix) with ESMTP for ; Sat, 14 Nov 2020 10:23:12 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id 14F2068AFE; Sat, 14 Nov 2020 11:23:11 +0100 (CET) Date: Sat, 14 Nov 2020 11:23:10 +0100 From: Christoph Hellwig To: "Matthew Wilcox (Oracle)" Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, hughd@google.com, hch@lst.de, hannes@cmpxchg.org, yang.shi@linux.alibaba.com, dchinner@redhat.com, linux-kernel@vger.kernel.org, Jan Kara , William Kucharski Subject: Re: [PATCH v4 16/16] mm/filemap: Return only head pages from find_get_entries Message-ID: <20201114102310.GP19102@lst.de> References: <20201112212641.27837-1-willy@infradead.org> <20201112212641.27837-17-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201112212641.27837-17-willy@infradead.org> User-Agent: Mutt/1.5.17 (2007-11-01) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Nov 12, 2020 at 09:26:41PM +0000, Matthew Wilcox (Oracle) wrote: > All callers now expect head (and base) pages, and can handle multiple > head pages in a single batch, so make find_get_entries() behave that way. > Also take the opportunity to make it use the pagevec infrastructure > instead of open-coding how pvecs behave. This has the side-effect of > being able to append to a pagevec with existing contents, although we > don't make use of that functionality anywhere yet. Looks good, Reviewed-by: Christoph Hellwig