From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C023FC5519F for ; Sat, 14 Nov 2020 10:03:22 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 8691B2224B for ; Sat, 14 Nov 2020 10:03:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8691B2224B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 216F66B0068; Sat, 14 Nov 2020 05:03:22 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 19F236B006C; Sat, 14 Nov 2020 05:03:22 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 08EF56B006E; Sat, 14 Nov 2020 05:03:22 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0217.hostedemail.com [216.40.44.217]) by kanga.kvack.org (Postfix) with ESMTP id CC8236B0068 for ; Sat, 14 Nov 2020 05:03:21 -0500 (EST) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 73C908249980 for ; Sat, 14 Nov 2020 10:03:21 +0000 (UTC) X-FDA: 77482586202.28.kite21_3b0e78d27316 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin28.hostedemail.com (Postfix) with ESMTP id 588236D64 for ; Sat, 14 Nov 2020 10:03:21 +0000 (UTC) X-HE-Tag: kite21_3b0e78d27316 X-Filterd-Recvd-Size: 1473 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf29.hostedemail.com (Postfix) with ESMTP for ; Sat, 14 Nov 2020 10:03:20 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id AB14267373; Sat, 14 Nov 2020 11:03:18 +0100 (CET) Date: Sat, 14 Nov 2020 11:03:18 +0100 From: Christoph Hellwig To: "Matthew Wilcox (Oracle)" Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, hughd@google.com, hch@lst.de, hannes@cmpxchg.org, yang.shi@linux.alibaba.com, dchinner@redhat.com, linux-kernel@vger.kernel.org, Jan Kara , William Kucharski Subject: Re: [PATCH v4 06/16] mm/filemap: Add helper for finding pages Message-ID: <20201114100318.GG19102@lst.de> References: <20201112212641.27837-1-willy@infradead.org> <20201112212641.27837-7-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201112212641.27837-7-willy@infradead.org> User-Agent: Mutt/1.5.17 (2007-11-01) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Nov 12, 2020 at 09:26:31PM +0000, Matthew Wilcox (Oracle) wrote: > + if (mark == XA_PRESENT) > + page = xas_find(xas, max); > + else > + page = xas_find_marked(xas, max, mark); Is there any good reason xas_find_marked can't handle the XA_PRESENT case as well? Otherwise looks good: Reviewed-by: Christoph Hellwig