From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25EA6C5519F for ; Sat, 14 Nov 2020 09:53:13 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 955882224B for ; Sat, 14 Nov 2020 09:53:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 955882224B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 952876B005C; Sat, 14 Nov 2020 04:53:11 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9023B6B005D; Sat, 14 Nov 2020 04:53:11 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7F1A06B0068; Sat, 14 Nov 2020 04:53:11 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0127.hostedemail.com [216.40.44.127]) by kanga.kvack.org (Postfix) with ESMTP id 4EF3C6B005C for ; Sat, 14 Nov 2020 04:53:11 -0500 (EST) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id E171E1EE6 for ; Sat, 14 Nov 2020 09:53:10 +0000 (UTC) X-FDA: 77482560540.13.rub53_3f00e9227316 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin13.hostedemail.com (Postfix) with ESMTP id C48DA18140B60 for ; Sat, 14 Nov 2020 09:53:10 +0000 (UTC) X-HE-Tag: rub53_3f00e9227316 X-Filterd-Recvd-Size: 1743 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf41.hostedemail.com (Postfix) with ESMTP for ; Sat, 14 Nov 2020 09:53:10 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id 830C468AFE; Sat, 14 Nov 2020 10:53:07 +0100 (CET) Date: Sat, 14 Nov 2020 10:53:07 +0100 From: Christoph Hellwig To: "Matthew Wilcox (Oracle)" Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, hughd@google.com, hch@lst.de, hannes@cmpxchg.org, yang.shi@linux.alibaba.com, dchinner@redhat.com, linux-kernel@vger.kernel.org, Jan Kara , William Kucharski Subject: Re: [PATCH v4 01/16] mm: Make pagecache tagged lookups return only head pages Message-ID: <20201114095307.GB19102@lst.de> References: <20201112212641.27837-1-willy@infradead.org> <20201112212641.27837-2-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201112212641.27837-2-willy@infradead.org> User-Agent: Mutt/1.5.17 (2007-11-01) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Nov 12, 2020 at 09:26:26PM +0000, Matthew Wilcox (Oracle) wrote: > Pagecache tags are used for dirty page writeback. Since dirtiness is > tracked on a per-THP basis, we only want to return the head page rather > than each subpage of a tagged page. All the filesystems which use huge > pages today are in-memory, so there are no tagged huge pages today. > > Signed-off-by: Matthew Wilcox (Oracle) > Reviewed-by: Jan Kara > Reviewed-by: William Kucharski Looks good, Reviewed-by: Christoph Hellwig