From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.3 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7BBA7C55ABD for ; Fri, 13 Nov 2020 20:54:15 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 1072C2224D for ; Fri, 13 Nov 2020 20:54:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Xr05ke3t" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1072C2224D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 978846B006E; Fri, 13 Nov 2020 15:54:14 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9268D6B0070; Fri, 13 Nov 2020 15:54:14 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 83CA96B0071; Fri, 13 Nov 2020 15:54:14 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0209.hostedemail.com [216.40.44.209]) by kanga.kvack.org (Postfix) with ESMTP id 5214C6B006E for ; Fri, 13 Nov 2020 15:54:14 -0500 (EST) Received: from smtpin22.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id E220B181AEF07 for ; Fri, 13 Nov 2020 20:54:13 +0000 (UTC) X-FDA: 77480597586.22.gun11_220de3427312 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin22.hostedemail.com (Postfix) with ESMTP id BBD7818038E68 for ; Fri, 13 Nov 2020 20:54:13 +0000 (UTC) X-HE-Tag: gun11_220de3427312 X-Filterd-Recvd-Size: 4860 Received: from mail-pf1-f195.google.com (mail-pf1-f195.google.com [209.85.210.195]) by imf46.hostedemail.com (Postfix) with ESMTP for ; Fri, 13 Nov 2020 20:54:13 +0000 (UTC) Received: by mail-pf1-f195.google.com with SMTP id q10so8671028pfn.0 for ; Fri, 13 Nov 2020 12:54:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=L/nTuHNenKI3mByfAmKMfGl5XsKGSrafuSBjeTgSoyg=; b=Xr05ke3tOLLPVl+BARViF3JhHDLwIb2OSdP08973SloTne2Xdl9b6A/CEO2/0PtwjY QfC+jBjv9t8T6d/GMJkQKwZoCWsVG++8MfuKIKDEr4QabdG3bIVs3roI57YNjGuKvjYF eonqGSJzOkPTgHMFl5JsrVgiE8E2JWnJ7TruDimoJf50MxhE0TZntcotn3022aXm0beI /KN/+F4e1fuuHRk/M2yMf96VINJs+pKIe4Xilxk2pXtf6xRhSrc7z4g9nuz6RBccoq8d Qv6fVGIy64mUGkrpxGYhyYXmFPjsFULgi3wpol3+S2ajz4X7PLE/XhSfP7JiTBIiMyUM ZJ0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=L/nTuHNenKI3mByfAmKMfGl5XsKGSrafuSBjeTgSoyg=; b=NU4DYKzp7Xk5dtaAzhorfPLF3muFNTCXsB4t2M0rVAtsGb7JMscKdlDAaoS4jjcedr PDKsNqfmqghBRLDt7A04BmiWhnvSSpjLxglfNGe2ZV7ZQsXszBbcIAQmSv+CU2LYyLsO 2INEROuSyaQXnrThi57+37prj5y2UhMPRbT1Qbf5Wwagd4jSWPRxNq/61aZdUmGoIezP H92V7bBlA4lH76qYLIVtmJqbTnlCbt4DjtUX/iJD5TazmJtcz4HMDiUVLF712GRnaFpo VNXVrpdBmOI6evuJO7CwmPKJVNcmae9QBt/grezrIkTYjEfdjt7t2d9Qu40dUY4x/Mhl PkBg== X-Gm-Message-State: AOAM531vMAziHlXe2s0tAoGbPaiNCZ8sSMA0CXpK2GcuUyHSFNL5bsl8 DMZoGoWRq8UCuM61BbsLo4M= X-Google-Smtp-Source: ABdhPJyMe77z4yunKaYCWv6Bp8CSJ31Rk1HAnMM/wc13YFGNMjfkEwpOonLXqdLdp3hzCGklAA8p9g== X-Received: by 2002:a17:90b:3512:: with SMTP id ls18mr5167558pjb.70.1605300852525; Fri, 13 Nov 2020 12:54:12 -0800 (PST) Received: from localhost.localdomain (c-107-3-138-210.hsd1.ca.comcast.net. [107.3.138.210]) by smtp.gmail.com with ESMTPSA id a18sm3780234pfa.151.2020.11.13.12.54.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Nov 2020 12:54:11 -0800 (PST) From: Yang Shi To: mhocko@suse.com, ziy@nvidia.com, songliubraving@fb.com, mgorman@suse.de, jack@suse.cz, willy@infradead.org, akpm@linux-foundation.org Cc: shy828301@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [v3 PATCH 1/5] mm: truncate_complete_page is not existed anymore Date: Fri, 13 Nov 2020 12:53:55 -0800 Message-Id: <20201113205359.556831-2-shy828301@gmail.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20201113205359.556831-1-shy828301@gmail.com> References: <20201113205359.556831-1-shy828301@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: The commit 9f4e41f4717832e34cca153ced62b4a1d7e26c0e ("mm: refactor truncate_complete_page()") refactored truncate_complete_page(), and it is not existed anymore, correct the comment in vmscan and migrate to avoi= d confusion. Reviewed-by: Jan Kara Signed-off-by: Yang Shi --- mm/migrate.c | 2 +- mm/vmscan.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/mm/migrate.c b/mm/migrate.c index 5ca5842df5db..8a2e7e19e27b 100644 --- a/mm/migrate.c +++ b/mm/migrate.c @@ -1106,7 +1106,7 @@ static int __unmap_and_move(struct page *page, stru= ct page *newpage, * and treated as swapcache but it has no rmap yet. * Calling try_to_unmap() against a page->mapping=3D=3DNULL page will * trigger a BUG. So handle it here. - * 2. An orphaned page (see truncate_complete_page) might have + * 2. An orphaned page (see truncate_cleanup_page) might have * fs-private metadata. The page can be picked up due to memory * offlining. Everywhere else except page reclaim, the page is * invisible to the vm, so the page can not be migrated. So try to diff --git a/mm/vmscan.c b/mm/vmscan.c index 1b8f0e059767..165cca87edc8 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -1393,7 +1393,7 @@ static unsigned int shrink_page_list(struct list_he= ad *page_list, * * Rarely, pages can have buffers and no ->mapping. These are * the pages which were not successfully invalidated in - * truncate_complete_page(). We try to drop those buffers here + * truncate_cleanup_page(). We try to drop those buffers here * and if that worked, and the page is no longer mapped into * process address space (page_count =3D=3D 1) it can be freed. * Otherwise, leave the page on the LRU so it is swappable. --=20 2.26.2