From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0EED9C5519F for ; Thu, 12 Nov 2020 15:20:24 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3817122240 for ; Thu, 12 Nov 2020 15:20:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=cmpxchg-org.20150623.gappssmtp.com header.i=@cmpxchg-org.20150623.gappssmtp.com header.b="qp58B68O" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3817122240 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cmpxchg.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id A15F56B006C; Thu, 12 Nov 2020 10:20:22 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 99DB86B006E; Thu, 12 Nov 2020 10:20:22 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8180C6B0070; Thu, 12 Nov 2020 10:20:22 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0049.hostedemail.com [216.40.44.49]) by kanga.kvack.org (Postfix) with ESMTP id 4C4E06B006C for ; Thu, 12 Nov 2020 10:20:22 -0500 (EST) Received: from smtpin07.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id BB0113626 for ; Thu, 12 Nov 2020 15:20:21 +0000 (UTC) X-FDA: 77476127442.07.art94_0416c1427307 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin07.hostedemail.com (Postfix) with ESMTP id 8C71D1803F9A0 for ; Thu, 12 Nov 2020 15:20:21 +0000 (UTC) X-HE-Tag: art94_0416c1427307 X-Filterd-Recvd-Size: 3592 Received: from mail-qv1-f65.google.com (mail-qv1-f65.google.com [209.85.219.65]) by imf40.hostedemail.com (Postfix) with ESMTP for ; Thu, 12 Nov 2020 15:20:20 +0000 (UTC) Received: by mail-qv1-f65.google.com with SMTP id e5so2913943qvs.1 for ; Thu, 12 Nov 2020 07:20:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=lDRYcXH2Tlj+IsIFX0IkGhrvzNzP1X0UM9xeo7JwYWg=; b=qp58B68OPcq6WzCKL4Pxf4Cr2rWBYMhIbERa2fIh0ekx+BVEyeZ1gfxwljBJfv+0i+ FDpnQacMYMr6b8ydDk8N6u74cXlmI0bIANHfXGNa8s+7AAkL/IdR1kwaEQWwUMOCz1Wf fVKQFvFLdo+9bJraJJ5FXNKnSdpATqUvDGKoWj6WX1s8f2OlOUd6XEhUxTPdKhbxYwn0 Lhag4BnDc6o0IH25tzvxoqMZIBJ1sILoIw/c02tF+vwlIoAAvuXg0H2csYQyn5WOyf6O X7RRl/uK9LOCITHE0XPrpTfyrBonx23oEpvCJGqBsP+EanQVT55ivxKYFLsCcBRCBx2N GS9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=lDRYcXH2Tlj+IsIFX0IkGhrvzNzP1X0UM9xeo7JwYWg=; b=QjpitWyVa4yD1EnR5Xey7vXOdGhSwFPtHRq42LV/PR6tudAPOcPrgr8DJYEXR7G9VZ wJbCjZV/BhdoB78Z+DCAGlI37D7OMb3D/ZdT29leH82yNQIc9iPUI4esTJsQn901NH/d plGnrYR29kjJcfaUWOoUNEgARU5pYWp6lg7sbI9ScP3KkxVZ/UR4D8Hx9SF4R1TjHyaZ 8C0JuyfWhSxtoRpL0ppRi3z7uiyA67Ku/48kJM40qPn45YE8RsF/iNBSMEjWrWgjCW76 ajnTYIRI8j/6GtXJosQVIsD+C11RCZJbZIBgEC9KHO/J6W+3c4hN8PqmjBwOPkXREwMk UgOA== X-Gm-Message-State: AOAM533EzepQ92JQ6fBue+jFMcMgp/XTRvVn71xhhXaqmb331LnHHQyy b57Y3CAuQAzJEeb3sW1fh4+oFw== X-Google-Smtp-Source: ABdhPJypfB00vA2U1wYcu9CcFQg2UwLr3WnG0G63MjEHHhSJSPCac+fmNLrV3dVmsCiQGd6yuXJUIg== X-Received: by 2002:ad4:524b:: with SMTP id s11mr223505qvq.3.1605194420152; Thu, 12 Nov 2020 07:20:20 -0800 (PST) Received: from localhost ([2620:10d:c091:480::1:7257]) by smtp.gmail.com with ESMTPSA id k31sm4693276qtd.40.2020.11.12.07.20.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Nov 2020 07:20:18 -0800 (PST) Date: Thu, 12 Nov 2020 10:18:28 -0500 From: Johannes Weiner To: Roman Gushchin Cc: Andrew Morton , linux-mm@kvack.org, Shakeel Butt , Michal Hocko , Christoph Lameter , linux-kernel@vger.kernel.org, kernel-team@fb.com Subject: Re: [PATCH 1/2] mm: slub: call account_slab_page() after slab page initialization Message-ID: <20201112151828.GA873621@cmpxchg.org> References: <20201110195753.530157-1-guro@fb.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201110195753.530157-1-guro@fb.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Nov 10, 2020 at 11:57:52AM -0800, Roman Gushchin wrote: > It's convenient to have page->objects initialized before calling > into account_slab_page(). In particular, this information can be > used to pre-alloc the obj_cgroup vector. > > Let's call account_slab_page() a bit later, after the initialization > of page->objects. > > This commit doesn't bring any functional change, but is required for > further optimizations. > > Signed-off-by: Roman Gushchin Acked-by: Johannes Weiner