From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5AA2C5517A for ; Wed, 11 Nov 2020 11:13:12 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 032F12074B for ; Wed, 11 Nov 2020 11:13:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=canb.auug.org.au header.i=@canb.auug.org.au header.b="WSivZMUu" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 032F12074B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=canb.auug.org.au Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 1847F6B006E; Wed, 11 Nov 2020 06:13:10 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 10D616B0070; Wed, 11 Nov 2020 06:13:10 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EEDE16B0071; Wed, 11 Nov 2020 06:13:09 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0018.hostedemail.com [216.40.44.18]) by kanga.kvack.org (Postfix) with ESMTP id BA4996B006E for ; Wed, 11 Nov 2020 06:13:09 -0500 (EST) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 629BC8249980 for ; Wed, 11 Nov 2020 11:13:09 +0000 (UTC) X-FDA: 77471875698.23.size83_340b25d272fd Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin23.hostedemail.com (Postfix) with ESMTP id 153893760C for ; Wed, 11 Nov 2020 11:13:09 +0000 (UTC) X-HE-Tag: size83_340b25d272fd X-Filterd-Recvd-Size: 5237 Received: from ozlabs.org (bilbo.ozlabs.org [203.11.71.1]) by imf34.hostedemail.com (Postfix) with ESMTP for ; Wed, 11 Nov 2020 11:13:07 +0000 (UTC) Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4CWMXV5mSTz9sSs; Wed, 11 Nov 2020 22:12:58 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=canb.auug.org.au; s=201702; t=1605093181; bh=QE1/yS9A+y7apFmQa9E6DBK0BKDrYI0qrcJCc+5O2Fk=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=WSivZMUuFx6UDN1/vyBmQUbbtks3lK2MkkHMbBq91c8+7lsfmb4kP9XSt1DqdaCTH A35OlMR2A1BcFrEpEKGWBb2xdfRfrEyYVAtR2Z/G74lbvUPE+beBdkmDI1yFVyRGH6 uTkr7ptr4paiukHoqOz4tjWOXhgUbBmQwLkvNCRCLyVvQYGosYQ3q5Gbw5escDzjQL 8MoR2Z5fSscYhDwxMqTzrTlarhysFifkwLFSuxsDdhioAPk1ub6xUqUSF6sIqZ3jwf B1JeOQ0zWASSBvCKQx5ayHpPHvO+53ojBuJqQNfuWr+thoL7BB9pIfESms+vG4vw6P d6742qRZd1oxQ== Date: Wed, 11 Nov 2020 22:12:54 +1100 From: Stephen Rothwell To: Christoph Hellwig Cc: Christian Borntraeger , Nick Desaulniers , akpm@linux-foundation.org, dan.j.williams@intel.com, daniel@ffwll.ch, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-nvdimm@lists.01.org, Heiko Carstens , Vasily Gorbik , clang-built-linux@googlegroups.com, Linux-Next Mailing List Subject: Re: [PATCH 2/2] mm: simplify follow_pte{,pmd} Message-ID: <20201111221254.7f6a3658@canb.auug.org.au> In-Reply-To: <20201111082842.GA23677@lst.de> References: <20201029101432.47011-3-hch@lst.de> <20201111022122.1039505-1-ndesaulniers@google.com> <20201111081800.GA23492@lst.de> <673267d5-93f5-7278-7a9d-a7b35ede6d48@de.ibm.com> <20201111082842.GA23677@lst.de> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/Mc_NX=GVNozxrVPRgbb7NWp"; protocol="application/pgp-signature"; micalg=pgp-sha256 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: --Sig_/Mc_NX=GVNozxrVPRgbb7NWp Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Hi Christoph, On Wed, 11 Nov 2020 09:28:42 +0100 Christoph Hellwig wrote: > > On Wed, Nov 11, 2020 at 09:26:20AM +0100, Christian Borntraeger wrote: > >=20 > > On 11.11.20 09:18, Christoph Hellwig wrote: =20 > > > On Tue, Nov 10, 2020 at 06:21:22PM -0800, Nick Desaulniers wrote: =20 > > >> Sorry, I think this patch may be causing a regression for us for s39= 0? > > >> https://travis-ci.com/github/ClangBuiltLinux/continuous-integration/= jobs/432129279#L768 > > >> > > >> (via https://lore.kernel.org/linux-mm/20201029101432.47011-3-hch@lst= .de) =20 > > >=20 > > > Hmm, the call to follow_pte_pmd in the s390 code does not actually ex= ist > > > in my tree. =20 > >=20 > > This is a mid-air collision in linux-next between > >=20 > > b2ff5796a934 ("mm: simplify follow_pte{,pmd}") > > a67a88b0b8de ("s390/pci: remove races against pte updates") =20 >=20 > Ah. The fixup is trivial: just s/follow_pte_pmd/follow_pte/. ok, so tomorrow I will add the following to the merge of the akpm-current tree: From: Stephen Rothwell Date: Wed, 11 Nov 2020 22:08:32 +1100 Subject: [PATCH] merge fix for "s390/pci: remove races against pte updates" Signed-off-by: Stephen Rothwell --- arch/s390/pci/pci_mmio.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/s390/pci/pci_mmio.c b/arch/s390/pci/pci_mmio.c index 1a6adbc68ee8..4a4993837413 100644 --- a/arch/s390/pci/pci_mmio.c +++ b/arch/s390/pci/pci_mmio.c @@ -173,7 +173,7 @@ SYSCALL_DEFINE3(s390_pci_mmio_write, unsigned long, mmi= o_addr, if (!(vma->vm_flags & VM_WRITE)) goto out_unlock_mmap; =20 - ret =3D follow_pte_pmd(vma->vm_mm, mmio_addr, NULL, &ptep, NULL, &ptl); + ret =3D follow_pte(vma->vm_mm, mmio_addr, NULL, &ptep, NULL, &ptl); if (ret) goto out_unlock_mmap; =20 @@ -317,7 +317,7 @@ SYSCALL_DEFINE3(s390_pci_mmio_read, unsigned long, mmio= _addr, if (!(vma->vm_flags & VM_WRITE)) goto out_unlock_mmap; =20 - ret =3D follow_pte_pmd(vma->vm_mm, mmio_addr, NULL, &ptep, NULL, &ptl); + ret =3D follow_pte(vma->vm_mm, mmio_addr, NULL, &ptep, NULL, &ptl); if (ret) goto out_unlock_mmap; =20 --=20 2.29.2 --=20 Cheers, Stephen Rothwell --Sig_/Mc_NX=GVNozxrVPRgbb7NWp Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEENIC96giZ81tWdLgKAVBC80lX0GwFAl+rxzYACgkQAVBC80lX 0GzxoggAnTSbP2MvHm/AvrWkgYxvOlLSLXdQ/ImkKzdhpKhThkA1ncXWZFIvTgHc 46Y9TwSWR1HQOm/f/jyDe0qAIJP0857bxOHXTlFvY/3FSDv+WZc/2pSf1v5zAZnG edhdutlXgBgCqwhnux5ooDQUqwjwqiom+evJLaLtWzRAopB3QoLWA4vjk3KQ4HPa Z30h1i+dcqrXCDfbELftpAIDBZ7S0OWZakJzDPWKAYHlz4cbV/BhkDRf9rpb0i+I c/tpAnopxEVSWx1JCooiR7ZC2y/kXNl18K+Y83xy8bJdAmaR1jCSqlZsHDdBnpU3 k/JOL0denkdXvrOMB7V3apBHpRJ8iQ== =AA7r -----END PGP SIGNATURE----- --Sig_/Mc_NX=GVNozxrVPRgbb7NWp--