From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F4A3C388F9 for ; Wed, 11 Nov 2020 11:04:27 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id EB522206D9 for ; Wed, 11 Nov 2020 11:04:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="R8rhYgRj" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EB522206D9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 1B50E6B0036; Wed, 11 Nov 2020 06:04:26 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 13FA16B005D; Wed, 11 Nov 2020 06:04:26 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 006A86B0068; Wed, 11 Nov 2020 06:04:25 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0117.hostedemail.com [216.40.44.117]) by kanga.kvack.org (Postfix) with ESMTP id C56E86B0036 for ; Wed, 11 Nov 2020 06:04:25 -0500 (EST) Received: from smtpin20.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 6AE79180AD804 for ; Wed, 11 Nov 2020 11:04:25 +0000 (UTC) X-FDA: 77471853690.20.shock09_091065c272fd Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin20.hostedemail.com (Postfix) with ESMTP id 44152180C07A3 for ; Wed, 11 Nov 2020 11:04:25 +0000 (UTC) X-HE-Tag: shock09_091065c272fd X-Filterd-Recvd-Size: 4785 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf16.hostedemail.com (Postfix) with ESMTP for ; Wed, 11 Nov 2020 11:04:24 +0000 (UTC) Received: from kernel.org (unknown [77.125.7.142]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B39BE206D9; Wed, 11 Nov 2020 11:04:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1605092663; bh=6mVJM7br/AZrziH2MmM8/kLPWqumU6zjuSl8o3JuUB0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=R8rhYgRjiSA1tpuYygoeNE5zZX3oFBqGlhpqbSKUl/DqSOGPWrtUi81V/c3uP5YeP DOm79S607XeamzxILnW2EvV/DJzA7AI5G6K8FxdVmpZXnJlY4lHqZTHKnstwWD6m27 Et8DC9XEC/sIJGOEzRwVAnM8AhqKgIi4KXrLonjg= Date: Wed, 11 Nov 2020 13:04:16 +0200 From: Mike Rapoport To: Arnd Bergmann Cc: Stefan Agner , Minchan Kim , ngupta@vflare.org, Sergey Senozhatsky , Andrew Morton , sjenning@linux.vnet.ibm.com, gregkh , Arnd Bergmann , Linux-MM , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] mm/zsmalloc: include sparsemem.h for MAX_PHYSMEM_BITS Message-ID: <20201111110416.GG4758@kernel.org> References: <20201108064659.GD301837@kernel.org> <7782fb694a6b0c500e8f32ecf895b2bf@agner.ch> <20201110095806.GH301837@kernel.org> <20201110162155.GA4758@kernel.org> <20201111102654.GF4758@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Nov 11, 2020 at 11:57:02AM +0100, Arnd Bergmann wrote: > On Wed, Nov 11, 2020 at 11:26 AM Mike Rapoport wrote: > > > > On Wed, Nov 11, 2020 at 10:33:29AM +0100, Arnd Bergmann wrote: > > > On Tue, Nov 10, 2020 at 5:21 PM Mike Rapoport wrote: > > > > On Tue, Nov 10, 2020 at 12:21:11PM +0100, Arnd Bergmann wrote: > > > > > > > > > > To be on the safe side, we could provoke a compile-time error > > > > > when CONFIG_PHYS_ADDR_T_64BIT is set on a 32-bit > > > > > architecture, but MAX_POSSIBLE_PHYSMEM_BITS is not set. > > > > > > > > Maybe compile time warning and a runtime error in zs_init() if 32 bit > > > > machine has memory above 4G? > > > > > > If the fix is as easy as adding a single line in a header, I think a > > > compile-time > > > error makes it easier, no need to wait for someone to boot a broken > > > system before fixing it. > > > > Not sure it would be as easy as adding a single line in a header for > > MIPS with it's diversity. > > I looked up the architecture, and found: > > - The pre-MIPS32r1 cores only support 32-bit addressing > - octeon selects PHYS_ADDR_T_64BIT but no longer > supports 32-bit kernels > - Alchemy and netlogic (XLR, XLP) have 36-bit addressing > - CONFIG_XPA implies 40-bit addressing Fair enough. A typo below. > We should run it by the MIPS maintainers, but I think this patch > is sufficient: > > --- a/arch/mips/include/asm/pgtable-32.h > +++ b/arch/mips/include/asm/pgtable-32.h > @@ -154,6 +154,7 @@ static inline void pmd_clear(pmd_t *pmdp) > > #if defined(CONFIG_XPA) > > +#define MAX_POSSIBLE_PHYSMEM_BITS 40 > #define pte_pfn(x) (((unsigned long)((x).pte_high >> > _PFN_SHIFT)) | (unsigned long)((x).pte_low << _PAGE_PRESENT_SHIFT)) > static inline pte_t > pfn_pte(unsigned long pfn, pgprot_t prot) > @@ -169,6 +170,7 @@ pfn_pte(unsigned long pfn, pgprot_t prot) > > #elif defined(CONFIG_PHYS_ADDR_T_64BIT) && defined(CONFIG_CPU_MIPS32) > > +#define MAX_POSSIBLE_PHYSMEM_BITS 35 ^ 36 ? > #define pte_pfn(x) ((unsigned long)((x).pte_high >> 6)) > > static inline pte_t pfn_pte(unsigned long pfn, pgprot_t prot) > @@ -183,6 +185,7 @@ static inline pte_t pfn_pte(unsigned long pfn, > pgprot_t prot) > > #else > > +#define MAX_POSSIBLE_PHYSMEM_BITS 32 > #ifdef CONFIG_CPU_VR41XX > #define pte_pfn(x) ((unsigned long)((x).pte >> (PAGE_SHIFT + 2))) > #define pfn_pte(pfn, prot) __pte(((pfn) << (PAGE_SHIFT + 2)) | > pgprot_val(prot)) > > Arnd -- Sincerely yours, Mike.