From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4AE0DC388F9 for ; Wed, 11 Nov 2020 09:28:34 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id BBD152072C for ; Wed, 11 Nov 2020 09:28:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BBD152072C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 68A746B006E; Wed, 11 Nov 2020 04:28:26 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5C1FC6B0072; Wed, 11 Nov 2020 04:28:26 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 467EE6B0074; Wed, 11 Nov 2020 04:28:26 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0235.hostedemail.com [216.40.44.235]) by kanga.kvack.org (Postfix) with ESMTP id 0AAD86B0072 for ; Wed, 11 Nov 2020 04:28:25 -0500 (EST) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id AF142181AC9CC for ; Wed, 11 Nov 2020 09:28:25 +0000 (UTC) X-FDA: 77471611770.06.waste53_100b361272fc Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin06.hostedemail.com (Postfix) with ESMTP id 90C0710045630 for ; Wed, 11 Nov 2020 09:28:25 +0000 (UTC) X-HE-Tag: waste53_100b361272fc X-Filterd-Recvd-Size: 4222 Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf42.hostedemail.com (Postfix) with ESMTP for ; Wed, 11 Nov 2020 09:28:25 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id B0ACFAD1A; Wed, 11 Nov 2020 09:28:22 +0000 (UTC) From: Vlastimil Babka To: Andrew Morton Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Michal Hocko , Pavel Tatashin , David Hildenbrand , Oscar Salvador , Joonsoo Kim , Vlastimil Babka , Michal Hocko Subject: [PATCH v3 5/7] mm, page_alloc: cache pageset high and batch in struct zone Date: Wed, 11 Nov 2020 10:28:10 +0100 Message-Id: <20201111092812.11329-6-vbabka@suse.cz> X-Mailer: git-send-email 2.29.1 In-Reply-To: <20201111092812.11329-1-vbabka@suse.cz> References: <20201111092812.11329-1-vbabka@suse.cz> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: All per-cpu pagesets for a zone use the same high and batch values, that = are duplicated there just for performance (locality) reasons. This patch adds= the same variables also to struct zone as a shared copy. This will be useful later for making possible to disable pcplists tempora= rily by setting high value to 0, while remembering the values for restoring th= em later. But we can also immediately benefit from not updating pagesets of = all possible cpus in case the newly recalculated values (after sysctl change = or memory online/offline) are actually unchanged from the previous ones. Signed-off-by: Vlastimil Babka Reviewed-by: Oscar Salvador Acked-by: Michal Hocko --- include/linux/mmzone.h | 6 ++++++ mm/page_alloc.c | 16 ++++++++++++++-- 2 files changed, 20 insertions(+), 2 deletions(-) diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h index 7385871768d4..bb9188de2718 100644 --- a/include/linux/mmzone.h +++ b/include/linux/mmzone.h @@ -470,6 +470,12 @@ struct zone { #endif struct pglist_data *zone_pgdat; struct per_cpu_pageset __percpu *pageset; + /* + * the high and batch values are copied to individual pagesets for + * faster access + */ + int pageset_high; + int pageset_batch; =20 #ifndef CONFIG_SPARSEMEM /* diff --git a/mm/page_alloc.c b/mm/page_alloc.c index 8b43d6d1a288..25bc9bb77696 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -5912,6 +5912,9 @@ static void build_zonelists(pg_data_t *pgdat) * Other parts of the kernel may not check if the zone is available. */ static void pageset_init(struct per_cpu_pageset *p); +/* These effectively disable the pcplists in the boot pageset completely= */ +#define BOOT_PAGESET_HIGH 0 +#define BOOT_PAGESET_BATCH 1 static DEFINE_PER_CPU(struct per_cpu_pageset, boot_pageset); static DEFINE_PER_CPU(struct per_cpu_nodestat, boot_nodestats); =20 @@ -6301,8 +6304,8 @@ static void pageset_init(struct per_cpu_pageset *p) * need to be as careful as pageset_update() as nobody can access the * pageset yet. */ - pcp->high =3D 0; - pcp->batch =3D 1; + pcp->high =3D BOOT_PAGESET_HIGH; + pcp->batch =3D BOOT_PAGESET_BATCH; } =20 /* @@ -6326,6 +6329,13 @@ static void zone_set_pageset_high_and_batch(struct= zone *zone) new_batch =3D max(1UL, 1 * new_batch); } =20 + if (zone->pageset_high =3D=3D new_high && + zone->pageset_batch =3D=3D new_batch) + return; + + zone->pageset_high =3D new_high; + zone->pageset_batch =3D new_batch; + for_each_possible_cpu(cpu) { p =3D per_cpu_ptr(zone->pageset, cpu); pageset_update(&p->pcp, new_high, new_batch); @@ -6386,6 +6396,8 @@ static __meminit void zone_pcp_init(struct zone *zo= ne) * offset of a (static) per cpu variable into the per cpu area. */ zone->pageset =3D &boot_pageset; + zone->pageset_high =3D BOOT_PAGESET_HIGH; + zone->pageset_batch =3D BOOT_PAGESET_BATCH; =20 if (populated_zone(zone)) printk(KERN_DEBUG " %s zone: %lu pages, LIFO batch:%u\n", --=20 2.29.1