From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AAAD4C56201 for ; Wed, 11 Nov 2020 08:28:49 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 288EA2074B for ; Wed, 11 Nov 2020 08:28:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 288EA2074B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 5F6E66B0036; Wed, 11 Nov 2020 03:28:48 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5A7526B005D; Wed, 11 Nov 2020 03:28:48 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4E5F66B0068; Wed, 11 Nov 2020 03:28:48 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0056.hostedemail.com [216.40.44.56]) by kanga.kvack.org (Postfix) with ESMTP id 2052D6B0036 for ; Wed, 11 Nov 2020 03:28:48 -0500 (EST) Received: from smtpin16.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id C4AC5180AD802 for ; Wed, 11 Nov 2020 08:28:47 +0000 (UTC) X-FDA: 77471461494.16.park22_51058bd272fc Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin16.hostedemail.com (Postfix) with ESMTP id A28DC100E6917 for ; Wed, 11 Nov 2020 08:28:47 +0000 (UTC) X-HE-Tag: park22_51058bd272fc X-Filterd-Recvd-Size: 2087 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf41.hostedemail.com (Postfix) with ESMTP for ; Wed, 11 Nov 2020 08:28:47 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id 26B746736F; Wed, 11 Nov 2020 09:28:43 +0100 (CET) Date: Wed, 11 Nov 2020 09:28:42 +0100 From: Christoph Hellwig To: Christian Borntraeger Cc: Christoph Hellwig , Nick Desaulniers , akpm@linux-foundation.org, dan.j.williams@intel.com, daniel@ffwll.ch, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-nvdimm@lists.01.org, Heiko Carstens , Vasily Gorbik , clang-built-linux@googlegroups.com, Linux-Next Mailing List Subject: Re: [PATCH 2/2] mm: simplify follow_pte{,pmd} Message-ID: <20201111082842.GA23677@lst.de> References: <20201029101432.47011-3-hch@lst.de> <20201111022122.1039505-1-ndesaulniers@google.com> <20201111081800.GA23492@lst.de> <673267d5-93f5-7278-7a9d-a7b35ede6d48@de.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <673267d5-93f5-7278-7a9d-a7b35ede6d48@de.ibm.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Nov 11, 2020 at 09:26:20AM +0100, Christian Borntraeger wrote: > > On 11.11.20 09:18, Christoph Hellwig wrote: > > On Tue, Nov 10, 2020 at 06:21:22PM -0800, Nick Desaulniers wrote: > >> Sorry, I think this patch may be causing a regression for us for s390? > >> https://travis-ci.com/github/ClangBuiltLinux/continuous-integration/jobs/432129279#L768 > >> > >> (via https://lore.kernel.org/linux-mm/20201029101432.47011-3-hch@lst.de) > > > > Hmm, the call to follow_pte_pmd in the s390 code does not actually exist > > in my tree. > > This is a mid-air collision in linux-next between > > b2ff5796a934 ("mm: simplify follow_pte{,pmd}") > a67a88b0b8de ("s390/pci: remove races against pte updates") Ah. The fixup is trivial: just s/follow_pte_pmd/follow_pte/.