From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=BAYES_00,BODY_ENHANCEMENT, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78FD0C55ABD for ; Tue, 10 Nov 2020 18:56:16 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A449B20797 for ; Tue, 10 Nov 2020 18:56:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=cmpxchg-org.20150623.gappssmtp.com header.i=@cmpxchg-org.20150623.gappssmtp.com header.b="FjxVS80A" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A449B20797 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cmpxchg.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id D0C5F6B0036; Tue, 10 Nov 2020 13:56:14 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CE1CA6B005C; Tue, 10 Nov 2020 13:56:14 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BF9276B005D; Tue, 10 Nov 2020 13:56:14 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0183.hostedemail.com [216.40.44.183]) by kanga.kvack.org (Postfix) with ESMTP id 941D76B0036 for ; Tue, 10 Nov 2020 13:56:14 -0500 (EST) Received: from smtpin12.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 3A925181AEF1A for ; Tue, 10 Nov 2020 18:56:14 +0000 (UTC) X-FDA: 77469413868.12.limit69_6105287272f7 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin12.hostedemail.com (Postfix) with ESMTP id 1679D18053C21 for ; Tue, 10 Nov 2020 18:56:14 +0000 (UTC) X-HE-Tag: limit69_6105287272f7 X-Filterd-Recvd-Size: 5732 Received: from mail-qk1-f194.google.com (mail-qk1-f194.google.com [209.85.222.194]) by imf40.hostedemail.com (Postfix) with ESMTP for ; Tue, 10 Nov 2020 18:56:13 +0000 (UTC) Received: by mail-qk1-f194.google.com with SMTP id 11so12523222qkd.5 for ; Tue, 10 Nov 2020 10:56:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=/t4qmwU8gtuB0mOErW3ybsjmE66Khyr55gvm/nUMiEo=; b=FjxVS80ALjbcXnrjko2K/KZQcsv8d1KTprjdA2bLKBKFw2Qky9XWG/ZXVjW72SeI9x ga38XY+XdDDaWXMuAd5W/LULK6Mu/WBjvAKO/2qrbJTzwFmdhKwNQblygh7CuTaXngPo Z7Z+mqdinSqw3HrGsPASxEq9RL8tKGQMaAPBpk7R3Yy3CTuWRGbwJED19YOJVH0HWKTD T+4EGg6CJpte/rGOeXVdmpHqFpMYaB//cqqtNzH1sHkJkQZDaHzUuU401Dz3eNN2Mb5B i9c1TmLW7nNY0/wrv6RGfYfwRexLEoV+P0kuvVpBsTDMrBBRE9qkOUu4UuHnwMIlcEhK gH+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=/t4qmwU8gtuB0mOErW3ybsjmE66Khyr55gvm/nUMiEo=; b=jeZkqTdsKpgPY9YR6xjTrZe1xeRA0chUTLDMlldf1Rb9bAx112kfZ/AN16sx77mP2G IpJeQcVNaHcNOo9S6lmEotLEP1j9aeZcfwmJV//tZdi7zhkkH5agtYNzzxerwOY8easd +kVYSGHhaCQePED8Gf/KJPlO1FfFeNpYkhLJDMqZUOttBcBM2rocq7Pgd0Km1e9U0zhi xcvL2kUCTovChOUHBSAbk1lexDoM4cTRfhM+Phfm4vYNsXI+pAL+ReHVKI7KzPypxhkP 6nZ7Ib+BrmW4ZLkv5+h+C6PlvxMNYXu2Nec2dXWzM7hrcOAdomI2ppyTC2hVAhBk6R3g vSuA== X-Gm-Message-State: AOAM5334QFnr2M6me9+sWH5eNnU/uwUUocAjRGdtQoTo9XPTr1RPP6x3 QLk5PEMrg21pR6wvc2w22hKTPQ== X-Google-Smtp-Source: ABdhPJzSPXhtgtZgD1pAoq/PFLmxJ/OgrE3zaATzVkgYzStiPmKlqHUK5gl3lHmmdxFOHKjysN5U4A== X-Received: by 2002:a37:8c82:: with SMTP id o124mr5051944qkd.410.1605034572483; Tue, 10 Nov 2020 10:56:12 -0800 (PST) Received: from localhost ([2620:10d:c091:480::1:64f7]) by smtp.gmail.com with ESMTPSA id p48sm9096538qtp.67.2020.11.10.10.56.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Nov 2020 10:56:11 -0800 (PST) Date: Tue, 10 Nov 2020 13:54:24 -0500 From: Johannes Weiner To: Alex Shi Cc: akpm@linux-foundation.org, mgorman@techsingularity.net, tj@kernel.org, hughd@google.com, khlebnikov@yandex-team.ru, daniel.m.jordan@oracle.com, willy@infradead.org, lkp@intel.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, shakeelb@google.com, iamjoonsoo.kim@lge.com, richard.weiyang@gmail.com, kirill@shutemov.name, alexander.duyck@gmail.com, rong.a.chen@intel.com, mhocko@suse.com, vdavydov.dev@gmail.com, shy828301@gmail.com, Michal Hocko , Yang Shi Subject: Re: [PATCH v21 17/19] mm/lru: replace pgdat lru_lock with lruvec lock Message-ID: <20201110185424.GB850433@cmpxchg.org> References: <1604566549-62481-1-git-send-email-alex.shi@linux.alibaba.com> <1604566549-62481-18-git-send-email-alex.shi@linux.alibaba.com> <5b085715-292a-4b43-50b3-d73dc90d1de5@linux.alibaba.com> <5a4c2b72-7ee8-2478-fc0e-85eb83aafec4@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5a4c2b72-7ee8-2478-fc0e-85eb83aafec4@linux.alibaba.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Nov 06, 2020 at 03:48:16PM +0800, Alex Shi wrote: > From 84e69f892119d99612e9668e3fe47a3922bafff1 Mon Sep 17 00:00:00 2001 > From: Alex Shi > Date: Tue, 18 Aug 2020 16:44:21 +0800 > Subject: [PATCH v21 17/19] mm/lru: replace pgdat lru_lock with lruvec lock > > This patch moves per node lru_lock into lruvec, thus bring a lru_lock for > each of memcg per node. So on a large machine, each of memcg don't > have to suffer from per node pgdat->lru_lock competition. They could go > fast with their self lru_lock. > > After move memcg charge before lru inserting, page isolation could > serialize page's memcg, then per memcg lruvec lock is stable and could > replace per node lru lock. > > In func isolate_migratepages_block, compact_unlock_should_abort and > lock_page_lruvec_irqsave are open coded to work with compact_control. > Also add a debug func in locking which may give some clues if there are > sth out of hands. > > Daniel Jordan's testing show 62% improvement on modified readtwice case > on his 2P * 10 core * 2 HT broadwell box. > https://lore.kernel.org/lkml/20200915165807.kpp7uhiw7l3loofu@ca-dmjordan1.us.oracle.com/ > > On a large machine with memcg enabled but not used, the page's lruvec > seeking pass a few pointers, that may lead to lru_lock holding time > increase and a bit regression. > > Hugh Dickins helped on the patch polish, thanks! > > Signed-off-by: Alex Shi > Acked-by: Hugh Dickins > Cc: Rong Chen > Cc: Hugh Dickins > Cc: Andrew Morton > Cc: Johannes Weiner > Cc: Michal Hocko > Cc: Vladimir Davydov > Cc: Yang Shi > Cc: Matthew Wilcox > Cc: Konstantin Khlebnikov > Cc: Tejun Heo > Cc: linux-kernel@vger.kernel.org > Cc: linux-mm@kvack.org > Cc: cgroups@vger.kernel.org Acked-by: Johannes Weiner