From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B418C388F7 for ; Tue, 10 Nov 2020 18:42:25 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C372E21D91 for ; Tue, 10 Nov 2020 18:42:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="RkBCGrtq" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C372E21D91 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 532036B005D; Tue, 10 Nov 2020 13:42:22 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4E07F6B0068; Tue, 10 Nov 2020 13:42:22 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3CFB26B006C; Tue, 10 Nov 2020 13:42:22 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0036.hostedemail.com [216.40.44.36]) by kanga.kvack.org (Postfix) with ESMTP id 0DFC56B005D for ; Tue, 10 Nov 2020 13:42:22 -0500 (EST) Received: from smtpin03.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id A03528249980 for ; Tue, 10 Nov 2020 18:42:21 +0000 (UTC) X-FDA: 77469378882.03.mice43_4414e74272f7 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin03.hostedemail.com (Postfix) with ESMTP id 78D9228A4E9 for ; Tue, 10 Nov 2020 18:42:21 +0000 (UTC) X-HE-Tag: mice43_4414e74272f7 X-Filterd-Recvd-Size: 2162 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf13.hostedemail.com (Postfix) with ESMTP for ; Tue, 10 Nov 2020 18:42:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=RlvumwFFqtHHTtqgXiiCCmpECmDemzXqXgYQ9Vk4WBw=; b=RkBCGrtqgxR5MwtIwJ7MABW3TI AjONZMSKrcdRtT06jWDpO73w2mbRWkvVywabhoWVQPGuGsvEnkjKlsofAnDFVnJ+R69qpKA6Gwnh5 vvR0L+DVDIJcPnYNSW3FIa42EcQ5ty8XXXARL2tHT55wqjQNMNkrASal1SB7mK9X/EKk2m18Y6XL4 p45LENjHF8RSDd+71xAPqsSRCownFFpae4+kYuIZO3GD8J9FDMU+BMwjH2754N6Y3KgF82rjRIYQz TEpmLiKGZeK6GJ451hAWDBiszx5b5TzJuenpoGwOZh7OyEVjWZzErjzKsE5e/zdgJjEDIBQ4qj7vn JEYKKn4A==; Received: from willy by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1kcYat-00031m-Be; Tue, 10 Nov 2020 18:42:15 +0000 Date: Tue, 10 Nov 2020 18:42:15 +0000 From: Matthew Wilcox To: Christoph Hellwig Cc: Andrew Morton , Dan Williams , Daniel Vetter , linux-nvdimm@lists.01.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 2/2] mm: simplify follow_pte{,pmd} Message-ID: <20201110184215.GM17076@casper.infradead.org> References: <20201029101432.47011-1-hch@lst.de> <20201029101432.47011-3-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201029101432.47011-3-hch@lst.de> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Oct 29, 2020 at 11:14:32AM +0100, Christoph Hellwig wrote: > Merge __follow_pte_pmd, follow_pte_pmd and follow_pte into a single > follow_pte function and just pass two additional NULL arguments for > the two previous follow_pte callers. > > Signed-off-by: Christoph Hellwig Reviewed-by: Matthew Wilcox (Oracle) I'm not entirely convinced this is the right interface, but your patch makes things better, so I approve.