From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9E17C55ABD for ; Tue, 10 Nov 2020 18:21:23 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 30067206B6 for ; Tue, 10 Nov 2020 18:21:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 30067206B6 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id AA73C6B006C; Tue, 10 Nov 2020 13:21:22 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A57026B0070; Tue, 10 Nov 2020 13:21:22 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 993E76B0071; Tue, 10 Nov 2020 13:21:22 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0180.hostedemail.com [216.40.44.180]) by kanga.kvack.org (Postfix) with ESMTP id 6FE3D6B006C for ; Tue, 10 Nov 2020 13:21:22 -0500 (EST) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 1A0C58249980 for ; Tue, 10 Nov 2020 18:21:22 +0000 (UTC) X-FDA: 77469326004.24.end85_5202be7272f7 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin24.hostedemail.com (Postfix) with ESMTP id E786B1A4A0 for ; Tue, 10 Nov 2020 18:21:21 +0000 (UTC) X-HE-Tag: end85_5202be7272f7 X-Filterd-Recvd-Size: 1336 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf12.hostedemail.com (Postfix) with ESMTP for ; Tue, 10 Nov 2020 18:21:21 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id F3B5567373; Tue, 10 Nov 2020 19:21:18 +0100 (CET) Date: Tue, 10 Nov 2020 19:21:18 +0100 From: Christoph Hellwig To: "Matthew Wilcox (Oracle)" Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, hch@lst.de, kent.overstreet@gmail.com Subject: Re: [PATCH v3 03/18] mm/filemap: Convert filemap_get_pages to take a pagevec Message-ID: <20201110182118.GB28701@lst.de> References: <20201110033703.23261-1-willy@infradead.org> <20201110033703.23261-4-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201110033703.23261-4-willy@infradead.org> User-Agent: Mutt/1.5.17 (2007-11-01) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Nov 10, 2020 at 03:36:48AM +0000, Matthew Wilcox (Oracle) wrote: > Using a pagevec lets us keep the pages and the number of pages together > which simplifies a lot of the calling conventions. > > Signed-off-by: Matthew Wilcox (Oracle) I hate the > 80 char lines in a few spots, but otherwise this looks good: Reviewed-by: Christoph Hellwig