From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90384C55ABD for ; Tue, 10 Nov 2020 18:16:50 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id BFB51207D3 for ; Tue, 10 Nov 2020 18:16:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="ipGMqHHT" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BFB51207D3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 46C3B6B005D; Tue, 10 Nov 2020 13:16:49 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 41CF46B0068; Tue, 10 Nov 2020 13:16:49 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 30C406B006C; Tue, 10 Nov 2020 13:16:49 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0042.hostedemail.com [216.40.44.42]) by kanga.kvack.org (Postfix) with ESMTP id 02B7A6B005D for ; Tue, 10 Nov 2020 13:16:48 -0500 (EST) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 86B60362D for ; Tue, 10 Nov 2020 18:16:48 +0000 (UTC) X-FDA: 77469314496.06.bell50_041490d272f7 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin06.hostedemail.com (Postfix) with ESMTP id 654F010037CCF for ; Tue, 10 Nov 2020 18:16:48 +0000 (UTC) X-HE-Tag: bell50_041490d272f7 X-Filterd-Recvd-Size: 2278 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf07.hostedemail.com (Postfix) with ESMTP for ; Tue, 10 Nov 2020 18:16:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=pKCQZvoOQvWJRr3uzI2/rpjCuOUN8d8NnWJ8MSJwkRQ=; b=ipGMqHHT+Uh0XxKxUPFmvFKydJ dMurDpcXKK5sQ2/Kql2V4k2Osotc5yw2+jhhptLKc8IM6uVGToetKBKz5EgkjKfrtYk4Ga1yyGz5k H6B4TO7qAC4KL/3BDzhj9GYRytENrSmJ8eb6ThZP82QFvASFzUgGkpLADZsH9g/rhw8UThhWuUblc 6HdOuGwSctoZheyJbn0UDl6le+M/JTi/OLZ27iLf+KTEL2EZXAlY19AEbq9tlOmDMatiE0MNx9Sqg h4OgllRyJrqxS4wkayL/q+JaAkQrmv5R+1q81aARrPjo9YD6XAbxgi5N0UEVMjqtscS9xLc5A1ZcY wuXuDAAg==; Received: from willy by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1kcYC4-0001JN-3d; Tue, 10 Nov 2020 18:16:36 +0000 Date: Tue, 10 Nov 2020 18:16:36 +0000 From: Matthew Wilcox To: Yang Shi Cc: mhocko@suse.com, ziy@nvidia.com, songliubraving@fb.com, mgorman@suse.de, jack@suse.cz, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [v2 PATCH 3/5] mm: migrate: skip shared exec THP for NUMA balancing Message-ID: <20201110181636.GJ17076@casper.infradead.org> References: <20201110181250.264394-1-shy828301@gmail.com> <20201110181250.264394-4-shy828301@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201110181250.264394-4-shy828301@gmail.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Nov 10, 2020 at 10:12:48AM -0800, Yang Shi wrote: > @@ -2142,6 +2151,10 @@ int migrate_misplaced_transhuge_page(struct mm_struct *mm, > int page_lru = page_is_file_lru(page); > unsigned long start = address & HPAGE_PMD_MASK; > > + if (IS_ENABLED(CONFIG_READ_ONLY_THP_FOR_FS) && > + is_shared_exec_page(vma, page)) > + goto out; Why include the IS_ENABLED() check? Once the ~50 patches I have pending go in, shared executable THPs can exist without this option. And can't we have executables on tmpfs today without this option too?