From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F336C388F7 for ; Tue, 10 Nov 2020 15:24:56 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 8E51D20867 for ; Tue, 10 Nov 2020 15:24:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=cmpxchg-org.20150623.gappssmtp.com header.i=@cmpxchg-org.20150623.gappssmtp.com header.b="on8OoPlw" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8E51D20867 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cmpxchg.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 1C2166B0068; Tue, 10 Nov 2020 10:24:55 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1744F6B0071; Tue, 10 Nov 2020 10:24:55 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 061B96B0072; Tue, 10 Nov 2020 10:24:54 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0083.hostedemail.com [216.40.44.83]) by kanga.kvack.org (Postfix) with ESMTP id CB9526B0068 for ; Tue, 10 Nov 2020 10:24:54 -0500 (EST) Received: from smtpin18.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 7A03A180AD806 for ; Tue, 10 Nov 2020 15:24:54 +0000 (UTC) X-FDA: 77468881308.18.steel76_5a06b92272f6 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin18.hostedemail.com (Postfix) with ESMTP id 43825100ED9CA for ; Tue, 10 Nov 2020 15:24:54 +0000 (UTC) X-HE-Tag: steel76_5a06b92272f6 X-Filterd-Recvd-Size: 3775 Received: from mail-qk1-f196.google.com (mail-qk1-f196.google.com [209.85.222.196]) by imf24.hostedemail.com (Postfix) with ESMTP for ; Tue, 10 Nov 2020 15:24:53 +0000 (UTC) Received: by mail-qk1-f196.google.com with SMTP id d28so6656945qka.11 for ; Tue, 10 Nov 2020 07:24:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=4K7M+yU2qQGJnBqVAjylDdUBTFCEnQjaCz6moXfYMEE=; b=on8OoPlw3VSXy8JNQfuM/sHMVZ8emLX5MZJzG0sTRRpgjWF3aRCwxgJSI9FEVC44qS 4kQmG920BaTWRgy9W2+iS2syx5dG8Yg/RXtBHWoo/nKw12Ik/Ir0l7CSBjpeXHec2dph lNTHcg4fv8MpCEcu4c1MPc5PltE4KD+y6Lh3c2Wbsrd3pxKmW1K3nSqPVTtn/9yghgNO pM8A1l0COcK6/hiUfry60njJLbjv+PNmAhrx5oDAM/Um3Rwv00auj9hEJ+rr8/0YIKVG vTQ4g4GT+ArZWI37EDyK9bWNccjv5MrIbne6986cr4gqOKWA46X7OiN7nEmlRpHxIGJJ yFIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=4K7M+yU2qQGJnBqVAjylDdUBTFCEnQjaCz6moXfYMEE=; b=OG+qvTHMO3r0zeBILCgcYVtNnhQqLiuRmHhJYndyyrn+4tMiN1hd1bgOcjlJukccy3 KfzyXI3nCXiKPLKE/AxzB4yBqjue7P70QZY2AiZcO6DkU/YXUYe6fG+imPzhrj8ExmKx DOY9/FdnssZE4h0OIxE2DVrGvW4S+x7MM/8pJDaO0RLe00moktV2d4ve8ioESZhVvDxv 7hwbo6GwS94sy6mr3BXldSGTYgY75tSzU5T21e4G1BOAZMMPGe2cAZzd7t3q0wDP0dJm EOuzGFSnl/14uHCOFeYjvem52EX5izyNotGqUC+Gr/pWUEUONynNKhPzeinZVE/nlT9k dYTA== X-Gm-Message-State: AOAM533lDZhLFXu9Kt5+itwX9E3bRd2zFWWJr/Z89fRNpNX2BMzdLyyH hdVh7Za/FzuIQuhrQbcY1+Tvfg== X-Google-Smtp-Source: ABdhPJxuT7o7jGuflTbr/sPJgqp+0sOaR0b+eEindXqCvTJFRyfwlR+LPCGxtZ48m83DCNLhjDx0mA== X-Received: by 2002:a37:8685:: with SMTP id i127mr19241385qkd.37.1605021893130; Tue, 10 Nov 2020 07:24:53 -0800 (PST) Received: from localhost ([2620:10d:c091:480::1:64f7]) by smtp.gmail.com with ESMTPSA id o16sm589744qkg.27.2020.11.10.07.24.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Nov 2020 07:24:52 -0800 (PST) Date: Tue, 10 Nov 2020 10:23:05 -0500 From: Johannes Weiner To: Muchun Song Cc: mhocko@kernel.org, vdavydov.dev@gmail.com, akpm@linux-foundation.org, cl@linux.com, penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, shakeelb@google.com, guro@fb.com, vbabka@suse.cz, laoar.shao@gmail.com, chris@chrisdown.name, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v2] mm: memcg/slab: Fix root memcg vmstats Message-ID: <20201110152305.GB842337@cmpxchg.org> References: <20201110031015.15715-1-songmuchun@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201110031015.15715-1-songmuchun@bytedance.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Nov 10, 2020 at 11:10:15AM +0800, Muchun Song wrote: > If we reparent the slab objects to the root memcg, when we free > the slab object, we need to update the per-memcg vmstats to keep > it correct for the root memcg. Now this at least affects the vmstat > of NR_KERNEL_STACK_KB for !CONFIG_VMAP_STACK when the thread stack > size is smaller than the PAGE_SIZE. > > Fixes: ec9f02384f60 ("mm: workingset: fix vmstat counters for shadow nodes") > Signed-off-by: Muchun Song > Acked-by: Roman Gushchin Acked-by: Johannes Weiner