From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41512C4741F for ; Mon, 9 Nov 2020 16:05:02 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 76D9720789 for ; Mon, 9 Nov 2020 16:05:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=cmpxchg-org.20150623.gappssmtp.com header.i=@cmpxchg-org.20150623.gappssmtp.com header.b="iB3XHuw6" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 76D9720789 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cmpxchg.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id EB1FE6B005C; Mon, 9 Nov 2020 11:05:00 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E5F9E6B005D; Mon, 9 Nov 2020 11:05:00 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CDA926B006C; Mon, 9 Nov 2020 11:05:00 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0046.hostedemail.com [216.40.44.46]) by kanga.kvack.org (Postfix) with ESMTP id A2C126B005C for ; Mon, 9 Nov 2020 11:05:00 -0500 (EST) Received: from smtpin14.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 4E142824999B for ; Mon, 9 Nov 2020 16:05:00 +0000 (UTC) X-FDA: 77465353560.14.fifth32_5c0d994272ed Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin14.hostedemail.com (Postfix) with ESMTP id DCB5418229818 for ; Mon, 9 Nov 2020 16:04:59 +0000 (UTC) X-HE-Tag: fifth32_5c0d994272ed X-Filterd-Recvd-Size: 3586 Received: from mail-qv1-f68.google.com (mail-qv1-f68.google.com [209.85.219.68]) by imf09.hostedemail.com (Postfix) with ESMTP for ; Mon, 9 Nov 2020 16:04:58 +0000 (UTC) Received: by mail-qv1-f68.google.com with SMTP id g19so4283668qvy.2 for ; Mon, 09 Nov 2020 08:04:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=WvJ0YDNiIKOb4v9Q+LyNzMnKuPiwJgJcEld0LM73h6c=; b=iB3XHuw6xKS/JYIn2SPC3z1C+cvFMzqeIBW1XkZ2t4WZ3UWkxSpkOah/vtLbtIarxj mCe9GKVeHAGkq8ylaQCAV4HUsWw9KjNA7ppFgpjbXqZ2I0E0CGHw323O1Rx//AoRDeQg DENYRogKFjY67x03eRvsq4Xy7NIlIm3FuTVDQwh4f08w0biP7hlqrEPuR8B2/aA3rSG6 bc3q9fu6xqzffXVQpYQXaSjrJ9LuI+1Qy13AZTNDroPXC50cGUFbWLbIFayG2CAad1/P 072UuxZVk6IyCznI1G75l6HOAjCk1mRKSLCJkvTwb+N7Hzr7tmpvNRlYzmjbWWF0u1Ro H4Wg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=WvJ0YDNiIKOb4v9Q+LyNzMnKuPiwJgJcEld0LM73h6c=; b=diNPWZUJYE19K5yNl8r1YI0Hty/QzWO4/nui5xIhJXC/OeGd+6ceYQtzBJGZR7yWUc XVPFPUiEw4bGR5w/2CIL1YXJVyZyX6oIoFOR3NBfERCs3HDnrWSPAhzzzxAd9wSi2wS9 fgVnCqtIX3Ab+9lE22YU1Gr8mnGYPrQw8EdZUF1fLpZFUahLDzF5I9vJrOBtKMB5b26I +KldAwC+ViF2JbYfYWCw2AC+nESvOl6d4AcZH6NlxI2P1FWIoUYyMWSi2SAFWt/TN66J 22gN4HiA+ZEiOnFz4WkLzqYq+Uz2NSU6KmSccNGIAqMNiTSS43VCvyY0jhpvqMKwNvvi YLbA== X-Gm-Message-State: AOAM533RTSie14M8a2gwm7/XA0B3u98whhQiTDm7fxM60SU5WGNxglhF eWQfAC22SFwkkF8K+G2G9EQWlQ== X-Google-Smtp-Source: ABdhPJyxTOIIvojL9SEg24jB1l30J4qCixHclNXowPYpDR65zlRLBQ27r20TMUpniSsNJadNzKP8cQ== X-Received: by 2002:a05:6214:174f:: with SMTP id dc15mr14434958qvb.26.1604937898293; Mon, 09 Nov 2020 08:04:58 -0800 (PST) Received: from localhost ([2620:10d:c091:480::1:7912]) by smtp.gmail.com with ESMTPSA id z20sm6198791qtb.31.2020.11.09.08.04.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Nov 2020 08:04:57 -0800 (PST) Date: Mon, 9 Nov 2020 11:03:09 -0500 From: Johannes Weiner To: "Matthew Wilcox (Oracle)" Cc: linux-mm@kvack.org, akpm@linux-foundation.org, william.kucharski@oracle.com, feng.tang@intel.com, zhengjun.xing@intel.com, rong.a.chen@intel.com, Xing Zhengjun Subject: Re: [PATCH] mm: Fix madvise WILLNEED performance problem Message-ID: <20201109160309.GA807548@cmpxchg.org> References: <20201109134851.29692-1-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201109134851.29692-1-willy@infradead.org> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Nov 09, 2020 at 01:48:51PM +0000, Matthew Wilcox (Oracle) wrote: > The calculation of the end page index was incorrect, leading to a > regression of 70% when running stress-ng. With this fix, we instead > see a performance improvement of 3%. > > Reported-by: kernel test robot > Tested-by: Xing Zhengjun > Fixes: e6e88712e43b ("mm: optimise madvise WILLNEED") > Signed-off-by: Matthew Wilcox (Oracle) Acked-by: Johannes Weiner