From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6395EC5517A for ; Fri, 6 Nov 2020 17:46:53 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D5A2522227 for ; Fri, 6 Nov 2020 17:46:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="CQIkI1ax" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D5A2522227 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 510FF6B0073; Fri, 6 Nov 2020 12:46:52 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4E7F46B0074; Fri, 6 Nov 2020 12:46:52 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3FD9C6B007B; Fri, 6 Nov 2020 12:46:52 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0158.hostedemail.com [216.40.44.158]) by kanga.kvack.org (Postfix) with ESMTP id 14C596B0073 for ; Fri, 6 Nov 2020 12:46:52 -0500 (EST) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id BC4C0180AD81F for ; Fri, 6 Nov 2020 17:46:51 +0000 (UTC) X-FDA: 77454723822.13.fog98_4605ee1272d4 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin13.hostedemail.com (Postfix) with ESMTP id 9519C18140B67 for ; Fri, 6 Nov 2020 17:46:51 +0000 (UTC) X-HE-Tag: fog98_4605ee1272d4 X-Filterd-Recvd-Size: 3403 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf22.hostedemail.com (Postfix) with ESMTP for ; Fri, 6 Nov 2020 17:46:51 +0000 (UTC) Received: from sol.localdomain (172-10-235-113.lightspeed.sntcca.sbcglobal.net [172.10.235.113]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 96A4B2151B; Fri, 6 Nov 2020 17:46:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604684810; bh=4o77fqFuBZvPiDYAW30olp6av5R3X4/iv+z7vMt50bA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=CQIkI1axVORa3PbPPE/4evBmU3xr79YrxNJvILQKc/9EgpD9wzoUDOapCBTSofz8d QTqdPdkByflxlpoDy7egZoLU3F+pdjtbXKtt1GrCGC8o6QSm1KNHnghF5FZ0wdAksW zEtsWWIH2jOZoshKVrojhTsdCy2J+fHU63gXVUz0= Date: Fri, 6 Nov 2020 09:46:47 -0800 From: Eric Biggers To: Lokesh Gidra Cc: Andrea Arcangeli , Alexander Viro , James Morris , Stephen Smalley , Casey Schaufler , "Serge E. Hallyn" , Paul Moore , Eric Paris , Daniel Colascione , Kees Cook , "Eric W. Biederman" , KP Singh , David Howells , Thomas Cedeno , Anders Roxell , Sami Tolvanen , Matthew Garrett , Aaron Goidel , Randy Dunlap , "Joel Fernandes (Google)" , YueHaibing , Christian Brauner , Alexei Starovoitov , Alexey Budankov , Adrian Reber , Aleksa Sarai , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org, selinux@vger.kernel.org, kaleshsingh@google.com, calin@google.com, surenb@google.com, nnk@google.com, jeffv@google.com, kernel-team@android.com, linux-mm@kvack.org, Andrew Morton , hch@infradead.org, Daniel Colascione Subject: Re: [PATCH v12 2/4] fs: add LSM-supporting anon-inode interface Message-ID: <20201106174647.GC845@sol.localdomain> References: <20201106155626.3395468-1-lokeshgidra@google.com> <20201106155626.3395468-3-lokeshgidra@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201106155626.3395468-3-lokeshgidra@google.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Nov 06, 2020 at 07:56:24AM -0800, Lokesh Gidra wrote: > +/** > + * Like anon_inode_getfd(), but creates a new !S_PRIVATE anon inode rather than > + * reuse the singleton anon inode, and call the anon_init_security_anon() LSM > + * hook. This allows the inode to have its own security context and for a LSM "call the anon_init_security_anon() LSM hook" => "calls the inode_init_security_anon() LSM hook". Otherwise this patch looks okay. Feel free to add: Reviewed-by: Eric Biggers - Eric