From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB270C388F2 for ; Fri, 6 Nov 2020 17:22:11 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E300A2078B for ; Fri, 6 Nov 2020 17:22:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="Z5hliPe4" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E300A2078B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 4255D6B0036; Fri, 6 Nov 2020 12:22:10 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3D5526B005D; Fri, 6 Nov 2020 12:22:10 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2C3D36B0070; Fri, 6 Nov 2020 12:22:10 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0156.hostedemail.com [216.40.44.156]) by kanga.kvack.org (Postfix) with ESMTP id F00B76B0036 for ; Fri, 6 Nov 2020 12:22:09 -0500 (EST) Received: from smtpin14.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 8A76E181AEF10 for ; Fri, 6 Nov 2020 17:22:09 +0000 (UTC) X-FDA: 77454661578.14.care63_5505d64272d4 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin14.hostedemail.com (Postfix) with ESMTP id 688151822989D for ; Fri, 6 Nov 2020 17:22:09 +0000 (UTC) X-HE-Tag: care63_5505d64272d4 X-Filterd-Recvd-Size: 4914 Received: from mail-qt1-f193.google.com (mail-qt1-f193.google.com [209.85.160.193]) by imf06.hostedemail.com (Postfix) with ESMTP for ; Fri, 6 Nov 2020 17:22:08 +0000 (UTC) Received: by mail-qt1-f193.google.com with SMTP id i12so1284569qtj.0 for ; Fri, 06 Nov 2020 09:22:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Y11rYbDMlG4Jq6y1mMF8XHIQBRgQTi4LgEIfp1+Fy2I=; b=Z5hliPe42ZhsJgIpO8yM/A/BmnWabQMZyxH3x1SujgBdxmpQeo1iLC7dJllfTWrgs+ ckOwCsKncKsZUSkDwm+CRG+PtHOhk6vGyhb3vaWmExO06uZRfYDDy4x0lNtyZAxfIGSF TzNe/ATxzOTxeiv/h6NniXGC8bMAeaQsSamd0SJaMbdJqgcKE7FX8hgittLCSxWN+Hk0 aEVb3jWNuQ84GZTQ7t0z2P0KnBO9475+HL13KJpZeDMWi657ip/5nImwsscD/jRB/6+1 tzYyPHfeLOmV9kq1MtWUFMAFC/4Mt9DF6Qfy0pjFFXFFgIEb7ZfC/ufepIEP0MSbyLqW 1mng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Y11rYbDMlG4Jq6y1mMF8XHIQBRgQTi4LgEIfp1+Fy2I=; b=oWGep4bnWb7Ok08Z0xmKgQyXmtJARhh6/EJm6/q0dK9O3fNAcCEC0x8SJKUqzzFfu6 e/7TlsW52U9JKcKOZoLKODvcPkFWSqAA34WwApfChDtwGo6joMRu5DlSzjMpVx71xza8 /QGb3Ps7BImFteRW65yYZjciev0s6XZJ2YdODBJ3xUeocqPPab2nBfk3HEDYFuOFT7rP m1ekk9KutEOK6u0ZbDahfd8a6s268UP2xdf1HR2Au/pLnaHmLDCTnpnyCILKuSgpjZHJ xENeqQ5+RG+m6LPyfwBNFni9QEo4UUuXatexXZ50VaDLYoX/trlV/sdsSdbr9c86oWos w+HQ== X-Gm-Message-State: AOAM530hY1g/Ma1807RSyx647vUTr+wIO4sc1wOdfpjiPdmoSe7iyyZG ISdh4CLasgTid3HOiQCQeWPPHA== X-Google-Smtp-Source: ABdhPJyiYapImJ+Y336x/nMMBsQzuXDQ9V5MrPZLPGSARv/D7dBPhFBvVcl8QNPKfF7/i3znPagsCA== X-Received: by 2002:ac8:4d4d:: with SMTP id x13mr2465811qtv.72.1604683328177; Fri, 06 Nov 2020 09:22:08 -0800 (PST) Received: from ziepe.ca (hlfxns017vw-156-34-48-30.dhcp-dynamic.fibreop.ns.bellaliant.net. [156.34.48.30]) by smtp.gmail.com with ESMTPSA id w45sm942700qtw.96.2020.11.06.09.22.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Nov 2020 09:22:07 -0800 (PST) Received: from jgg by mlx with local (Exim 4.94) (envelope-from ) id 1kb5R8-000z7J-TY; Fri, 06 Nov 2020 13:22:06 -0400 Date: Fri, 6 Nov 2020 13:22:06 -0400 From: Jason Gunthorpe To: Logan Gunthorpe Cc: linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, linux-block@vger.kernel.org, linux-pci@vger.kernel.org, linux-mm@kvack.org, iommu@lists.linux-foundation.org, Stephen Bates , Christoph Hellwig , Dan Williams , Christian =?utf-8?B?S8O2bmln?= , Ira Weiny , John Hubbard , Don Dutile , Matthew Wilcox , Daniel Vetter Subject: Re: [RFC PATCH 14/15] PCI/P2PDMA: Introduce pci_mmap_p2pmem() Message-ID: <20201106172206.GS36674@ziepe.ca> References: <20201106170036.18713-1-logang@deltatee.com> <20201106170036.18713-15-logang@deltatee.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201106170036.18713-15-logang@deltatee.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Nov 06, 2020 at 10:00:35AM -0700, Logan Gunthorpe wrote: > Introduce pci_mmap_p2pmem() which is a helper to allocate and mmap > a hunk of p2pmem into userspace. > > Signed-off-by: Logan Gunthorpe > drivers/pci/p2pdma.c | 104 +++++++++++++++++++++++++++++++++++++ > include/linux/pci-p2pdma.h | 6 +++ > 2 files changed, 110 insertions(+) > > diff --git a/drivers/pci/p2pdma.c b/drivers/pci/p2pdma.c > index 9961e779f430..8eab53ac59ae 100644 > +++ b/drivers/pci/p2pdma.c > @@ -16,6 +16,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -1055,3 +1056,106 @@ ssize_t pci_p2pdma_enable_show(char *page, struct pci_dev *p2p_dev, > return sprintf(page, "%s\n", pci_name(p2p_dev)); > } > EXPORT_SYMBOL_GPL(pci_p2pdma_enable_show); > + > +struct pci_p2pdma_map { > + struct kref ref; > + struct pci_dev *pdev; > + void *kaddr; > + size_t len; > +}; Why have this at all? Nothing uses it and no vm_operations ops are implemented? This is very inflexable, it would be better if this is designed like io_remap_pfn where it just preps and fills the VMA, doesn't take ownership of the entire VMA Jason