From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30828C5517A for ; Fri, 6 Nov 2020 08:11:24 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C01AE208C3 for ; Fri, 6 Nov 2020 08:11:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C01AE208C3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 38D806B0075; Fri, 6 Nov 2020 03:11:23 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 33D416B0078; Fri, 6 Nov 2020 03:11:23 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 22B196B007B; Fri, 6 Nov 2020 03:11:23 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0008.hostedemail.com [216.40.44.8]) by kanga.kvack.org (Postfix) with ESMTP id E236F6B0075 for ; Fri, 6 Nov 2020 03:11:22 -0500 (EST) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 82E24180AD804 for ; Fri, 6 Nov 2020 08:11:22 +0000 (UTC) X-FDA: 77453273604.28.women99_0a01a28272d1 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin28.hostedemail.com (Postfix) with ESMTP id 64DDF6D68 for ; Fri, 6 Nov 2020 08:11:22 +0000 (UTC) X-HE-Tag: women99_0a01a28272d1 X-Filterd-Recvd-Size: 1509 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf38.hostedemail.com (Postfix) with ESMTP for ; Fri, 6 Nov 2020 08:11:21 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id 8B7B268B05; Fri, 6 Nov 2020 09:11:19 +0100 (CET) Date: Fri, 6 Nov 2020 09:11:19 +0100 From: Christoph Hellwig To: "Matthew Wilcox (Oracle)" Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, hch@lst.de, kent.overstreet@gmail.com Subject: Re: [PATCH v2 09/18] mm/filemap: Change filemap_read_page calling conventions Message-ID: <20201106081119.GE31585@lst.de> References: <20201104204219.23810-1-willy@infradead.org> <20201104204219.23810-10-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201104204219.23810-10-willy@infradead.org> User-Agent: Mutt/1.5.17 (2007-11-01) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Nov 04, 2020 at 08:42:10PM +0000, Matthew Wilcox (Oracle) wrote: > @@ -2288,7 +2270,18 @@ static struct page *filemap_update_page(struct kiocb *iocb, struct file *filp, > return page; > > readpage: > + if (iocb->ki_flags & (IOCB_NOIO | IOCB_NOWAIT | IOCB_WAITQ)) { > + unlock_page(page); > + put_page(page); > + return ERR_PTR(-EAGAIN); > + } > + error = filemap_read_page(iocb->ki_filp, mapping, page); > + if (!error) I still find the eraly return here weird.. Otherwise looks good: Reviewed-by: Christoph Hellwig