From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0B58C4741F for ; Thu, 5 Nov 2020 17:34:00 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 379E12151B for ; Thu, 5 Nov 2020 17:34:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JCS92kQT" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 379E12151B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id BC49D6B016C; Thu, 5 Nov 2020 12:33:59 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B74046B016D; Thu, 5 Nov 2020 12:33:59 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A618E6B016E; Thu, 5 Nov 2020 12:33:59 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0022.hostedemail.com [216.40.44.22]) by kanga.kvack.org (Postfix) with ESMTP id 707C86B016C for ; Thu, 5 Nov 2020 12:33:59 -0500 (EST) Received: from smtpin27.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 0A72A824999B for ; Thu, 5 Nov 2020 17:33:59 +0000 (UTC) X-FDA: 77451062598.27.kite71_41089e0272cb Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin27.hostedemail.com (Postfix) with ESMTP id DCB5A3D66B for ; Thu, 5 Nov 2020 17:33:58 +0000 (UTC) X-HE-Tag: kite71_41089e0272cb X-Filterd-Recvd-Size: 4137 Received: from mail-pf1-f195.google.com (mail-pf1-f195.google.com [209.85.210.195]) by imf34.hostedemail.com (Postfix) with ESMTP for ; Thu, 5 Nov 2020 17:33:58 +0000 (UTC) Received: by mail-pf1-f195.google.com with SMTP id v12so1874858pfm.13 for ; Thu, 05 Nov 2020 09:33:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=AUFgPvv6rFgfWp8DArPv00GwKNR+UKOLg+uDf2rhEHc=; b=JCS92kQTECAAa7cDKcOEZyVg1HDPCOM18Lc/ZmZ4okFITjl+71gi3Sk9AUr4QpltYK YWy0skAWf+ehpUvWrlA6S5Zt7HkflK13LhEQNmYW2aU+laan+fREW9BmXeM6ZYl9EN4A k/0FJMDalzkC4I4uz1ceBQNeOCrfU1txTtb73gPx3a5QbMMyuyuGpfNQZmbct7OAn7To EzGe9ewcpYo1d+R7TumcejL9X9HTi5ZQsupWUsGAtcFbp73SvKJ9qRNZ3bMA3RG+bmXY ++c9h5K/SIrVN/ePzoSLb9xsZ2i7df5oTbTkEly/+OTL56Hro7IDQEetkVCSn9Iq8f+/ k8cA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=AUFgPvv6rFgfWp8DArPv00GwKNR+UKOLg+uDf2rhEHc=; b=WogYys2hlun5nxNTI/CclpQejP9uXW9IDa/DWmcexF2czwBEoLEN5kbOYF43Z2Vl9o bPqKqEnzW0B8DvyP0KKYTJHPiGD4ZFHVB6ag6Def5+Y0AJLNE+ZkYEmoWu1vKN6YDMML on3qcsSl+ktYo2y2MUHf8CKLhAgk9ZH4xlkTunzw6fVUqxVTz1cnwc81PW0MDuhjQ93v 1yH34TBq4Cq+waQmb0ZooZIGDB5bBDOmZQs6VHhq8+SNXDOFNmDrOougVGtXZGynWPo8 h+IMTq5F949iVwt4pOAlGg2y8s3TK5J+O8iAWeo9mvSKlf0DGH1jhToixD78uaFcHpFD 0F+A== X-Gm-Message-State: AOAM532YUT+bETSN+fL42LzeSyd3aMvz/F1KRqsZjtz9bu6AyvSxbJi2 NldVW0iN3aHIGj3oInbrdDs= X-Google-Smtp-Source: ABdhPJwDUNyet8V+rYqybZMW4aewS6nXoTRbi5Gko1Sgw0E1zV4Kok8rYlEFd2TRnec9qik6ZS3sVQ== X-Received: by 2002:a62:5382:0:b029:155:6333:ce4f with SMTP id h124-20020a6253820000b02901556333ce4fmr3444030pfb.28.1604597637374; Thu, 05 Nov 2020 09:33:57 -0800 (PST) Received: from google.com ([2620:15c:211:201:7220:84ff:fe09:5e58]) by smtp.gmail.com with ESMTPSA id h26sm3229500pfq.139.2020.11.05.09.33.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Nov 2020 09:33:56 -0800 (PST) Date: Thu, 5 Nov 2020 09:33:54 -0800 From: Minchan Kim To: Matthew Wilcox Cc: Andrew Morton , linux-kernel@vger.kernel.org, linux-mm , "Aneesh Kumar K . V" , Harish Sriram , stable@vger.kernel.org Subject: Re: [PATCH] Revert "mm/vunmap: add cond_resched() in vunmap_pmd_range" Message-ID: <20201105173354.GB387236@google.com> References: <20201105170249.387069-1-minchan@kernel.org> <20201105171602.GP17076@casper.infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201105171602.GP17076@casper.infradead.org> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000271, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Nov 05, 2020 at 05:16:02PM +0000, Matthew Wilcox wrote: > On Thu, Nov 05, 2020 at 09:02:49AM -0800, Minchan Kim wrote: > > This reverts commit e47110e90584a22e9980510b00d0dfad3a83354e. > > > > While I was doing zram testing, I found sometimes decompression failed > > since the compression buffer was corrupted. With investigation, > > I found below commit calls cond_resched unconditionally so it could > > make a problem in atomic context if the task is reschedule. > > I don't think you're supposed to call unmap_kernel_range() from > atomic context. At least vfree() punts to __vfree_deferred() if > in_interrupt() is true. I forget the original reason for why that is. It would be desirable, However, the logic was there for several years and made regression from the commit in stable kernel for now. Can't we have graceful shutdown if we want to deprecate the API usecase in atomic context?