From: Barry Song <song.bao.hua@hisilicon.com>
To: <akpm@linux-foundation.org>, <linux-mm@kvack.org>,
<linux-kernel@vger.kernel.org>
Cc: <linuxarm@huawei.com>, Barry Song <song.bao.hua@hisilicon.com>,
"John Hubbard" <jhubbard@nvidia.com>,
Ralph Campbell <rcampbell@nvidia.com>,
"John Garry" <john.garry@huawei.com>
Subject: [PATCH] mm/gup_benchmark: GUP_BENCHMARK depends on DEBUG_FS
Date: Wed, 4 Nov 2020 23:05:52 +1300 [thread overview]
Message-ID: <20201104100552.20156-1-song.bao.hua@hisilicon.com> (raw)
Without DEBUG_FS, all the code in gup_benchmark becomes meaningless.
For sure kernel provides debugfs stub while DEBUG_FS is disabled, but
the point here is that GUP_BENCHMARK can do nothing without DEBUG_FS.
Cc: John Hubbard <jhubbard@nvidia.com>
Cc: Ralph Campbell <rcampbell@nvidia.com>
Inspired-by: John Garry <john.garry@huawei.com>
Signed-off-by: Barry Song <song.bao.hua@hisilicon.com>
---
* inspired by John's comment in this patch:
https://lore.kernel.org/linux-iommu/184797b8-512e-e3da-fae7-25c7d662648b@huawei.com/
mm/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/mm/Kconfig b/mm/Kconfig
index d42423f..91fa923 100644
--- a/mm/Kconfig
+++ b/mm/Kconfig
@@ -836,6 +836,7 @@ config PERCPU_STATS
config GUP_BENCHMARK
bool "Enable infrastructure for get_user_pages() and related calls benchmarking"
+ depends on DEBUG_FS
help
Provides /sys/kernel/debug/gup_benchmark that helps with testing
performance of get_user_pages() and related calls.
--
2.7.4
next reply other threads:[~2020-11-04 10:10 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-04 10:05 Barry Song [this message]
2020-11-07 0:12 ` John Hubbard
2020-11-07 19:05 ` Song Bao Hua (Barry Song)
2020-11-07 19:16 ` John Hubbard
2020-11-07 22:20 ` Randy Dunlap
2020-11-08 0:03 ` John Hubbard
2020-11-08 0:24 ` Randy Dunlap
2020-11-08 1:10 ` John Hubbard
2020-11-08 2:58 ` Song Bao Hua (Barry Song)
2020-11-08 3:14 ` John Hubbard
2020-11-08 3:22 ` John Hubbard
2020-11-08 4:11 ` Randy Dunlap
2020-11-08 4:34 ` Song Bao Hua (Barry Song)
2020-11-08 4:55 ` John Hubbard
2020-11-08 7:35 ` Song Bao Hua (Barry Song)
2020-11-08 7:53 ` John Hubbard
2020-11-08 4:05 ` Song Bao Hua (Barry Song)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201104100552.20156-1-song.bao.hua@hisilicon.com \
--to=song.bao.hua@hisilicon.com \
--cc=akpm@linux-foundation.org \
--cc=jhubbard@nvidia.com \
--cc=john.garry@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linuxarm@huawei.com \
--cc=rcampbell@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox