From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79CBFC2D0A3 for ; Tue, 3 Nov 2020 15:04:00 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E169620757 for ; Tue, 3 Nov 2020 15:03:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=shutemov-name.20150623.gappssmtp.com header.i=@shutemov-name.20150623.gappssmtp.com header.b="tvx1xqsT" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E169620757 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=shutemov.name Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 7740F6B0070; Tue, 3 Nov 2020 10:03:59 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6FC886B0071; Tue, 3 Nov 2020 10:03:59 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5C4BA6B0072; Tue, 3 Nov 2020 10:03:59 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0070.hostedemail.com [216.40.44.70]) by kanga.kvack.org (Postfix) with ESMTP id 2B2C96B0070 for ; Tue, 3 Nov 2020 10:03:59 -0500 (EST) Received: from smtpin01.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id C526482499B9 for ; Tue, 3 Nov 2020 15:03:58 +0000 (UTC) X-FDA: 77443426956.01.move53_2a03dbb272b9 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin01.hostedemail.com (Postfix) with ESMTP id 1F22110048E23 for ; Tue, 3 Nov 2020 15:02:58 +0000 (UTC) X-HE-Tag: move53_2a03dbb272b9 X-Filterd-Recvd-Size: 3929 Received: from mail-lf1-f68.google.com (mail-lf1-f68.google.com [209.85.167.68]) by imf42.hostedemail.com (Postfix) with ESMTP for ; Tue, 3 Nov 2020 15:02:57 +0000 (UTC) Received: by mail-lf1-f68.google.com with SMTP id f9so22609612lfq.2 for ; Tue, 03 Nov 2020 07:02:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov-name.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=7jcPc4llK3umLuED1mkEXvhY3Q7RrHaM1AI2cqwIIJ8=; b=tvx1xqsTPdLgHRogOOX9SdNUmX0wsDUfRENvHTZWLdbdH+UyHISAsypSXOQFJ489A6 tfOXGwSdZ48nF9xEdPXLhYvSgQLBXdnKSB90wOvz+nfP8CE319sdTO0SaTIIE3/tsLJT ocwI5Il2HKEhpF7/P3dS2zezlAYcCl+6l3W7HWQ+haQ+V7uPmBRmuHhp5l8VpvHTl6d7 1rk/Z2vPCCXCj8siVszfyL93gCwZbxOCwyRTwPdo42E2rxKo4Qyvc59nFqjCd3sG9599 YOMOMN2L7EffCV+14jSZaDdDQqp3wdg4kihTGeNbOvNFmWCuYuDoc4d/5u1p8Prc0G+2 Z74Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=7jcPc4llK3umLuED1mkEXvhY3Q7RrHaM1AI2cqwIIJ8=; b=eI4ziTn5ge8ucm6OQn9TZ5Wiu35EmF4JVffiYgo4VMnE7Y3mVfv6DbGh3zRFlk2U6N 4lUvJQ40dWN7GZlTyQ79PdgvQji2uDJ7lw7LlbvAsdHYJJDNNEQv5shf06VFvka2qMOB IUgCQ1jskI+MNJkkwSTy5NDTFq+V7pJdKkQslBrjeyDdSoJhyea5DpNj12riyS6YWgwJ yZSPBASCsrUDk2kO/7WCH3ANsLXpcMWOtMLthaWtuT20YfVHfyuvcKFkJJKICAfBrW8O MRDrHle+SHRkTI+oghnKZmCWkN+JcQ/2af7sTq+t7p3GADqN70srdrp/KJ8qPZCi/AC/ WQ3w== X-Gm-Message-State: AOAM5339XaV4uc5ynmMqcu67yIhBvo0ieDaFK8F6ODfZgAt5ZV/77ccS R/iii0/oz9dU0FZOJHjX4FlBeQ== X-Google-Smtp-Source: ABdhPJwmJPOx1mT33IvdRMNs1KxjItkVvaeqC20e4RkaPSfGvVQoyrzsYzwBMm7hk+ZOcmOj4Irqsg== X-Received: by 2002:a05:6512:1087:: with SMTP id j7mr7485959lfg.122.1604415776008; Tue, 03 Nov 2020 07:02:56 -0800 (PST) Received: from box.localdomain ([86.57.175.117]) by smtp.gmail.com with ESMTPSA id m22sm3949065lfb.27.2020.11.03.07.02.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Nov 2020 07:02:55 -0800 (PST) Received: by box.localdomain (Postfix, from userid 1000) id 9755310231C; Tue, 3 Nov 2020 18:02:56 +0300 (+03) Date: Tue, 3 Nov 2020 18:02:56 +0300 From: "Kirill A. Shutemov" To: Matthew Wilcox Cc: linux-mm@kvack.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH 05/19] mm/filemap: Rename generic_file_buffered_read subfunctions Message-ID: <20201103150256.5b3fybreliugegxf@box> References: <20201029193405.29125-1-willy@infradead.org> <20201029193405.29125-6-willy@infradead.org> <20201103141601.4szfbauqg33xbyzm@box> <20201103144014.GV27442@casper.infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201103144014.GV27442@casper.infradead.org> X-Bogosity: Ham, tests=bogofilter, spamicity=0.012565, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Nov 03, 2020 at 02:40:14PM +0000, Matthew Wilcox wrote: > On Tue, Nov 03, 2020 at 05:16:01PM +0300, Kirill A. Shutemov wrote: > > On Thu, Oct 29, 2020 at 07:33:51PM +0000, Matthew Wilcox (Oracle) wrote: > > > generic_file_buffered_read_readpage -> gfbr_read_page > > > generic_file_buffered_read_pagenotuptodate -> gfbr_update_page > > > generic_file_buffered_read_no_cached_page -> gfbr_create_page > > > generic_file_buffered_read_get_pages -> gfbr_get_pages > > > > Oh.. I hate this. "gfbr" is something you see in a spoon of letter soup. > > > > Maybe just drop few of these words? "buffered_read_" or "file_read_"? > > gfbr became filemap. See [PATCH 00/17] Refactor generic_file_buffered_read Okay, works for me. -- Kirill A. Shutemov