From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2487C2D0A3 for ; Tue, 3 Nov 2020 14:40:21 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id ED108223BF for ; Tue, 3 Nov 2020 14:40:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="vOG+1OuH" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ED108223BF Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 2CFBE6B0071; Tue, 3 Nov 2020 09:40:20 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 27F0E6B0072; Tue, 3 Nov 2020 09:40:20 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 197086B0073; Tue, 3 Nov 2020 09:40:20 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0020.hostedemail.com [216.40.44.20]) by kanga.kvack.org (Postfix) with ESMTP id DE6F56B0071 for ; Tue, 3 Nov 2020 09:40:19 -0500 (EST) Received: from smtpin15.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 40667348D for ; Tue, 3 Nov 2020 14:40:19 +0000 (UTC) X-FDA: 77443367358.15.shoes33_5b1430e272b9 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin15.hostedemail.com (Postfix) with ESMTP id 0135B1814B0C9 for ; Tue, 3 Nov 2020 14:40:18 +0000 (UTC) X-HE-Tag: shoes33_5b1430e272b9 X-Filterd-Recvd-Size: 2278 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf31.hostedemail.com (Postfix) with ESMTP for ; Tue, 3 Nov 2020 14:40:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=wdOqezQ3bAAIxDJtizX0HENDbmQT7EOU/T2lyZVw0AI=; b=vOG+1OuH8OL+FDt5N86n/4dege hPYyXHDHp7QWmSlGzQKiEp83LYXq1qtUxKmllHYOGGI7N0RyplM7YB0UtGg16qKjWE4gFl2y0+4kW 3kFPy2tesuOBxQ6fN0e+9D8KNhYRWpydh+NrLdm+Npxq/Qf7ub5TrvSf6ou3LIaD0SfYi4iUPZL/j 4cnoggC9IeEZmCP06DkctSprsH2JoBOts1INXXm+aakNnO0k7rrN2+Rcb6KO0CLgAGSOpBCRfuaki q+lUaR+/yYWlNn/mS57PLJcofyqxFk7V9S60jeyU3zT+kUhE0NsQpxi+35y9u3UFTLI7OrKqd62CD BBS8+mqQ==; Received: from willy by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1kZxTq-0002yf-PL; Tue, 03 Nov 2020 14:40:14 +0000 Date: Tue, 3 Nov 2020 14:40:14 +0000 From: Matthew Wilcox To: "Kirill A. Shutemov" Cc: linux-mm@kvack.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH 05/19] mm/filemap: Rename generic_file_buffered_read subfunctions Message-ID: <20201103144014.GV27442@casper.infradead.org> References: <20201029193405.29125-1-willy@infradead.org> <20201029193405.29125-6-willy@infradead.org> <20201103141601.4szfbauqg33xbyzm@box> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201103141601.4szfbauqg33xbyzm@box> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Nov 03, 2020 at 05:16:01PM +0300, Kirill A. Shutemov wrote: > On Thu, Oct 29, 2020 at 07:33:51PM +0000, Matthew Wilcox (Oracle) wrote: > > generic_file_buffered_read_readpage -> gfbr_read_page > > generic_file_buffered_read_pagenotuptodate -> gfbr_update_page > > generic_file_buffered_read_no_cached_page -> gfbr_create_page > > generic_file_buffered_read_get_pages -> gfbr_get_pages > > Oh.. I hate this. "gfbr" is something you see in a spoon of letter soup. > > Maybe just drop few of these words? "buffered_read_" or "file_read_"? gfbr became filemap. See [PATCH 00/17] Refactor generic_file_buffered_read