From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C90CAC2D0A3 for ; Tue, 3 Nov 2020 14:39:20 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0EE82223AC for ; Tue, 3 Nov 2020 14:39:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=shutemov-name.20150623.gappssmtp.com header.i=@shutemov-name.20150623.gappssmtp.com header.b="tYRtCsCJ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0EE82223AC Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=shutemov.name Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 1E7706B006E; Tue, 3 Nov 2020 09:39:19 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1714B6B0070; Tue, 3 Nov 2020 09:39:19 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 011326B0071; Tue, 3 Nov 2020 09:39:18 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0217.hostedemail.com [216.40.44.217]) by kanga.kvack.org (Postfix) with ESMTP id C98896B006E for ; Tue, 3 Nov 2020 09:39:18 -0500 (EST) Received: from smtpin11.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 62D8C1EE6 for ; Tue, 3 Nov 2020 14:39:18 +0000 (UTC) X-FDA: 77443364796.11.cent67_3a023ae272b9 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin11.hostedemail.com (Postfix) with ESMTP id 25CFC180F8B81 for ; Tue, 3 Nov 2020 14:39:18 +0000 (UTC) X-HE-Tag: cent67_3a023ae272b9 X-Filterd-Recvd-Size: 6123 Received: from mail-lj1-f194.google.com (mail-lj1-f194.google.com [209.85.208.194]) by imf07.hostedemail.com (Postfix) with ESMTP for ; Tue, 3 Nov 2020 14:39:17 +0000 (UTC) Received: by mail-lj1-f194.google.com with SMTP id i2so19318679ljg.4 for ; Tue, 03 Nov 2020 06:39:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov-name.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=M/CcLnAggfPJTPHCvJqAFAyQXrrFbGX8RqEWGTOIlRk=; b=tYRtCsCJ97u7yAlrOFN203Mpt9jz/EvbuW4V+3hipSUNsR5M8ZDqWsq7efoMiN9R5c nhVCnARjFr5alomHWUrG2S/QRxbOVwaEaiSQTgeF0uEgCJ7a2rbupEC/g2AUeshC9i6C wIKR126viYncqhHiZROMnSmO9imaid0rNJepyxM6rr8Apn+RPbJ3qWs7P+ZnHrSgvOWA QcXHZrEHzXM4SVCDzBK7zqXcUTu3T+G1dUvHRbLGUKs/I2DIfrL0bitkL+B4SCLYpFfX lHpCGqsodauH4LxSQSOtDBLKGW1a7DHfcCp5nbfeol5ZCBBoivuqpYvLjRQisIJ68BoF UMSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=M/CcLnAggfPJTPHCvJqAFAyQXrrFbGX8RqEWGTOIlRk=; b=kmruF+Xq9nuXsfXImJZozJA4nObGBxpajVrdtTDEmn/7xEgJMRTnjMnzQC53IYbxmy 3IzowNzOePGrGVQFV8iWc6FsHQHWCELx5nFmlsSlNng78P4JBSm6vM63aBKao4vV0McO UC4L6sSboN3OxFa+f7OSLNNx4Zw0CZuYvpNlwduBHtLxIIniUAk5kIrmZZ6Z0TT5MqXC E/As/KAKXZTeibUPXLR98Got7/4QCNTqtU6djbU7dS/D+dw28DEw7idZBzi3wFoBGk+C dCagRSB2nu9m7WOto5zED4C1e8mpwoOyeM2uUCtOuPizyUGCNZ5wggMB3SS/XxYeG0cf E6tw== X-Gm-Message-State: AOAM530n/zLxKsYXFdDUSSUyMryS4vHDMv1/gC0ELa5FKPof8U9ZJnQi /LzuiRsdaiHtDjWnepIxP/IDFQ== X-Google-Smtp-Source: ABdhPJz+L8qrHCJkzOuQS8/wvO1dQM/ksNE/UzgTA6Cx0Ac2GRFSZ5fX6eoakfcdH0CZnI4/h7s3ng== X-Received: by 2002:a2e:879a:: with SMTP id n26mr9115208lji.347.1604414356208; Tue, 03 Nov 2020 06:39:16 -0800 (PST) Received: from box.localdomain ([86.57.175.117]) by smtp.gmail.com with ESMTPSA id g27sm4334360ljl.91.2020.11.03.06.39.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Nov 2020 06:39:15 -0800 (PST) Received: by box.localdomain (Postfix, from userid 1000) id 65F1510231C; Tue, 3 Nov 2020 17:39:16 +0300 (+03) Date: Tue, 3 Nov 2020 17:39:16 +0300 From: "Kirill A. Shutemov" To: Mike Rapoport Cc: Andrew Morton , Albert Ou , Andy Lutomirski , Benjamin Herrenschmidt , Borislav Petkov , Catalin Marinas , Christian Borntraeger , Christoph Lameter , "David S. Miller" , Dave Hansen , David Hildenbrand , David Rientjes , "Edgecombe, Rick P" , "H. Peter Anvin" , Heiko Carstens , Ingo Molnar , Joonsoo Kim , Len Brown , Michael Ellerman , Mike Rapoport , Palmer Dabbelt , Paul Mackerras , Paul Walmsley , Pavel Machek , Pekka Enberg , Peter Zijlstra , "Rafael J. Wysocki" , Thomas Gleixner , Vasily Gorbik , Will Deacon , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-pm@vger.kernel.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, sparclinux@vger.kernel.org, x86@kernel.org, "Rafael J . Wysocki" Subject: Re: [PATCH v3 2/4] PM: hibernate: make direct map manipulations more explicit Message-ID: <20201103143916.otz2o4h2dlmewn3h@box> References: <20201101170815.9795-1-rppt@kernel.org> <20201101170815.9795-3-rppt@kernel.org> <20201103110816.t6a3ebtgcm7mfogy@box> <20201103121350.GI4879@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201103121350.GI4879@kernel.org> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Nov 03, 2020 at 02:13:50PM +0200, Mike Rapoport wrote: > On Tue, Nov 03, 2020 at 02:08:16PM +0300, Kirill A. Shutemov wrote: > > On Sun, Nov 01, 2020 at 07:08:13PM +0200, Mike Rapoport wrote: > > > diff --git a/kernel/power/snapshot.c b/kernel/power/snapshot.c > > > index 46b1804c1ddf..054c8cce4236 100644 > > > --- a/kernel/power/snapshot.c > > > +++ b/kernel/power/snapshot.c > > > @@ -76,6 +76,32 @@ static inline void hibernate_restore_protect_page(void *page_address) {} > > > static inline void hibernate_restore_unprotect_page(void *page_address) {} > > > #endif /* CONFIG_STRICT_KERNEL_RWX && CONFIG_ARCH_HAS_SET_MEMORY */ > > > > > > +static inline void hibernate_map_page(struct page *page, int enable) > > > +{ > > > + if (IS_ENABLED(CONFIG_ARCH_HAS_SET_DIRECT_MAP)) { > > > + unsigned long addr = (unsigned long)page_address(page); > > > + int ret; > > > + > > > + /* > > > + * This should not fail because remapping a page here means > > > + * that we only update protection bits in an existing PTE. > > > + * It is still worth to have WARN_ON() here if something > > > + * changes and this will no longer be the case. > > > + */ > > > + if (enable) > > > + ret = set_direct_map_default_noflush(page); > > > + else > > > + ret = set_direct_map_invalid_noflush(page); > > > + > > > + if (WARN_ON(ret)) > > > > _ONCE? > > I've changed it to pr_warn() after David said people enable panic on > warn in production kernels. pr_warn_once()? :P -- Kirill A. Shutemov