From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0258C388F9 for ; Tue, 3 Nov 2020 14:16:04 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 65A0922280 for ; Tue, 3 Nov 2020 14:16:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=shutemov-name.20150623.gappssmtp.com header.i=@shutemov-name.20150623.gappssmtp.com header.b="1uKcWqxf" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 65A0922280 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=shutemov.name Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C0EA06B005C; Tue, 3 Nov 2020 09:16:03 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BBF8F6B006C; Tue, 3 Nov 2020 09:16:03 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A87436B006E; Tue, 3 Nov 2020 09:16:03 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0226.hostedemail.com [216.40.44.226]) by kanga.kvack.org (Postfix) with ESMTP id 792CD6B005C for ; Tue, 3 Nov 2020 09:16:03 -0500 (EST) Received: from smtpin22.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 1CD14181AC9C6 for ; Tue, 3 Nov 2020 14:16:03 +0000 (UTC) X-FDA: 77443306206.22.comb62_3a0efc7272b9 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin22.hostedemail.com (Postfix) with ESMTP id D47CE18038E68 for ; Tue, 3 Nov 2020 14:16:02 +0000 (UTC) X-HE-Tag: comb62_3a0efc7272b9 X-Filterd-Recvd-Size: 3568 Received: from mail-lf1-f65.google.com (mail-lf1-f65.google.com [209.85.167.65]) by imf32.hostedemail.com (Postfix) with ESMTP for ; Tue, 3 Nov 2020 14:16:02 +0000 (UTC) Received: by mail-lf1-f65.google.com with SMTP id a7so22339337lfk.9 for ; Tue, 03 Nov 2020 06:16:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov-name.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=a9gv5kRF1TAOEsPNy0ASAI0MDTfRXeZ38ProsMVeXYQ=; b=1uKcWqxfPVgTGjaKzWFN4y0aYEYIe1k4mmfFhSdUGVJOFcCfQ3DrLY+HLkBKHcDKoG lHzl0qSMqjBvoDValimJMHTzHKRCdnHz5TuqMSyBCbuslc8bU252nXn7TbJ1pDf0Q3AH YRbEACl602dG9U7kfPad0ol6nyKbuXjecC15cgO/VGbHW+KgpHToZOnTXl+IkxgE0RvU NON1vvvtWBo0tjp8/DmyC0Aft7uNBf9Z/97/OESA5gTEukHUf4cxWnY36m3L4zjQucGw oY7CLxiiKPvWOeYbDT3XzNz+2avuo2DvciQ8XvhcAF4MFul3rlz0Y/ma8pBpfdylCY6Y SVEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=a9gv5kRF1TAOEsPNy0ASAI0MDTfRXeZ38ProsMVeXYQ=; b=NSjn/U8iWLP4Ij4WeoqrnD1Q2rD1w2kt58W44EyQh4xxVfTSlavbVJCHg3wJx/Gcz8 l4/213DZwUI/xo5c/WwvjYXNGHlKMPuhX3V183uF0IqbcKAAfO5YoDiqNgNv38EtcnBZ bvMu21M49N+KIezQ59LT90GpRFUkjLKVehpZmVrdtnop8IrDsmVHsxUZ7B5z9OQJgLKs 6j1EoQwEdJ5YtxdcZ2e5iNI9WZ6rB3DBNwWxXPiCPZetLbgZFLxTMVYZm9sqsBJJXkkm 1FrGmJuBieEEBhMtDY987bTbsAA4EGKBLcdzz3rv7X6UPmPYAu9gNDBrZ56Yb/CqdaAJ vRZw== X-Gm-Message-State: AOAM533GFVavXtcNSrw+8rK77x1wj9Z6LK+mzAaL2FEGNmDiA1789ks7 neGBdQYwjmTo4DdNMZa7Jg77lQ== X-Google-Smtp-Source: ABdhPJwnyyyrroqZF05jvl4O9xQ5ovDUuXNo/iH48fqaU94GprB7snvK5YYvvDCUsa6cndaeDB+ZKA== X-Received: by 2002:a19:7cf:: with SMTP id 198mr8412275lfh.266.1604412961000; Tue, 03 Nov 2020 06:16:01 -0800 (PST) Received: from box.localdomain ([86.57.175.117]) by smtp.gmail.com with ESMTPSA id e10sm4314433ljl.41.2020.11.03.06.16.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Nov 2020 06:16:00 -0800 (PST) Received: by box.localdomain (Postfix, from userid 1000) id A5E6D10231C; Tue, 3 Nov 2020 17:16:01 +0300 (+03) Date: Tue, 3 Nov 2020 17:16:01 +0300 From: "Kirill A. Shutemov" To: "Matthew Wilcox (Oracle)" Cc: linux-mm@kvack.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH 05/19] mm/filemap: Rename generic_file_buffered_read subfunctions Message-ID: <20201103141601.4szfbauqg33xbyzm@box> References: <20201029193405.29125-1-willy@infradead.org> <20201029193405.29125-6-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201029193405.29125-6-willy@infradead.org> X-Bogosity: Ham, tests=bogofilter, spamicity=0.093176, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Oct 29, 2020 at 07:33:51PM +0000, Matthew Wilcox (Oracle) wrote: > generic_file_buffered_read_readpage -> gfbr_read_page > generic_file_buffered_read_pagenotuptodate -> gfbr_update_page > generic_file_buffered_read_no_cached_page -> gfbr_create_page > generic_file_buffered_read_get_pages -> gfbr_get_pages Oh.. I hate this. "gfbr" is something you see in a spoon of letter soup. Maybe just drop few of these words? "buffered_read_" or "file_read_"? -- Kirill A. Shutemov