From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0801C2D0A3 for ; Tue, 3 Nov 2020 14:04:25 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3259222243 for ; Tue, 3 Nov 2020 14:04:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=shutemov-name.20150623.gappssmtp.com header.i=@shutemov-name.20150623.gappssmtp.com header.b="XqSacWEo" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3259222243 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=shutemov.name Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id BE0446B0068; Tue, 3 Nov 2020 09:04:24 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BB6FF6B006C; Tue, 3 Nov 2020 09:04:24 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A7EF46B006E; Tue, 3 Nov 2020 09:04:24 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0150.hostedemail.com [216.40.44.150]) by kanga.kvack.org (Postfix) with ESMTP id 7412D6B0068 for ; Tue, 3 Nov 2020 09:04:24 -0500 (EST) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 0E2A9180AD80F for ; Tue, 3 Nov 2020 14:04:24 +0000 (UTC) X-FDA: 77443276848.19.front83_2f069b8272b9 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin19.hostedemail.com (Postfix) with ESMTP id C114F1AD1B9 for ; Tue, 3 Nov 2020 14:04:23 +0000 (UTC) X-HE-Tag: front83_2f069b8272b9 X-Filterd-Recvd-Size: 3601 Received: from mail-lf1-f67.google.com (mail-lf1-f67.google.com [209.85.167.67]) by imf09.hostedemail.com (Postfix) with ESMTP for ; Tue, 3 Nov 2020 14:04:23 +0000 (UTC) Received: by mail-lf1-f67.google.com with SMTP id s30so42487lfc.4 for ; Tue, 03 Nov 2020 06:04:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov-name.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=tQEztWlaS7JtdJFovU8fWLlzfDszLf3xC5WKPOKeT3k=; b=XqSacWEoT3DZ+pElqGH+IfCgBpUmp16LYy0oi58xIsrVz8X5yLjsrWf93RFDCViHh0 /OcWEvxKWsxPpE+X1qfqfnNXVyGY2vWzY4ZtCc+a5lF3x4zYvGLWCRzQKktDlQML/7rD jJFpci52KD7XNGrcXRVtI1RnWSEW4UMBtG94n9k8p27l1D8kXtA68XBuWbICzST1BcEP 0U09KO3cHJt/1EwA+kFdvnWF4tSj0uNI6nMgQGr3RL9Ylt/EJDgfLCqfAlAbfQeIPprr XINf3C8FReE93sj+1oF3sdwAlTkxlLhYv9dDPxux7qN7kpWDfITIQSnwmcoSXewXEXmY +WFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=tQEztWlaS7JtdJFovU8fWLlzfDszLf3xC5WKPOKeT3k=; b=J3hkfuvebg4dBKbC3YDQR1XFmHZzWN1YAVe6SP8iue6iEm+YxWxygIiBQqz1h7v3QZ CEq1+8xbyYQExuqF9WhnhXkTcwGn+vx6LJ/w1Cg0+tqdDO/fWahMef83R/W32G5hEwRO hZX3aePgJ+jR1yF9v2ROG5P+C8aPbBh7sXrvJBzpPi78CHfZzG78EN2M/7BRFpVmN+Zw 8WJazWNacdvqR1udGXxs9edOu1aV0D/71VWotJ/3+MKYhCSid8hkvntpcXvS78b8abV1 WDxc6gXSkinxtbMKOYYEd1vlKaxqoUuKP2YKhutFhOZ+n0DDedJCdGqjfzPtxkbIQtik R8ig== X-Gm-Message-State: AOAM533YJZ1U4egcByuK8YZ7yTQURKWQYn1gecE0ts0Z8smg5aumFFtr ECjekGjQbRG+xLV/pD3g4Fz1zw== X-Google-Smtp-Source: ABdhPJyrKNM92hUpbMTkmnXF4TxO8r+uUZXkrMuPwPFl4EHA4JL9REWJV3KSvzVks6bQGIMJCgNqPQ== X-Received: by 2002:ac2:5970:: with SMTP id h16mr2259851lfp.583.1604412260694; Tue, 03 Nov 2020 06:04:20 -0800 (PST) Received: from box.localdomain ([86.57.175.117]) by smtp.gmail.com with ESMTPSA id l3sm3860608lfp.219.2020.11.03.06.04.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Nov 2020 06:04:20 -0800 (PST) Received: by box.localdomain (Postfix, from userid 1000) id 1BCB110231C; Tue, 3 Nov 2020 17:04:21 +0300 (+03) Date: Tue, 3 Nov 2020 17:04:21 +0300 From: "Kirill A. Shutemov" To: "Matthew Wilcox (Oracle)" Cc: linux-mm@kvack.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH 02/19] mm: Use multi-index entries in the page cache Message-ID: <20201103140421.alhfhxwlye5ygwkn@box> References: <20201029193405.29125-1-willy@infradead.org> <20201029193405.29125-3-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201029193405.29125-3-willy@infradead.org> X-Bogosity: Ham, tests=bogofilter, spamicity=0.021816, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Oct 29, 2020 at 07:33:48PM +0000, Matthew Wilcox (Oracle) wrote: > +static inline bool thp_last_tail(struct page *head, pgoff_t index) > +{ > + if (!PageTransCompound(head) || PageHuge(head)) > + return true; Do we need the branch? It's going to be reduced to index == head->index for non-THP anyway. It should be fine, right? > + return index == head->index + thp_nr_pages(head) - 1; > +} > + It's true for non-THP, so name is somewhat misleading. Maybe is_last_subpage() or something? -- Kirill A. Shutemov