From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95DBDC388F7 for ; Tue, 3 Nov 2020 07:50:28 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 49F5F22384 for ; Tue, 3 Nov 2020 07:50:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 49F5F22384 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id A606D6B0073; Tue, 3 Nov 2020 02:50:27 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A36296B0074; Tue, 3 Nov 2020 02:50:27 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8AFB26B0075; Tue, 3 Nov 2020 02:50:27 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0022.hostedemail.com [216.40.44.22]) by kanga.kvack.org (Postfix) with ESMTP id 5C6EF6B0073 for ; Tue, 3 Nov 2020 02:50:27 -0500 (EST) Received: from smtpin27.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id E19BF8249980 for ; Tue, 3 Nov 2020 07:50:26 +0000 (UTC) X-FDA: 77442334452.27.watch39_021863d272b6 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin27.hostedemail.com (Postfix) with ESMTP id BB17E3D669 for ; Tue, 3 Nov 2020 07:50:26 +0000 (UTC) X-HE-Tag: watch39_021863d272b6 X-Filterd-Recvd-Size: 1167 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf30.hostedemail.com (Postfix) with ESMTP for ; Tue, 3 Nov 2020 07:50:26 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id 7370C67373; Tue, 3 Nov 2020 08:50:24 +0100 (CET) Date: Tue, 3 Nov 2020 08:50:24 +0100 From: Christoph Hellwig To: "Matthew Wilcox (Oracle)" Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, hch@lst.de, kent.overstreet@gmail.com Subject: Re: [PATCH 13/17] mm/filemap: Remove parameters from filemap_update_page() Message-ID: <20201103075024.GL8389@lst.de> References: <20201102184312.25926-1-willy@infradead.org> <20201102184312.25926-14-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201102184312.25926-14-willy@infradead.org> User-Agent: Mutt/1.5.17 (2007-11-01) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Nov 02, 2020 at 06:43:08PM +0000, Matthew Wilcox (Oracle) wrote: > The 'pos' and 'count' params are no longer used in filemap_update_page() Shouldn't this go into the patch that removes the usage of the parameters?