From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84A13C388F2 for ; Tue, 3 Nov 2020 07:28:10 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 043622222B for ; Tue, 3 Nov 2020 07:28:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 043622222B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 51B156B005C; Tue, 3 Nov 2020 02:28:09 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4A5836B005D; Tue, 3 Nov 2020 02:28:09 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 396126B0068; Tue, 3 Nov 2020 02:28:09 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0159.hostedemail.com [216.40.44.159]) by kanga.kvack.org (Postfix) with ESMTP id 0D4776B005C for ; Tue, 3 Nov 2020 02:28:09 -0500 (EST) Received: from smtpin04.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id A0C3F181AEF09 for ; Tue, 3 Nov 2020 07:28:08 +0000 (UTC) X-FDA: 77442278256.04.egg38_081242d272b6 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin04.hostedemail.com (Postfix) with ESMTP id 822968005031 for ; Tue, 3 Nov 2020 07:28:08 +0000 (UTC) X-HE-Tag: egg38_081242d272b6 X-Filterd-Recvd-Size: 1481 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf31.hostedemail.com (Postfix) with ESMTP for ; Tue, 3 Nov 2020 07:28:07 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id 96A5C67373; Tue, 3 Nov 2020 08:28:05 +0100 (CET) Date: Tue, 3 Nov 2020 08:28:05 +0100 From: Christoph Hellwig To: "Matthew Wilcox (Oracle)" Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, hch@lst.de, kent.overstreet@gmail.com Subject: Re: [PATCH 02/17] mm/filemap: Use THPs in generic_file_buffered_read Message-ID: <20201103072805.GB8389@lst.de> References: <20201102184312.25926-1-willy@infradead.org> <20201102184312.25926-3-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201102184312.25926-3-willy@infradead.org> User-Agent: Mutt/1.5.17 (2007-11-01) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Nov 02, 2020 at 06:42:57PM +0000, Matthew Wilcox (Oracle) wrote: > +static unsigned mapping_get_read_thps(struct address_space *mapping, > + pgoff_t index, unsigned int nr_pages, struct page **pages) This function could really use a comment describing it, as the name isn't overly descriptive. > +{ > + XA_STATE(xas, &mapping->i_pages, index); > + struct page *head; > + unsigned int ret = 0; I'd rename ret to nr_found to be a little more descriptive. Otherwise looks good: Reviewed-by: Christoph Hellwig