From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA9C1C00A89 for ; Mon, 2 Nov 2020 20:47:55 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 25B99205F4 for ; Mon, 2 Nov 2020 20:47:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=cmpxchg-org.20150623.gappssmtp.com header.i=@cmpxchg-org.20150623.gappssmtp.com header.b="AooKG3JK" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 25B99205F4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cmpxchg.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 7DA8E6B0036; Mon, 2 Nov 2020 15:47:54 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7B2AA6B005C; Mon, 2 Nov 2020 15:47:54 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6EE646B0068; Mon, 2 Nov 2020 15:47:54 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0207.hostedemail.com [216.40.44.207]) by kanga.kvack.org (Postfix) with ESMTP id 4248A6B0036 for ; Mon, 2 Nov 2020 15:47:54 -0500 (EST) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id E6E6A180AD807 for ; Mon, 2 Nov 2020 20:47:53 +0000 (UTC) X-FDA: 77440664826.06.car99_2317ec6272b3 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin06.hostedemail.com (Postfix) with ESMTP id C121110038E11 for ; Mon, 2 Nov 2020 20:47:53 +0000 (UTC) X-HE-Tag: car99_2317ec6272b3 X-Filterd-Recvd-Size: 4600 Received: from mail-qt1-f194.google.com (mail-qt1-f194.google.com [209.85.160.194]) by imf28.hostedemail.com (Postfix) with ESMTP for ; Mon, 2 Nov 2020 20:47:53 +0000 (UTC) Received: by mail-qt1-f194.google.com with SMTP id m14so10148242qtc.12 for ; Mon, 02 Nov 2020 12:47:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Nj7sBGiH3baY4a625q23mk4W+OwP4KOftkycQT8zu4o=; b=AooKG3JKnOmiHLh9nY54aYGlYs4PzFJ7MlNomW/8sYein7Vt3XnigPfayRPJcNRlrK ZBsuA/Hs9q+xHuwYyIZ0ExR0cE7+VVHZt8+QOG35Oru++TKZNJidpX/UuW05lxc4lHm1 ehdA1V95yP0ap2IzhmgDjDrWwUq0Ay+RBeA8L3zPBLBnKSdRN/CPrpWYwOpaPZv6oo+1 mJE7W5YL4VmmnXWJyxus2MHR2GjslNtuUQXItA05LBYMYAjYwNRjR8WGILXmQjuPsLFf tcxxfAY6lCD5wxFXijlzYwfHi+fE43euh1dwJzyDic0uGeDgD+zdvpLKx1MwijGOuhsd brUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Nj7sBGiH3baY4a625q23mk4W+OwP4KOftkycQT8zu4o=; b=pyS/cCf1GBbJu3oRV6bgYVRyxoasfwwT1uHeDDSicw+hzIoD2aeQA1l7AxWM/UyLIn bOXEeSGn0QVHenH9IB38s5fHQ7Sd+JAjkmiJ+PFSdFyHXf9gv9SnljAmHBZ0I3+nMaxQ 2hlWedTLLn5aLP/nCixQoBX5Jjbwm4tiag8IrFLr/IiHhhTGlp7lM/HIVIDiduxQPrWq dPi+kUeK9Ur5P3onOgiTlSaFD6ex2oEEzOhY0HdyZ4uif7dNBljkKtco37l4pACrxVf/ 1K1sBCu9M8/i6NwBL9guUMmyHjdyj22B/mki2AhcMLcdodsoMdHt9JnCOWqIt2wUxY4f dErQ== X-Gm-Message-State: AOAM533NeI1OgFg9jezLEYYyBnDWj1TapLYoovPF/lEgfHk24thTUXr0 oIpAW4jOY6ljnrHZU7tM6xx29Q== X-Google-Smtp-Source: ABdhPJwUqPE8UL+goivCuxPOedpZNc1PpHve+Wa7sHmVXfIF4vDKOnoQRO2PB2LDNWng556UnGVtYA== X-Received: by 2002:ac8:4f06:: with SMTP id b6mr16800372qte.163.1604350072520; Mon, 02 Nov 2020 12:47:52 -0800 (PST) Received: from localhost ([2620:10d:c091:480::1:2f6e]) by smtp.gmail.com with ESMTPSA id x22sm7963711qkn.125.2020.11.02.12.47.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Nov 2020 12:47:51 -0800 (PST) Date: Mon, 2 Nov 2020 15:46:07 -0500 From: Johannes Weiner To: Alex Shi Cc: akpm@linux-foundation.org, mgorman@techsingularity.net, tj@kernel.org, hughd@google.com, khlebnikov@yandex-team.ru, daniel.m.jordan@oracle.com, willy@infradead.org, lkp@intel.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, shakeelb@google.com, iamjoonsoo.kim@lge.com, richard.weiyang@gmail.com, kirill@shutemov.name, alexander.duyck@gmail.com, rong.a.chen@intel.com, mhocko@suse.com, vdavydov.dev@gmail.com, shy828301@gmail.com, Andrey Ryabinin , Jann Horn Subject: Re: [PATCH v20 20/20] mm/lru: revise the comments of lru_lock Message-ID: <20201102204607.GD740958@cmpxchg.org> References: <1603968305-8026-1-git-send-email-alex.shi@linux.alibaba.com> <1603968305-8026-21-git-send-email-alex.shi@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1603968305-8026-21-git-send-email-alex.shi@linux.alibaba.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Oct 29, 2020 at 06:45:05PM +0800, Alex Shi wrote: > From: Hugh Dickins > > Since we changed the pgdat->lru_lock to lruvec->lru_lock, it's time to > fix the incorrect comments in code. Also fixed some zone->lru_lock comment > error from ancient time. etc. > > I struggled to understand the comment above move_pages_to_lru() (surely > it never calls page_referenced()), and eventually realized that most of > it had got separated from shrink_active_list(): move that comment back. > > Signed-off-by: Hugh Dickins > Signed-off-by: Alex Shi > Cc: Andrew Morton > Cc: Tejun Heo > Cc: Andrey Ryabinin > Cc: Jann Horn > Cc: Mel Gorman > Cc: Johannes Weiner > Cc: Matthew Wilcox > Cc: Hugh Dickins > Cc: cgroups@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Cc: linux-mm@kvack.org Acked-by: Johannes Weiner