From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3338C00A89 for ; Mon, 2 Nov 2020 20:46:03 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id DB5B6206E5 for ; Mon, 2 Nov 2020 20:46:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=cmpxchg-org.20150623.gappssmtp.com header.i=@cmpxchg-org.20150623.gappssmtp.com header.b="GkYdoJDP" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DB5B6206E5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cmpxchg.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 0168C6B0036; Mon, 2 Nov 2020 15:46:02 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id F0D9A6B005C; Mon, 2 Nov 2020 15:46:01 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DFA7A6B0068; Mon, 2 Nov 2020 15:46:01 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0207.hostedemail.com [216.40.44.207]) by kanga.kvack.org (Postfix) with ESMTP id AAA9A6B0036 for ; Mon, 2 Nov 2020 15:46:01 -0500 (EST) Received: from smtpin11.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 4B5FF181AEF09 for ; Mon, 2 Nov 2020 20:46:01 +0000 (UTC) X-FDA: 77440660122.11.box81_180fd72272b2 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin11.hostedemail.com (Postfix) with ESMTP id 001E8180F8B80 for ; Mon, 2 Nov 2020 20:46:00 +0000 (UTC) X-HE-Tag: box81_180fd72272b2 X-Filterd-Recvd-Size: 4824 Received: from mail-qt1-f195.google.com (mail-qt1-f195.google.com [209.85.160.195]) by imf18.hostedemail.com (Postfix) with ESMTP for ; Mon, 2 Nov 2020 20:46:00 +0000 (UTC) Received: by mail-qt1-f195.google.com with SMTP id m65so10136608qte.11 for ; Mon, 02 Nov 2020 12:46:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=gB2e508EdlwqwocPMg7gSFq3mG+QyX2QZ372rPOjJ/0=; b=GkYdoJDP3SQawBGQzX6f6vlVSfuqoKuZi6YHT2czkvxud7XGR/gxb7pT8E9JRX0BM7 AvNke3kr4copQpUNeKato3NWktKZn1lTJDOtigAcUl2jZbZ9bjT/vOoyEMuOLG1qDpg8 GOM7xz+0GZBVO+TPEwNSNzSbvcfbflDoxFA4zLtKuH3uO3oqHajPdTEAVlB9bHCruMNX fW4rf3TPJJhY2i/p0WdoPnGZRHioMKc53ApqR1SLSSKZHh4ZR76W9xVQ7P9PiCjF1iFw S+fOHmuwKkLPOZ9wtu80sukk1jYcLnFOjCAIj8TxGvfQlIb/LfI7K0YOmmFMR6D97BOw 7iJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=gB2e508EdlwqwocPMg7gSFq3mG+QyX2QZ372rPOjJ/0=; b=bIMZ2LOOwi3A444wl2dzPdOYKAFod2PhU2sCWg0NQCRHpBLtS1dvssmKDqIAL4G0GN m1zJcSuDvW3MQaAw8Y4g8+tJQGItWaWGccJ3gZ/U2HMd56FflkNlSS/7t8San8rhw+Yb ommLkvnWJo6VIW6t3pjhwX94g4LfNADPI2JG7FH0vicw3yu/I8b2EHrtvMmlkKlHWT3f TX5zO6/6WAz1zdPrE1mdu2RQ8rxII6ac7+/e1W2Kuw05TQz/caJ8pyoCB7zdeRFi1vyI 9x1UasQbCnmOTt0PHr4bUkAbDft+wsGPLFN/Zg0kPWpjWjM+Agj3Lkfy787c+uFc8Ju0 cTcg== X-Gm-Message-State: AOAM532tIzQIRkof1/N9wVPAMJkfuW65Ppc32rVnFE3jN34AeD0vFNO/ NPMUFTnmT/tGuNbaf63AbIUTpw== X-Google-Smtp-Source: ABdhPJxudlJHRrYzOFWNo8jeGkzWZZdZucQ6P+YEDzHlTPpQ1eFVaOSr7/XsAs+QhppEnZoVEhob5g== X-Received: by 2002:ac8:6045:: with SMTP id k5mr15221157qtm.216.1604349959591; Mon, 02 Nov 2020 12:45:59 -0800 (PST) Received: from localhost ([2620:10d:c091:480::1:2f6e]) by smtp.gmail.com with ESMTPSA id 67sm8636195qkd.14.2020.11.02.12.45.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Nov 2020 12:45:58 -0800 (PST) Date: Mon, 2 Nov 2020 15:44:13 -0500 From: Johannes Weiner To: Alex Shi Cc: akpm@linux-foundation.org, mgorman@techsingularity.net, tj@kernel.org, hughd@google.com, khlebnikov@yandex-team.ru, daniel.m.jordan@oracle.com, willy@infradead.org, lkp@intel.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, shakeelb@google.com, iamjoonsoo.kim@lge.com, richard.weiyang@gmail.com, kirill@shutemov.name, alexander.duyck@gmail.com, rong.a.chen@intel.com, mhocko@suse.com, vdavydov.dev@gmail.com, shy828301@gmail.com, Alexander Duyck , Thomas Gleixner , Andrey Ryabinin Subject: Re: [PATCH v20 19/20] mm/lru: introduce the relock_page_lruvec function Message-ID: <20201102204413.GC740958@cmpxchg.org> References: <1603968305-8026-1-git-send-email-alex.shi@linux.alibaba.com> <1603968305-8026-20-git-send-email-alex.shi@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1603968305-8026-20-git-send-email-alex.shi@linux.alibaba.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Oct 29, 2020 at 06:45:04PM +0800, Alex Shi wrote: > From: Alexander Duyck > > Use this new function to replace repeated same code, no func change. > > When testing for relock we can avoid the need for RCU locking if we simply > compare the page pgdat and memcg pointers versus those that the lruvec is > holding. By doing this we can avoid the extra pointer walks and accesses of > the memory cgroup. > > In addition we can avoid the checks entirely if lruvec is currently NULL. > > Signed-off-by: Alexander Duyck > Signed-off-by: Alex Shi > Acked-by: Hugh Dickins > Cc: Johannes Weiner > Cc: Andrew Morton > Cc: Thomas Gleixner > Cc: Andrey Ryabinin > Cc: Matthew Wilcox > Cc: Mel Gorman > Cc: Konstantin Khlebnikov > Cc: Hugh Dickins > Cc: Tejun Heo > Cc: linux-kernel@vger.kernel.org > Cc: cgroups@vger.kernel.org > Cc: linux-mm@kvack.org Acked-by: Johannes Weiner