From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 937D0C00A89 for ; Mon, 2 Nov 2020 20:07:11 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 032A320870 for ; Mon, 2 Nov 2020 20:07:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="eSPa7GFs" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 032A320870 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 899A36B006E; Mon, 2 Nov 2020 15:07:10 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7F6F96B0070; Mon, 2 Nov 2020 15:07:10 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6BEDF6B0071; Mon, 2 Nov 2020 15:07:10 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0175.hostedemail.com [216.40.44.175]) by kanga.kvack.org (Postfix) with ESMTP id 36FFD6B006E for ; Mon, 2 Nov 2020 15:07:10 -0500 (EST) Received: from smtpin02.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id CDB53180AD806 for ; Mon, 2 Nov 2020 20:07:09 +0000 (UTC) X-FDA: 77440562178.02.bat29_1b0bfe4272b2 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin02.hostedemail.com (Postfix) with ESMTP id AEB0310097AA1 for ; Mon, 2 Nov 2020 20:07:09 +0000 (UTC) X-HE-Tag: bat29_1b0bfe4272b2 X-Filterd-Recvd-Size: 3349 Received: from mail-qk1-f194.google.com (mail-qk1-f194.google.com [209.85.222.194]) by imf24.hostedemail.com (Postfix) with ESMTP for ; Mon, 2 Nov 2020 20:07:09 +0000 (UTC) Received: by mail-qk1-f194.google.com with SMTP id k9so12650098qki.6 for ; Mon, 02 Nov 2020 12:07:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=WDVlqMiU8YOhIVKvJhh9GoXydLuGHoEWT5TLUaJudgM=; b=eSPa7GFso1D/Cp0X86OAklw4mhgBUKA9GElI+J4rfekhyAVs+eLflOc4RBOn6DZRH8 ueqqEde0aKuSBnJxLGcTUQHnBfRbsK1SPfrPmFtKRZCXVTmux9pN6TO3eng2e3j5LU/G 4qrnI3CFoXN3GfAL3SWzOsZcX70sdrBHKdQcuiXudx0ZjKdf4do/UOBvLlzRTVe21Kzp KTHAqDUhI3EN5jlOIzhv0q49wDxBlFpRFr8rMe/j1WdH3KifqdHrl/XxvC8vZwtBvBHR 1ieqa7dnTALs+4BizaA/6iJHZkC3wwPPom5yn8NnPR2YDai/wc2d7+ejEjI1F+vYzXMl fcig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=WDVlqMiU8YOhIVKvJhh9GoXydLuGHoEWT5TLUaJudgM=; b=KxOJcJ+rFpvcYcaXOUMtb7T/m4gc0Af7IMGwKBvSPYBgrvOstswd+5/zK4oS8WxtWn MEICBZj7xfOoK3EM1+fO7A+DwFRrQJME4nOvPkBAnp3DkFCh4REytBOzokU5E+HGFm3m jPgg8pZ0xbDk3p9Pz4tnBbqtkdC6U3Sob2Oog41ZC6Xe6l1O9jxD1IF8Ix3cOYbWHjT1 Ddx52TLxGolBsvNdw/OLrqhK5Krlnh6p3tbwi4FkPegexBwJiXHRNjkGn/QMFj9UUTne 8+nvOKa6ra9cgKrN+wpnbBIu67GyYyxwj9efkhtXtdswipNBLNRqiri/VAWey+rtghAp RDUg== X-Gm-Message-State: AOAM530oLF7XUwp+XEfGsY4mDpIIWwXna/a+01AY/q62hihtNlswSsOr dJrkNUwddfMwAjgdY1OWxktkU58nd4ck X-Google-Smtp-Source: ABdhPJx43YobDpT7KefvVcY6l3twmWICqv9QAOghJQFotDcLjD9NdDbfJ3llilqYK26909dia55bNg== X-Received: by 2002:a37:9c06:: with SMTP id f6mr16402291qke.197.1604347628765; Mon, 02 Nov 2020 12:07:08 -0800 (PST) Received: from moria.home.lan (c-73-219-103-14.hsd1.vt.comcast.net. [73.219.103.14]) by smtp.gmail.com with ESMTPSA id q20sm8838189qtl.69.2020.11.02.12.07.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Nov 2020 12:07:08 -0800 (PST) Date: Mon, 2 Nov 2020 15:07:06 -0500 From: Kent Overstreet To: "Matthew Wilcox (Oracle)" Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, Christoph Hellwig Subject: Re: [PATCH 17/17] mm: simplify generic_file_read_iter Message-ID: <20201102200706.GU2123636@moria.home.lan> References: <20201102184312.25926-1-willy@infradead.org> <20201102184312.25926-18-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201102184312.25926-18-willy@infradead.org> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Nov 02, 2020 at 06:43:12PM +0000, Matthew Wilcox (Oracle) wrote: > From: Christoph Hellwig > > Avoid the pointless goto out just for returning retval. > > Signed-off-by: Christoph Hellwig > Signed-off-by: Matthew Wilcox (Oracle) Reviewed-by: Kent Overstreet