From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D49CFC00A89 for ; Mon, 2 Nov 2020 19:51:01 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 5480420731 for ; Mon, 2 Nov 2020 19:51:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Lk8ZJ4UE" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5480420731 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 6C1776B0068; Mon, 2 Nov 2020 14:51:00 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 673546B006C; Mon, 2 Nov 2020 14:51:00 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5AE626B006E; Mon, 2 Nov 2020 14:51:00 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0147.hostedemail.com [216.40.44.147]) by kanga.kvack.org (Postfix) with ESMTP id 265DF6B0068 for ; Mon, 2 Nov 2020 14:51:00 -0500 (EST) Received: from smtpin11.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id BB2071EE6 for ; Mon, 2 Nov 2020 19:50:59 +0000 (UTC) X-FDA: 77440521438.11.cars71_4d122ca272b2 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin11.hostedemail.com (Postfix) with ESMTP id 8FB46180F8B82 for ; Mon, 2 Nov 2020 19:50:59 +0000 (UTC) X-HE-Tag: cars71_4d122ca272b2 X-Filterd-Recvd-Size: 3248 Received: from mail-qk1-f195.google.com (mail-qk1-f195.google.com [209.85.222.195]) by imf06.hostedemail.com (Postfix) with ESMTP for ; Mon, 2 Nov 2020 19:50:59 +0000 (UTC) Received: by mail-qk1-f195.google.com with SMTP id o205so5809468qke.10 for ; Mon, 02 Nov 2020 11:50:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=gc894B4zoxADm5OprgejF9jDffPRWPrPePcZPiXs5dY=; b=Lk8ZJ4UEEBwRfY4lJaVhBBy0agEt9NQpIUYLoo2W5tDvyc5FLb8o5lu5XfFoAnTPC3 X2CGlFK3bMGJsM75AiJWCvQuTT8rwFlKiSo/s4mzdAnRmxWqKV5WpPmpZx3yZbmo8Q5p JE5K4XgQn+sydA9c1CKPjaxioNM8W16B38GzSy5CEhi0kmbU2qP97MUVQDP5nEokhZWd hF9MBeNHMCxS7Adb6EJu60BEao3Xt4EO4oLpt68NLHsg4ygFsiH2byLwqJaDulKkN/LB XZ+z3MN06uLPR0+XHptA01KNTH876CVjmm3OSHYRIjymhihJVvtsgkHy50xs6DcQD1BX gyMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=gc894B4zoxADm5OprgejF9jDffPRWPrPePcZPiXs5dY=; b=rIPwbCjwe5vQd1zHS+CiMBJq5dVRBRKGptGWbXIwZGChaneOVJeJaUYNU12G3Br5rv 7U7rCsW9nO1v2fzs3/suPQ/+UKDX6uF3/VoKEn/58t9XQQRkGZFngEUYpxmNK6vaGYMV 7hc0culsxFLSZyIUet9144A5AjGtr8eViKnswGyDMLyzfWxIkq7ydEhQOYSj2EmWCteS NTCPCmlOpsT62pNOjMx5dXUB0lw3miUfFkhCoZzDKzLYtmDCdI0YX01hQ9tViPWMiq4e t2BEknPRHQUbgnJOSdZTMZle3lc27SYNOFExK09XMK4LPIFrWXYzaXe3RveWng7OwT99 KGIw== X-Gm-Message-State: AOAM530lbt9J8cfwCS07NoQKJcy9STkpcBoEgWrsxgKCSI/UDygAzdZn RpEkiQfe5eBKIOMTi7Xxsw== X-Google-Smtp-Source: ABdhPJzdpYW7OjInoujEjF7ASVOXKF5+I81mZOkDPMvkfyGd6315+1IDRcNHkw3TSdlBHjtTdNmgoA== X-Received: by 2002:ae9:e508:: with SMTP id w8mr16726122qkf.110.1604346658565; Mon, 02 Nov 2020 11:50:58 -0800 (PST) Received: from moria.home.lan (c-73-219-103-14.hsd1.vt.comcast.net. [73.219.103.14]) by smtp.gmail.com with ESMTPSA id o63sm3967962qkd.96.2020.11.02.11.50.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Nov 2020 11:50:58 -0800 (PST) Date: Mon, 2 Nov 2020 14:50:56 -0500 From: Kent Overstreet To: "Matthew Wilcox (Oracle)" Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, hch@lst.de Subject: Re: [PATCH 11/17] mm/filemap: Add filemap_range_uptodate Message-ID: <20201102195056.GO2123636@moria.home.lan> References: <20201102184312.25926-1-willy@infradead.org> <20201102184312.25926-12-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201102184312.25926-12-willy@infradead.org> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000129, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Nov 02, 2020 at 06:43:06PM +0000, Matthew Wilcox (Oracle) wrote: > Move the complicated condition and the calculations out of > filemap_update_page() into its own function. You're missing a signed-off-by Reviewed-by: Kent Overstreet