From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0E44C2D0A3 for ; Mon, 2 Nov 2020 19:17:16 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7323C20639 for ; Mon, 2 Nov 2020 19:17:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="G3/YvzBP" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7323C20639 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B61346B0036; Mon, 2 Nov 2020 14:17:15 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id AEAA76B005C; Mon, 2 Nov 2020 14:17:15 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9D8DB6B0068; Mon, 2 Nov 2020 14:17:15 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0247.hostedemail.com [216.40.44.247]) by kanga.kvack.org (Postfix) with ESMTP id 6EEEC6B0036 for ; Mon, 2 Nov 2020 14:17:15 -0500 (EST) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 16C611EE6 for ; Mon, 2 Nov 2020 19:17:15 +0000 (UTC) X-FDA: 77440436430.19.start07_46165a7272b2 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin19.hostedemail.com (Postfix) with ESMTP id ECE021AD1B5 for ; Mon, 2 Nov 2020 19:17:14 +0000 (UTC) X-HE-Tag: start07_46165a7272b2 X-Filterd-Recvd-Size: 3378 Received: from mail-qt1-f194.google.com (mail-qt1-f194.google.com [209.85.160.194]) by imf01.hostedemail.com (Postfix) with ESMTP for ; Mon, 2 Nov 2020 19:17:14 +0000 (UTC) Received: by mail-qt1-f194.google.com with SMTP id h12so10005655qtu.1 for ; Mon, 02 Nov 2020 11:17:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=2GeINr3PUVgdupvFShw4TU1fvCx5+pXXkokM7VFTZco=; b=G3/YvzBP709JP/ZojwwfAJZF+k52DpVmdaDs/I8hkO4Nruw8fq7O7WC5Ca2U2MOohJ Tj7jWZ6RtC6BHoxAMztYv2KNE/cmxsjHxmzBBdBVAVtASD/iFMMGIoO2Mbet3gJm4DM+ pQtZ4DucCKvI8K/3TQzDSW/TNzxsaH8nqgZAb6D7wMpthJjg7oWrILn2Wimh6inyknVF QM9A7Az5sYlJTQ6i5yJuSrJdb52WaVE1G81jIvLqoIOyuCQBCiHFrZj3SjjDVzVVD4/n ygERmx2CUBLeJNIkn4v7ch+u8rhq/v6+VgIGNVN48R+Mn5Avuj+jJ+aHrr6nhBmCVbxK GRSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=2GeINr3PUVgdupvFShw4TU1fvCx5+pXXkokM7VFTZco=; b=QSUt/VdiX9RaQyusS8LgnRj9xOwLg5Gnb+oIzLwtz87v5zmIpjz0supshtgzNw0gDG TtHBPLeipjxNBOK4xs5gkLE58c0sX1AxHX8e03wqNKsvtXC6WhU3ktDv7iBEzYdRxvt7 THZVS1EJiEM3370qIiz0cewoTt7xuyh1A2WdtIUtlVvoH/i9v3uDTzD42fLiPwjmWrMu q+ySD6vVlS+kDRRLCPJU0jvWqjzCveiwFC5iJ+bgRWZhjzqE80yx8aA6QXSrXlAkO1SH ortwNBN+jHeuMurXD9v8uo/qS2lUllWOCeRh8SBCxdA1HOpZIz7bnmX6vOtcTzcH5JrO rznA== X-Gm-Message-State: AOAM533CNmoyeD+rVK4H3PRhJcSpoqONFWZMLimkfmVnKNaf1XRZKBfv WDrRDhPOsCRdr82rCTs5Rw== X-Google-Smtp-Source: ABdhPJySu8zXlirtbToJ4+Lk8cVcoVia+6Epnj6QABoUhCkdBuTUh8jFokmAtGjfhXZZHrton4woFg== X-Received: by 2002:ac8:728b:: with SMTP id v11mr15609504qto.373.1604344633979; Mon, 02 Nov 2020 11:17:13 -0800 (PST) Received: from moria.home.lan (c-73-219-103-14.hsd1.vt.comcast.net. [73.219.103.14]) by smtp.gmail.com with ESMTPSA id i64sm8638295qtb.43.2020.11.02.11.17.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Nov 2020 11:17:13 -0800 (PST) Date: Mon, 2 Nov 2020 14:17:11 -0500 From: Kent Overstreet To: "Matthew Wilcox (Oracle)" Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, hch@lst.de Subject: Re: [PATCH 06/17] mm/filemap: Don't call ->readpage if IOCB_WAITQ is set Message-ID: <20201102191711.GJ2123636@moria.home.lan> References: <20201102184312.25926-1-willy@infradead.org> <20201102184312.25926-7-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201102184312.25926-7-willy@infradead.org> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Nov 02, 2020 at 06:43:01PM +0000, Matthew Wilcox (Oracle) wrote: > The readpage operation can block in many (most?) filesystems, so we > should punt to a work queue instead of calling it. This was the last > caller of lock_page_async(), so remove it. > > Signed-off-by: Matthew Wilcox (Oracle) Reviewed-by: Kent Overstreet