From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D3DCC2D0A3 for ; Mon, 2 Nov 2020 18:55:42 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 797BC22268 for ; Mon, 2 Nov 2020 18:55:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gqaNDzne" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 797BC22268 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id F1C3B6B0068; Mon, 2 Nov 2020 13:55:40 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EF2B56B006C; Mon, 2 Nov 2020 13:55:40 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E2FB66B006E; Mon, 2 Nov 2020 13:55:40 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0148.hostedemail.com [216.40.44.148]) by kanga.kvack.org (Postfix) with ESMTP id B48AA6B0068 for ; Mon, 2 Nov 2020 13:55:40 -0500 (EST) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 4B0881EF2 for ; Mon, 2 Nov 2020 18:55:40 +0000 (UTC) X-FDA: 77440382040.24.pot19_490d4e1272b2 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin24.hostedemail.com (Postfix) with ESMTP id DC4AF1A4A0 for ; Mon, 2 Nov 2020 18:55:39 +0000 (UTC) X-HE-Tag: pot19_490d4e1272b2 X-Filterd-Recvd-Size: 3544 Received: from mail-qt1-f193.google.com (mail-qt1-f193.google.com [209.85.160.193]) by imf24.hostedemail.com (Postfix) with ESMTP for ; Mon, 2 Nov 2020 18:55:39 +0000 (UTC) Received: by mail-qt1-f193.google.com with SMTP id r8so9906644qtp.13 for ; Mon, 02 Nov 2020 10:55:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=0MuHHQkQxkCnA9K9EG6Ur3HVjOP4w19FlJqIl/E58a0=; b=gqaNDzneZ37a04uL8XxZys13yoEgLHzxGZy4lZyF74sarrLlIbe/vXmz92Miv2huog q4e00O+K9segwAZ/vLTw797VTQ6dOJaURh2BkZl9W2Rpus4d7sjBOWLbZAsFeDoecbe/ YrIFIJ38HX/k4chY5mtjtM2xAc19TjWTzBKvPhmO/16/7tvAm9PH+EVVi1h33yDrJDb1 KEqXNF1/3gKgMZHhEp/Y+rgEpluOTV2ic0h+L7phnupLDJffXCj3LJM6rg55oZO6zI2W WwdhmVYqOPgaIG6TStT4MX47WTX9+8qVOmNHF7CobhY5/w/wvqQAOv3fbEtqR0j2VKZD FAQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=0MuHHQkQxkCnA9K9EG6Ur3HVjOP4w19FlJqIl/E58a0=; b=ZlnJEuP7MIAr7lkZIEAx/J8IILi/NUFihOS1lBf19i+a64zLYTzfLVbmjd644pmFpd efnMubm3ErgCz3WFhYVQvp/xTq6OwqjEbhLGTlUP8qI78TlTqxI0jEZozYCM5Bf1oYha WfQl6vyenyoVtF4Cva86NFa9FSguVN61S+zZgHi+OHzMdPfTd5CuN6JzvKnX6o3w5a+6 0Zbgfwimn3Kf2HyW+AFLbXRemEBkshjleDmDPNTYnWH78WVHyuI2yaAPBhIbqPd2hMkL hFXTo+slgi9sPBlW44LhL86VKHMJtZN9YDNcjNPSLZc+OVbcRV1misMECd+GJ24Xe2v0 OtuA== X-Gm-Message-State: AOAM532E39PPBIYdNd8m+VHcPlzIg75x/5aqVj7Xn/Yh4uSnU4nbVo7W Enc781vn8ZVkLKAzVmDRpg== X-Google-Smtp-Source: ABdhPJwe030Nob+p/W+gDWzhYQBgR0OOs+0g1LPFeF5dbPYOqgqFuKe6pzckxlFhcqOOiVhZUiKUww== X-Received: by 2002:ac8:7189:: with SMTP id w9mr2660598qto.288.1604343338117; Mon, 02 Nov 2020 10:55:38 -0800 (PST) Received: from moria.home.lan (c-73-219-103-14.hsd1.vt.comcast.net. [73.219.103.14]) by smtp.gmail.com with ESMTPSA id r55sm4843892qte.8.2020.11.02.10.55.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Nov 2020 10:55:37 -0800 (PST) Date: Mon, 2 Nov 2020 13:55:35 -0500 From: Kent Overstreet To: "Matthew Wilcox (Oracle)" Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, hch@lst.de Subject: Re: [PATCH 02/17] mm/filemap: Use THPs in generic_file_buffered_read Message-ID: <20201102185535.GE2123636@moria.home.lan> References: <20201102184312.25926-1-willy@infradead.org> <20201102184312.25926-3-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201102184312.25926-3-willy@infradead.org> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Nov 02, 2020 at 06:42:57PM +0000, Matthew Wilcox (Oracle) wrote: > Add mapping_get_read_thps() which returns the THPs which represent a > contiguous array of bytes in the file. It also stops when encountering > a page marked as Readahead or !Uptodate (but does return that page) > so it can be handled appropriately by filemap_get_pages(). That lets us > remove the loop in filemap_get_pages() and check only the last page. > > Signed-off-by: Matthew Wilcox (Oracle) Reviewed-by: Kent Overstreet